You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/18 19:39:21 UTC
[GitHub] [hive] viirya opened a new pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
viirya opened a new pull request #1794:
URL: https://github.com/apache/hive/pull/1794
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546403809
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
+1. Can you create a JIRA for this? I'm not sure if master branch also have this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao edited a comment on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao edited a comment on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748520491
OK. I tried to bump Accumulo version to 1.7.3 (the one used by master branch) and I got the exception:
```
select * from accumulo_table_1
[ERROR] TestAccumuloCliDriver.testCliDriver:59 Unexpected exception java.lang.NoClassDefFoundError: org/eigenbase/util/property/BooleanProperty
at org.apache.calcite.util.SaffronProperties.<init>(SaffronProperties.java:66)
at org.apache.calcite.util.SaffronProperties.instance(SaffronProperties.java:134)
at org.apache.calcite.util.Util.getDefaultCharset(Util.java:769)
at org.apache.calcite.rel.type.RelDataTypeFactoryImpl.getDefaultCharset(RelDataTypeFactoryImpl.java:565)
at org.apache.calcite.sql.type.SqlTypeUtil.addCharsetAndCollation(SqlTypeUtil.java:1070)
at org.apache.calcite.sql.type.SqlTypeFactoryImpl.createSqlType(SqlTypeFactoryImpl.java:65)
at org.apache.calcite.rex.RexBuilder.<init>(RexBuilder.java:114)
at org.apache.calcite.prepare.CalcitePrepareImpl.perform(CalcitePrepareImpl.java:991)
at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:149)
at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:106)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.logicalPlan(CalcitePlanner.java:1069)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.getOptimizedAST(CalcitePlanner.java:1085)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:364)
at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:11138)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:286)
at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:258)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:512)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
```
as in #1792. After applying patch there together with the version bump the issue seems gone, but without version bump it will still stuck for unknown reason. I'll update #1792 with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on a change in pull request #1794: HIVE-24553. Exclude calcite from test-jar dependency of hive-exec
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546411494
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
Created a JIRA. Updated the title and description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1794: HIVE-24553. Exclude calcite from test-jar dependency of hive-exec
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-749121620
Thanks @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546274190
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
I think the test-jar won't include shaded dependencies. Then un-shaded dependencies will be pull. So I think we need to exclude them.
If there are other places using hive-exec in test scope, I think they might also need to exclude these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546275101
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
Ah I see. I think there are a few other places with similar pattern, such as `hive-webhcat-java-client`. Should we exclude in all those places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748354064
@sunchao Looks like "testSetHeaderValue – org.apache.hive.beeline.cli.TestHiveCli" was passed now in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546276288
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
Yea, I think so. I will update this later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao edited a comment on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao edited a comment on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748520491
OK. I tried to bump Accumulo version to 1.7.3 (the one used by master branch) and I got the exception:
```
select * from accumulo_table_1
[ERROR] TestAccumuloCliDriver.testCliDriver:59 Unexpected exception java.lang.NoClassDefFoundError: org/eigenbase/util/property/BooleanProperty
at org.apache.calcite.util.SaffronProperties.<init>(SaffronProperties.java:66)
at org.apache.calcite.util.SaffronProperties.instance(SaffronProperties.java:134)
at org.apache.calcite.util.Util.getDefaultCharset(Util.java:769)
at org.apache.calcite.rel.type.RelDataTypeFactoryImpl.getDefaultCharset(RelDataTypeFactoryImpl.java:565)
at org.apache.calcite.sql.type.SqlTypeUtil.addCharsetAndCollation(SqlTypeUtil.java:1070)
at org.apache.calcite.sql.type.SqlTypeFactoryImpl.createSqlType(SqlTypeFactoryImpl.java:65)
at org.apache.calcite.rex.RexBuilder.<init>(RexBuilder.java:114)
at org.apache.calcite.prepare.CalcitePrepareImpl.perform(CalcitePrepareImpl.java:991)
at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:149)
at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:106)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.logicalPlan(CalcitePlanner.java:1069)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.getOptimizedAST(CalcitePlanner.java:1085)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:364)
at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:11138)
at org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:286)
at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:258)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:512)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
```
as in #1792. So perhaps with Accumulo 1.6.0 the exception got swallowed silently and therefore test got stuck. After applying patch there together with the version bump the issue seems gone, but without version bump it will still stuck for unknown reason. I'll update #1792 with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #1794: HIVE-24553. Exclude calcite from test-jar dependency of hive-exec
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #1794:
URL: https://github.com/apache/hive/pull/1794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546269392
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
Looks good as I no longer see the test failure 👍 . BTW do you know why we need to exclude calcite here but not in other places where `hive-exec` is also used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748523297
> OK. I tried to bump Accumulo version to 1.7.3 (the one used by master branch) and I got the exception:
>
> ```
> select * from accumulo_table_1
> [ERROR] TestAccumuloCliDriver.testCliDriver:59 Unexpected exception java.lang.NoClassDefFoundError: org/eigenbase/util/property/BooleanProperty
> at org.apache.calcite.util.SaffronProperties.<init>(SaffronProperties.java:66)
> at org.apache.calcite.util.SaffronProperties.instance(SaffronProperties.java:134)
> at org.apache.calcite.util.Util.getDefaultCharset(Util.java:769)
> at org.apache.calcite.rel.type.RelDataTypeFactoryImpl.getDefaultCharset(RelDataTypeFactoryImpl.java:565)
> at org.apache.calcite.sql.type.SqlTypeUtil.addCharsetAndCollation(SqlTypeUtil.java:1070)
> at org.apache.calcite.sql.type.SqlTypeFactoryImpl.createSqlType(SqlTypeFactoryImpl.java:65)
> at org.apache.calcite.rex.RexBuilder.<init>(RexBuilder.java:114)
> at org.apache.calcite.prepare.CalcitePrepareImpl.perform(CalcitePrepareImpl.java:991)
> at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:149)
> at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:106)
> at org.apache.hadoop.hive.ql.parse.CalcitePlanner.logicalPlan(CalcitePlanner.java:1069)
> at org.apache.hadoop.hive.ql.parse.CalcitePlanner.getOptimizedAST(CalcitePlanner.java:1085)
> at org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:364)
> at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:11138)
> at org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:286)
> at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:258)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:512)
> at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
> at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
> ```
>
> as in #1792. So perhaps with Accumulo 1.6.0 the exception got swallowed silently and therefore test got stuck. After applying patch there together with the version bump the issue seems gone, but without version bump it will still stuck for unknown reason. I'll update #1792 with this change.
So sounds like the stuck seems related to Accumulo version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748520491
OK. I tried to bump Accumulo version to 1.7.3 (the one used by master branch) and I got the exception:
```
Exception in thread "main" java.lang.NoClassDefFoundError: org/eigenbase/util/property/BooleanProperty
```
as in #1792. After applying patch there together with the version bump the issue seems gone, but without version bump it will still stuck for unknown reason. I'll update #1792 with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748523699
Yes seems so although I don't know the exact reason yet. There is also another JIRA mentioning a similar test stuck issue when upgrading Accumulo from 1.7.3 to 1.8.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546328630
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
I updated all hive-exec test-jar usage in all pom.xml files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748523166
Thanks. @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748431034
@sunchao Please let me know if you think this is good to merge. I will create a JIRA for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748516509
> > Thanks @viirya ! This looks good to me with one comment. BTW I'm looking at the `org.apache.hadoop.hive.cli.TestAccumuloCliDriver` being stuck during test and it seems started happening since #1356 (verified locally)
>
> Hmm, okay. Just stuck without any error/exception? Then it seems harder to figure out the reason.
Yes just stuck without any error/exception. Thread dump also doesn't give much information which is interesting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1794:
URL: https://github.com/apache/hive/pull/1794#issuecomment-748515525
> Thanks @viirya ! This looks good to me with one comment. BTW I'm looking at the `org.apache.hadoop.hive.cli.TestAccumuloCliDriver` being stuck during test and it seems started happening since #1356 (verified locally)
Hmm, okay. Just stuck without any error/exception? Then it seems harder to figure out the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on a change in pull request #1794: [DO-NOT-MERGE] Test exclude calcite in beeline
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #1794:
URL: https://github.com/apache/hive/pull/1794#discussion_r546274190
##########
File path: beeline/pom.xml
##########
@@ -99,6 +99,20 @@
<version>${project.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
+ <exclusions>
Review comment:
For test scope, I think the test-jar won't include shaded dependencies. Then un-shaded dependencies will be pull. So I think we need to exclude them.
If there are other places using hive-exec in test scope, I think they might also need to exclude these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org