You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2011/12/22 07:44:39 UTC

Review Request: BOOKKEEPER-133: Hub server should update subscription state to zookeeper when losing topic or shutting down

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3293/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

Currently hub server use counter-based mechanism to update subscription state lazily to zookeeper.
But in the following case, it didn't do it.
1) losing ownership of Topic
2) hub server shuts down


This addresses bug BOOKKEEPER-133.
    https://issues.apache.org/jira/browse/BOOKKEEPER-133


Diffs
-----

  hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java f4db619 
  hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 8c2d77f 
  hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java 78d1435 
  hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionState.java 8ee92e3 
  hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/SubscriptionManager.java d40a029 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 0c3c4df 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/TopicManager.java 6e4b2c9 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/TrivialOwnAllTopicManager.java 1f6654f 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java b1bd9a4 
  hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 8f77a1b 
  hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java 3782e82 
  hedwig-server/src/test/java/org/apache/hedwig/server/persistence/StubPersistenceManager.java 84b866d 
  hedwig-server/src/test/java/org/apache/hedwig/server/subscriptions/TestUpdateSubscriptionState.java PRE-CREATION 

Diff: https://reviews.apache.org/r/3293/diff


Testing
-------


Thanks,

Sijie