You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Denis Magda <dm...@gridgain.com> on 2015/11/13 12:30:19 UTC
Re: Ignite with Spring boot
Hi,
As I see you've already found out the reason of the issue [1] and,
moreover, have already fixed it [2] :) Perfect.
However, I'm afraid that the fix is inapplicable because you changed
methods' return type from IgniteMXBean public API.
This will break source code compatibility between current and released
Ignite versions.
Does anyone from the community have a thought on how to fix the issue
preserving the compatibility?
[1] https://issues.apache.org/jira/browse/IGNITE-1900
[2] https://github.com/apache/ignite/pull/227
On 11/13/2015 8:22 AM, 姜 为 wrote:
> Hi:
>
> I’m using Ignite 1.4 and Spring boot 1.2.7.
>
> When I create Ignite bean I got exception:
>
> How can I fix this?
Ignite with Spring boot
Posted by Denis Magda <dm...@gridgain.com>.
Perfect,
There's "submit patch" button in the control menu of the ticket. Please
also assign the ticket on yourself.
I'll review your changes in a couple of days.
thanks,
Denis
On Saturday, November 14, 2015, 姜 为 <ydswcy513@gmail.com
<javascript:_e(%7B%7D,'cvml','ydswcy513@gmail.com');>> wrote:
> Hi Denis,
>
> I have fix the issue and push to github
> https://github.com/apache/ignite/pull/227/files <
> https://github.com/apache/ignite/pull/227/files>.
>
> How to “move ticket to PATCH_AVAILABLE state”?
>
>
>
>
> > 在 2015年11月13日，下午8:26，Denis Magda <dm...@gridgain.com> 写道：
> >
> > I was wrong regarding the following, sorry
> > /
> > //However, I'm afraid that the fix is inapplicable because you changed
> methods' return type from IgniteMXBean public API.//
> > //This will break source code compatibility between current and released
> Ignite versions./
> >
> > It's OK to change the return type to the classes proposed by you.
> However when I applied your patch I got ClassCastException.
> > Left all review notes in the ticket. Please address them.
> > https://issues.apache.org/jira/browse/IGNITE-1900
> >
> > Nick, thanks for sharing this! However, I think it still makes sense to
> support the configuration when JMX is enabled. Moreover it seems to cost
> nothing for us.
> >
> > --
> > Regards,
> > Denis
> >
> > On 11/13/2015 3:13 PM, Nick Pavlov wrote:
> >> 姜 为
> >> , for fix this error disable spring jmx in application properties
> >>
> >> spring.jmx.enabled=false
> >>
> >> пт, 13 нояб. 2015 г. в 14:30, Denis Magda <dmagda@gridgain.com <mailto:
> dmagda@gridgain.com>>:
> >>
> >> Hi,
> >>
> >> As I see you've already found out the reason of the issue [1] and,
> >> moreover, have already fixed it [2] :) Perfect.
> >>
> >> However, I'm afraid that the fix is inapplicable because you
> >> changed methods' return type from IgniteMXBean public API.
> >> This will break source code compatibility between current and
> >> released Ignite versions.
> >>
> >> Does anyone from the community have a thought on how to fix the
> >> issue preserving the compatibility?
> >>
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-1900
> >> [2] https://github.com/apache/ignite/pull/227
> >>
> >>
> >> On 11/13/2015 8:22 AM, 姜 为 wrote:
> >>> Hi:
> >>>
> >>> I’m using Ignite 1.4 and Spring boot 1.2.7.
> >>>
> >>> When I create Ignite bean I got exception:
> >>>
> >>> How can I fix this?
> >>
> >
>
>
Re: Ignite with Spring boot
Posted by 姜 为 <yd...@gmail.com>.
Hi Denis,
I have fix the issue and push to github https://github.com/apache/ignite/pull/227/files <https://github.com/apache/ignite/pull/227/files>.
How to “move ticket to PATCH_AVAILABLE state”?
> 在 2015年11月13日，下午8:26，Denis Magda <dm...@gridgain.com> 写道：
>
> I was wrong regarding the following, sorry
> /
> //However, I'm afraid that the fix is inapplicable because you changed methods' return type from IgniteMXBean public API.//
> //This will break source code compatibility between current and released Ignite versions./
>
> It's OK to change the return type to the classes proposed by you. However when I applied your patch I got ClassCastException.
> Left all review notes in the ticket. Please address them.
> https://issues.apache.org/jira/browse/IGNITE-1900
>
> Nick, thanks for sharing this! However, I think it still makes sense to support the configuration when JMX is enabled. Moreover it seems to cost nothing for us.
>
> --
> Regards,
> Denis
>
> On 11/13/2015 3:13 PM, Nick Pavlov wrote:
>> 姜 为
>> , for fix this error disable spring jmx in application properties
>>
>> spring.jmx.enabled=false
>>
>> пт, 13 нояб. 2015 г. в 14:30, Denis Magda <dmagda@gridgain.com <ma...@gridgain.com>>:
>>
>> Hi,
>>
>> As I see you've already found out the reason of the issue [1] and,
>> moreover, have already fixed it [2] :) Perfect.
>>
>> However, I'm afraid that the fix is inapplicable because you
>> changed methods' return type from IgniteMXBean public API.
>> This will break source code compatibility between current and
>> released Ignite versions.
>>
>> Does anyone from the community have a thought on how to fix the
>> issue preserving the compatibility?
>>
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-1900
>> [2] https://github.com/apache/ignite/pull/227
>>
>>
>> On 11/13/2015 8:22 AM, 姜 为 wrote:
>>> Hi:
>>>
>>> I’m using Ignite 1.4 and Spring boot 1.2.7.
>>>
>>> When I create Ignite bean I got exception:
>>>
>>> How can I fix this?
>>
>
Re: Ignite with Spring boot
Posted by Denis Magda <dm...@gridgain.com>.
I was wrong regarding the following, sorry
/
//However, I'm afraid that the fix is inapplicable because you changed
methods' return type from IgniteMXBean public API.//
//This will break source code compatibility between current and released
Ignite versions./
It's OK to change the return type to the classes proposed by you.
However when I applied your patch I got ClassCastException.
Left all review notes in the ticket. Please address them.
https://issues.apache.org/jira/browse/IGNITE-1900
Nick, thanks for sharing this! However, I think it still makes sense to
support the configuration when JMX is enabled. Moreover it seems to cost
nothing for us.
--
Regards,
Denis
On 11/13/2015 3:13 PM, Nick Pavlov wrote:
> 姜 为
> , for fix this error disable spring jmx in application properties
>
> spring.jmx.enabled=false
>
> пт, 13 нояб. 2015 г. в 14:30, Denis Magda <dmagda@gridgain.com
> <ma...@gridgain.com>>:
>
> Hi,
>
> As I see you've already found out the reason of the issue [1] and,
> moreover, have already fixed it [2] :) Perfect.
>
> However, I'm afraid that the fix is inapplicable because you
> changed methods' return type from IgniteMXBean public API.
> This will break source code compatibility between current and
> released Ignite versions.
>
> Does anyone from the community have a thought on how to fix the
> issue preserving the compatibility?
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-1900
> [2] https://github.com/apache/ignite/pull/227
>
>
> On 11/13/2015 8:22 AM, 姜 为 wrote:
>> Hi:
>>
>> I’m using Ignite 1.4 and Spring boot 1.2.7.
>>
>> When I create Ignite bean I got exception:
>>
>> How can I fix this?
>
Re: Ignite with Spring boot
Posted by Nick Pavlov <gu...@gmail.com>.
姜 为
, for fix this error disable spring jmx in application properties
spring.jmx.enabled=false
пт, 13 нояб. 2015 г. в 14:30, Denis Magda <dm...@gridgain.com>:
> Hi,
>
> As I see you've already found out the reason of the issue [1] and,
> moreover, have already fixed it [2] :) Perfect.
>
> However, I'm afraid that the fix is inapplicable because you changed
> methods' return type from IgniteMXBean public API.
> This will break source code compatibility between current and released
> Ignite versions.
>
> Does anyone from the community have a thought on how to fix the issue
> preserving the compatibility?
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-1900
> [2] https://github.com/apache/ignite/pull/227
>
>
> On 11/13/2015 8:22 AM, 姜 为 wrote:
>
> Hi:
>
> I’m using Ignite 1.4 and Spring boot 1.2.7.
>
> When I create Ignite bean I got exception:
>
> How can I fix this?
>
>
>