[GitHub] [httpcomponents-core] garydgregory commented on issue #179: Httpcore 619 event mask as a class

[GitBox <gi...@apache.org>]

garydgregory commented on issue #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179#issuecomment-569804499
 
 
   > 
   > 
   > The commit log looks like a mess. Please review, but otherwise the change is fine.
   > 
   > One could consider making the default constructor private, e.g.,
   > 
   > ```
   >     private StandardCharsets() {
   >         throw new AssertionError("No java.nio.charset.StandardCharsets instances for you!");
   >     }
   > ```
   
   Please no, a final class and private default ctor yes, but just make the ctor body a comment like "// no instances."
   Throwing an error here is just silly IMO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org