You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/21 14:29:32 UTC

[GitHub] [superset] adam-stasiak commented on pull request #12657: fix(explore): Don't allow to add a duplicated saved metric to controls

adam-stasiak commented on pull request #12657:
URL: https://github.com/apache/superset/pull/12657#issuecomment-764679983


   tested manually - looks fine. 🟢 
   One question - Should all chosen metrics be removed when I delete from Edit Dataset menu one of them?
   The same behavior is outside this PR.
   Scenario:
   1) add metrics to Query section
   2) Go to edit dataset
   3) remove one of chosen metrics
   
   Observed: All chosen Metrics are not set anymore


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org