[GitHub] [hive] rajkrrsingh commented on pull request #1460: Hive 24113

[GitBox <gi...@apache.org>]

rajkrrsingh commented on pull request #1460:
URL: https://github.com/apache/hive/pull/1460#issuecomment-714908537


   > I had a second look at this change, and instead of creating a new SessionState to get the timezone I would do the following:
   > if (timeZone == null) {
   > timeZone = SessionState.get() == null ? new HiveConf().getLocalTimeZone() : SessionState.get().getConf()
   > .getLocalTimeZone();
   > formatter.setTimeZone(TimeZone.getTimeZone(timeZone));
   > }
   
   updated the pull request, please review. Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org