You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "li4wang (via GitHub)" <gi...@apache.org> on 2024/02/12 18:26:39 UTC

[PR] ZOOKEEPER-4808: Fix the log statement in FastLeaderElection [zookeeper]

li4wang opened a new pull request, #2136:
URL: https://github.com/apache/zookeeper/pull/2136

   Fixed the incorrect order of proposedZxid and proposedEpoch in the debug statement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4808: Fix the log statement in FastLeaderElection [zookeeper]

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2136:
URL: https://github.com/apache/zookeeper/pull/2136#issuecomment-2380878745

   @anmolnar  Sorry for taking your time!
   
   I think it is a follow up of #2111 and included in backport #2133. I have updated the affected version to `3.10.0` to reflect this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4808: Fix the log statement in FastLeaderElection [zookeeper]

Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2136:
URL: https://github.com/apache/zookeeper/pull/2136#issuecomment-2380835243

   It's not actually backported, but the log line looks correct on `branch-3.9`, when I try backporting it, the commit becomes empty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4808: Fix the log statement in FastLeaderElection [zookeeper]

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2136:
URL: https://github.com/apache/zookeeper/pull/2136#issuecomment-2380666471

   @anmolnar Should this be backported ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4808: Fix the log statement in FastLeaderElection [zookeeper]

Posted by "maoling (via GitHub)" <gi...@apache.org>.
maoling merged PR #2136:
URL: https://github.com/apache/zookeeper/pull/2136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4808: Fix the log statement in FastLeaderElection [zookeeper]

Posted by "maoling (via GitHub)" <gi...@apache.org>.
maoling commented on PR #2136:
URL: https://github.com/apache/zookeeper/pull/2136#issuecomment-2169249453

   @li4wang  Thanks for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4808: Fix the log statement in FastLeaderElection [zookeeper]

Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2136:
URL: https://github.com/apache/zookeeper/pull/2136#issuecomment-2380833270

   @kezhuw It's already on `branch-3.9` as far as I can see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org