You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/10/02 03:28:31 UTC

Review Request 38945: RANGER-675: fix the incorrect column authorization via tag

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38945/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-675
    https://issues.apache.org/jira/browse/RANGER-675


Repository: ranger


Description
-------

Due to a shared context issue, when one of the columns in the query is authorized via tags, other columns are also authorized.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 6388c78 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java 92a87d0 
  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java 9f99ea1 

Diff: https://reviews.apache.org/r/38945/diff/


Testing
-------


Thanks,

Madhan Neethiraj


Re: Review Request 38945: RANGER-675: fix the incorrect column authorization via tag

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38945/#review101298
-----------------------------------------------------------

Ship it!


Ship It!


hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java (line 105)
<https://reviews.apache.org/r/38945/#comment158674>

    Do we break an incoming access-request into multiple policy-engine requests in any other component? If so, setContext() call needs to change there too..


- Abhay Kulkarni


On Oct. 2, 2015, 1:28 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38945/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 1:28 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-675
>     https://issues.apache.org/jira/browse/RANGER-675
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Due to a shared context issue, when one of the columns in the query is authorized via tags, other columns are also authorized.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java 6388c78 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java 92a87d0 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java 9f99ea1 
> 
> Diff: https://reviews.apache.org/r/38945/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>