You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/09/02 06:28:22 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #3340] [Subtask][KPIP-5] Github CI check kyuubi web ui
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 29eb6914b [KYUUBI #3340] [Subtask][KPIP-5] Github CI check kyuubi web ui
29eb6914b is described below
commit 29eb6914b6b418f8020aa7b5d974c5a4c49ddd40
Author: zwangsheng <22...@qq.com>
AuthorDate: Fri Sep 2 14:28:10 2022 +0800
[KYUUBI #3340] [Subtask][KPIP-5] Github CI check kyuubi web ui
### _Why are the changes needed?_
For code review and check pr, we need Github CI help check web ui.
Run `npm run coverage && npm run build-check` to find syntax issues and build errors.
Actions used node from https://github.com/marketplace/actions/setup-node-js-environment
Close #3335
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #3340 from zwangsheng/feature/web_ci.
Closes #3340
037953b7 [zwangsheng] fix symble |
07f6dc09 [zwangsheng] use npm install pnpm
c643333e [zwangsheng] use pnpm instead
a57bc311 [zwangsheng] install
f2a94ca2 [zwangsheng] fix runner
1d85336d [zwangsheng] fix runner
7c5c58c2 [zwangsheng] fix runner
adb94e46 [zwangsheng] fix
33359d99 [zwangsheng] fix
95a34cbb [zwangsheng] fix
7d3207a9 [zwangsheng] add ci
Authored-by: zwangsheng <22...@qq.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.github/workflows/style.yml | 18 ++++++++++++++++++
.github/workflows/web-ui.yml | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml
index fbded473f..fa872ed7e 100644
--- a/.github/workflows/style.yml
+++ b/.github/workflows/style.yml
@@ -58,3 +58,21 @@ jobs:
done
- name: JavaStyle with maven
run: build/mvn spotless:check -Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds
+ - name: setup npm
+ uses: actions/setup-node@v3
+ with:
+ node-version: 16
+ - name: Web UI Style with node
+ run: |
+ cd ./kyuubi-server/web-ui
+ npm install pnpm -g
+ pnpm install
+ pnpm run lint
+ echo "---------------------------------------Notice------------------------------------"
+ echo "If this style check fail, you should follow these commands for a tentative fix"
+ echo "* cd ./kyuubi-server/web-ui"
+ echo "* npm run lint-fix"
+ echo "Following the above steps can solve many style problems. "
+ echo "If there is a problem that cannot be fixed by the command, "
+ echo "you need to manually fix it by following the information told by the command above"
+ echo "---------------------------------------------------------------------------------"
diff --git a/.github/workflows/web-ui.yml b/.github/workflows/web-ui.yml
new file mode 100644
index 000000000..08c97cfc9
--- /dev/null
+++ b/.github/workflows/web-ui.yml
@@ -0,0 +1,34 @@
+name: Web UI
+
+on:
+ push:
+ branches:
+ - master
+ - branch-*
+ pull_request:
+ branches:
+ - master
+ - branch-*
+
+concurrency:
+ group: web-ui-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ web-ui:
+ name: Kyuubi Web UI check
+ runs-on: ubuntu-22.04
+ steps:
+ - name: checkout
+ uses: actions/checkout@v3
+ - name: setup npm
+ uses: actions/setup-node@v3
+ with:
+ node-version: 16
+ - name: npm run coverage & build
+ run: |
+ cd ./kyuubi-server/web-ui
+ npm install pnpm -g
+ pnpm install
+ pnpm run coverage
+ pnpm run build