[GitHub] tgravescs commented on a change in pull request #23252: [SPARK-26239] File-based secret key loading for SASL.

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #23252: [SPARK-26239] File-based secret key loading for SASL.
URL: https://github.com/apache/spark/pull/23252#discussion_r240348512
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -419,6 +419,34 @@ package object config {
       .booleanConf
       .createWithDefault(false)
 
+  private[spark] val AUTH_SECRET_FILE =
+    ConfigBuilder("spark.authenticate.secret.file")
+      .doc("Path to a file that contains the authentication secret to use. The secret key is" +
+        " loaded from this path on both the driver and the executors if overrides are not set for" +
+        " either entity (see below).")
+      .stringConf
+      .createOptional
+
+  private[spark] val AUTH_SECRET_FILE_DRIVER =
+    ConfigBuilder("spark.authenticate.secret.driver.file")
+      .doc("Path to a file that contains the authentication secret to use. Loaded by the" +
+        " driver. In Kubernetes client mode it is often useful to set a different secret" +
+        " path for the driver vs. the executors, since the driver may not be running in" +
+        " a pod unlike the executors. If this is set, an accompanying secret file must" +
+        " be specified for the executors. The fallback configuration allows the same path to be" +
+        " used for both the driver and the executors when running in cluster mode.")
 
 Review comment:
   so the file location for driver and executor is different but it has to still have same secret in it correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org