You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "gortiz (via GitHub)" <gi...@apache.org> on 2023/03/28 12:36:41 UTC
[GitHub] [pinot] gortiz opened a new pull request, #10491: Add testng on verifier
gortiz opened a new pull request, #10491:
URL: https://github.com/apache/pinot/pull/10491
This PR include a couple of small changes that were included in #10184 but can be merged alone in order to merge it earlier and simplify the other PR.
First, this PR adds a runtime dependency to testng in `pinot-compability-verifier`. That dependency was used but not declared. I discovered this when one of the test failed, which throws a testng assertion error. The funny thing is that the assertion error class wasn't in the classpath, so the error I'd got was a class not found exception. Once I added this dependency, the error message I had was the actual error that I had to solve.
It also adds a a new method `TestUtils.waitForCondition` that accepts a `SupplierWithException`. If the supplier throws, then the error is caught and retried until. This will repeated until the supplier doesn't fail or there is a timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10491: Add testng on verifier
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10491:
URL: https://github.com/apache/pinot/pull/10491#issuecomment-1486905459
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10491?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10491](https://codecov.io/gh/apache/pinot/pull/10491?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2c7957a) into [master](https://codecov.io/gh/apache/pinot/commit/d40cba4d50ad656f7495d029787aa6ca413d54bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d40cba4) will **decrease** coverage by `9.85%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10491 +/- ##
============================================
- Coverage 70.14% 60.30% -9.85%
+ Complexity 6113 5071 -1042
============================================
Files 2088 2063 -25
Lines 112150 111371 -779
Branches 17063 16970 -93
============================================
- Hits 78673 67166 -11507
- Misses 27933 39240 +11307
+ Partials 5544 4965 -579
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `24.15% <ø> (-0.13%)` | :arrow_down: |
| unittests1 | `67.85% <ø> (-0.01%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 410 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10491/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #10491: Add testng on verifier
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #10491:
URL: https://github.com/apache/pinot/pull/10491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org