You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/07/19 13:01:00 UTC
Review Request 36598: LENS-673 : Lens website doc fix - committer's
page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36598/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
Minor fix for Lens website doc fix.
https://issues.apache.org/jira/browse/LENS-673
The lens committer's page (1) still shows the old way of applying patch. Bringing it in sync with the standard style as describe in contributor's page (2).
git apply --check lens_patch.patch
git apply lens_patch.patch
1. https://lens.incubator.apache.org/developer/commit.html#Commit
2. https://lens.incubator.apache.org/developer/contribute.html#Applying_a_patch
Diffs
-----
src/site/apt/developer/commit.apt 04abc62
Diff: https://reviews.apache.org/r/36598/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 36598: LENS-673 : Lens website doc fix -
committer's page
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36598/
-----------------------------------------------------------
(Updated July 20, 2015, 7:05 a.m.)
Review request for lens.
Changes
-------
Implemented review comment.
Repository: lens
Description
-------
Minor fix for Lens website doc fix.
https://issues.apache.org/jira/browse/LENS-673
The lens committer's page (1) still shows the old way of applying patch. Bringing it in sync with the standard style as describe in contributor's page (2).
git apply --check lens_patch.patch
git apply lens_patch.patch
1. https://lens.incubator.apache.org/developer/commit.html#Commit
2. https://lens.incubator.apache.org/developer/contribute.html#Applying_a_patch
Diffs (updated)
-----
src/site/apt/developer/commit.apt 04abc62
Diff: https://reviews.apache.org/r/36598/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 36598: LENS-673 : Lens website doc fix -
committer's page
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36598/#review92228
-----------------------------------------------------------
Ship it!
src/site/apt/developer/commit.apt (line 72)
<https://reviews.apache.org/r/36598/#comment146270>
can we correct the typo here? `should be`
- Rajat Khandelwal
On July 19, 2015, 4:31 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36598/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 4:31 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Minor fix for Lens website doc fix.
>
> https://issues.apache.org/jira/browse/LENS-673
>
> The lens committer's page (1) still shows the old way of applying patch. Bringing it in sync with the standard style as describe in contributor's page (2).
>
> git apply --check lens_patch.patch
> git apply lens_patch.patch
>
> 1. https://lens.incubator.apache.org/developer/commit.html#Commit
> 2. https://lens.incubator.apache.org/developer/contribute.html#Applying_a_patch
>
>
> Diffs
> -----
>
> src/site/apt/developer/commit.apt 04abc62
>
> Diff: https://reviews.apache.org/r/36598/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>