You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kevin Pilch-Bisson <ke...@pilch-bisson.net> on 2001/01/19 19:43:21 UTC
libsvn_fs/delta.c
Hi all,
I have been attempting to familiarize myself with the subversion code,
and style of doing things (which was fairly straightforward, since as
Garret recently said, you have all done a terrific job of keeping the
code clean, organized, and documented).
Anyway while doing so, I took a look at libsvn_fs/delta.c and found that
it didn't even come close to compiling, since it used an api that seems
to have either never been implemented, or has been removed. I took the
liberty of patching up all the holes to the point where it at least
compiles, but I have no way or testing it. If anyone wants it, a diff
is included.
One note that I should make is that in preparing it, I took the liberty
of making an assumption about svn_fs_get_node_proplist. Since the
comment in include/svn_fs.h was unclear, and the function is not
implemented (in libsvn_fs/tree.c), I assumed that the apr_hash_t it
returned would be keyed by null terminated C-strings, and the values
would be pointers to svn_string_ts as stated in the header.
Is this useful, or what is the direction that libsvn_fs is moving?
--
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
Re: libsvn_fs/delta.c
Posted by Karl Fogel <kf...@galois.collab.net>.
A plea to everyone:
Unless there's a reason to think your patch will be mangled by the
email transport layer, it's much more convenient to include it as
plain old text in the body of your message (as opposed to making it
some kind of encoded attachment). This way recipients can just page
down and read it right away, without any conversion step.
Reduce The Barrier. :-)
-K
Kevin Pilch-Bisson <ke...@pilch-bisson.net> writes:
> --H1spWtNR+x+ondvy
> Content-Type: multipart/mixed; boundary="y0ulUmNC+osPPQO6"
> Content-Disposition: inline
>
>
> --y0ulUmNC+osPPQO6
> Content-Type: text/plain; charset=iso-8859-1
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Fri, Jan 19, 2001 at 10:45:10PM +0100, Branko =C8ibej wrote:
> > Hi Kevin,
> >=20
> > I couldn't apply your patch. Could you please post another one, made=20
> > with "cvs diff -up"? I'll take some time to look at it.
>
>
> Here it is
> >=20
> > --=20
> > Brane =C8ibej
> > home: <br...@xbc.nu> http://www.xbc.nu/brane/
> > work: <br...@hermes.si> http://www.hermes-softlab.com/
> > ACM: <br...@acm.org> http://www.acm.org/
> >=20
> >=20
> > ____________________________________________________________
> > Get your free domain name and domain-based e-mail from =20
> > Namezero.com. New! Namezero Plus domains now available. =20
> > Find out more at: http://www.namezero.com =20
> >=20
>
> --=20
> >~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Kevin Pilch-Bisson
> kevin@pilch-bisson.net
> http://www.pilch-bisson.net
>
> --y0ulUmNC+osPPQO6
> Content-Type: application/octet-stream
> Content-Disposition: attachment; filename="patch.gz"
> Content-Transfer-Encoding: base64
>
> H4sICKTDaDoAA3BhdGNoAM08bXPjuM2f4+mPYPshsWM7sePESTbdu6Z76V363JPtZHN95ubm
> xpVteqOuI/kkOdl0m//+AOCLSImUZGc7U++LX0SCIAACIEDwOprzz2/YnC+z4GDWevv6V+v2
> 3Qe2CJf8DTucPaaH6Xr6yJM0jCPz4zKcpo/RZJEeyqF7j62EZ0nIH8PoI0vgDdux4cHRoDUP
> FwvWX7P+ivUT/EXj2+/31eedo8FgcDg8OjwasaOjN6OzN8fjHere7XbNRsND+Ds8x0bHp29O
> jlp/+hPrj056p6wL/48ZfE2zZD3L2CyOMv45Y19ajLFglUxWcbycZGwf3y9a7AX+tfotdrjP
> 7u45y55XnMULFrDFOppliH52H2QsmM34KkvZ7D6IPvKUZTELIhZP/8ln2V7KVkm84kn2jIOw
> ZZhmB4y9//Nfr97dsRAaA2DRlD3dxylXzUMAFCScTTnSS4CeHxCMm8v/vVJdo+CBcMLPaiBE
> QHSAkf5++eNPeWv+xB6D5ZoTTU4GveMB6x6f4xv8gPOb8wVDxvEkiRMiBQBFpCcC4mQRTYAo
> SJIPnBNQRQwa4iHly0dAfREnwJN0loQregaY7B+2gPBBFs7sEYh1k3mYpKxdYMz+rMce43AO
> jcJkMg2yOOq1+jvwEsKFvRBEGq+TGe+1usajKJ5z8xlTz2AMIGn+aLIKsnsn2CxIPvKsc+GE
> qx86J5Xw1TKY8eYzQsYy56xYDdKOngI3QQ/zcYEmVZB9XRVoVh6ZR1neYgLfkmcfeYDnPGtI
> HTWSjSwKvg96MJ9vQPjtiO4kuBvHrtF+Uw64qb8BLcTqQn1dtbzwubW+1MD0AEkazXiaAUj8
> wdNGMh6/qjVTxL8AxtnGBuOcFI24SOKHCWiYIJvdu6YmVjwTL980mSnDVRNh/sVQiaqgv9Ki
> Th4YqEj4Wuka+quykbngRSM0Z/dBel9Sj6Wn5ooWTx06HxFVX8ymgq7CgHlJAGtkE2a5Nb7F
> AKeCrmARotZivyO79bf1dAkohjB2skAdDeaSuAT4PKzWOIE4kvYK/1hzafUNDESvttsW9REh
> j1r2wigara4BxKGBxTMhYnwegiRGKTbBz3Eimwhy0uNcoxb8nYCUN37tkGswPDrqnbHu8GgI
> b+gwNZw0MuCr+wUk6e6VUxREp9B4+VNhOy2Z8jOnykYKmQOBu3oIMyFh5Btm6yRiH97/dPvu
> CoUwZneXt99f3U2+u74Falym6fqBC8cSfpn8+fLu/Q3RFVyKhKfAJ+HLocGdAZef2RPfA0cR
> yCIIhP4iDgNthBzAKPhNMHY07J0OgbOjQe98JHzhZqQnHKSnSc97DEDTKA8rcDqFOWLhQs9N
> 4JnFKxZmwP5FBa9bbHMvcEuHyctx4Oe2rpJfBlqwueg7nCQFAb0kcPV78IvhN8EvF9gNxIOl
> YY9lIXzFH0Ca3oGSwo2B5fGTbRH0hVYf/n4zubq9Ze0SH4GSOQ2ZmpvEtZMP8j3PaACEi0yX
> SKEk8QA0OPwkOsNOZy77l4c3yKwAtHeLExffafC6rjaFSninIXvLBkgtfCd4T/dgmgGaNeYv
> afgr+/e/mQ3ulyz8FWTAbTsNPhXZZPcIcb9N/UJsG8rntDhxU5bAE3TX8CG+y+cl+UjJfcZW
> 9AGaiYYNBIDabS8C+UDbC4GNwgZi0GOz/jdkhjoXTaC4JcKGIimMQqHZtAA9kxXEQo2YOVra
> 46iWSrpCtrsL3TqkIsWCd/AK2Z0qDTpbJ8hqQ4sb1J3G2T1qKhd1r6n/M2p8/ts6WPbwa4Q2
> 4BFMbryGtkGEnUlu0KV5wDhFTED1cDAQRiGga/IUpkB2mMrsnj/yRPRDANAV0PkHD5JlyJM9
> aUUAqQSkIZlD03nM02gvY/wzSoh8HiNQ7K+nhsyVCH6MM4yN4AYNjEfAxD7wANfvDmvfxBl/
> A8ZiD8j0KXhGWwK0RSsTslWMyjAQEvkvnsRkIrEbuHEPYRRkXNibIEmC5/SCpdINQQqQ0QTX
> g4gq5GgmOCOXXHrQUdoLXzgUsmsye1iBMLi7uNSKdCuEV+DQL1JTSen4LsYgTyRZNX0GfMFo
> UkhHk5TYJuieCwMYcwlFD/Othf+CtXP8QRl2AK8vZPyKQgnmikXrhylPlP3YEf1/r6Ydzif8
> N9dk+9+E855jlvh7pyNN7Rf5zlQUjaYnfYOUNOF0neW4wKLLo13oQ98hTeBvwGRMJUfT0g86
> 4mIpOBnWUUa8FPDRG+rS7Mis0CAvQjzFBAATwS7kVPwEEhwsM/YUApd83DKtI7rsYbeLRqrb
> xQFeLIm4trWDhKIH/MOUgxTzP1iNBHy95KVCIAfS6v8ElBXrbX5gCgtfptyWmD+aAmNaEorZ
> uAyILRYUj5DkS53zvKRQpMALOT7lnLSCA7UyIhTeKXPZxWRlEKiBS1JNVHOWdNXaep0Kl47h
> 1lpc9N9QkWOUl8/FplaoRs7yCT3dc2ybx45BqtZR+Nuaqz2DRBe1rl4bCPU+eOQ5HB4SGIcu
> J/ufNzRV6YX5IHeyYE210V1qCy9JuPr7nV3pKN389OOP8DD/WUUWPaAyB6jMDSorgTK1fpbA
> h7bEIlPBPEs4XqPBNZyCDs9JV9bi+tkXq3u9VrdaO9U7TUGqdP2507F7FoaVQ2+q1ksw2L5P
> zZea1uh75lT15QEdLy3uQihMqcDXi8l6PfHXmQMLnpbiCDa9sCCKCNjPM+u5obJIZ1bIiTQx
> xC/BtEihp/y5eAa6jfw5SRJSTmGGXCzQcl+obmlX3JKmEQdY7aLHLpfX5d9uJz9cfvhh8j9X
> P08+3N1e33zfQPbsTbmYzlvz11nCwTFUa1jtCi4qxMpt5ZSZKPWrY5pLauqMn9XeZucr6ZA1
> p0PZyDqXlhaRhhTKXBTKP8o3chUSTpGywYXekN7AAgOvZskD3JBGOvEpIuu4FDESdcA+xNo+
> LZfCE4KHS76gdznePpI8pCAkRbJcTUkYKISp2CK3fLjZ6xaYUc7J/OdM1IbclVxFpr6Kpz5e
> vhT2w68izqtcgS1UgCKOWPl1C9+34CUJcqFFaYY/GHQ9Gox6wxHrHh0d94Z0AKFptLM2Wlod
> G3dGxf3xcG9c1Je+dD1yBj7LCS2BuHD036rdJfvWgqZ62dmGmB6qLp0OewOe0YVnMGlurMGa
> D2FExZxRQUH8tySXpTbm0GYbtIkSdyVWSgQlDtjNwk6HywiYO1imQGuuNQVt4umMoLFWLtil
> dOYs1x0mAPlNJu8BmEhF9L+RWUQlusZig5FosRwPxGIZH+N7flpHBkcFa6mHOLjz1RJO0qOc
> JHwZoDPzlRJO5dxsxZGKvEGuLSVFSYF5R9GZdfheMZbdzDei2Uq60LVNqw4hKMrWZYE9RPUn
> Uu2nToLu+E6OKOU8Bnk7AXk7U8q56QxI+HwaesMDQFtlsnxE2S6H5SVizRGfhikundCagrz0
> 6H9oDMQDAfLpVzPJUk6xEAyhUiVYAyApreokhshTvjpt1f0KqQ6F7V9CERxgs2WcwoQY6aLw
> kaIzMk98dXN3+7OBv3CapTCfnvVGeNARPI7jcxTmpnIoodCO9ikEX1hFkcIH0NOPXIWBZkHE
> FgpLpDlTGgCcpVhCeQiyDLzvJ3DBuYjn34ewv4FdzhOG9SNzT5wlXO71mc6dID9V6szB93D+
> mU5m4mNC4S3rDy/Ed9T3bZEALMYmw18vWNjtStMoO2qzrLrOP9cnigiDgisIP3VkBgjnwXZM
> diq5hFGzJ84FAcQqkhtBERUC4ouxcNnJ0N+B5IqwwClMFe28Ch9iUgL91uUzW0fSch2I3j8g
> 9cXhgHWKufnr73JEAopbBStg7ufwgc68SFsJBl70T8N/6WB7SIFO2Ve7UOFcrzhm7uxFHCnP
> hZQYQbElSXYTdHU6tCgRtF0AuquNgXd7AHu+nY2x72rs83AY+llsB90s3fP3KHwyU7C7y9pC
> rvBHzDHrZn+0FVRHHTcwuyD+NZ2QMSqlIiUYF4r1nVaH/mViTNxQjzt6uy0/vOQupIlPB2WZ
> VPfCnJuUdJDx/yOdsJcJrRBEz8AVOuEtnCiKKoP04hk5dpgHy5XaQvcN+oXQH0wrk6bVyAIU
> A34FJ8LerumAlcVNHeQ3wyllp8C9qS5BKm0it8LQ2Fi+iBTMF4OkZhpAK9gLNo/z+KhlGjBw
> YQSPSuuHBMFcQ/bs6bHjWIK90oThdi+1fABFFQ3TSda8vYeo2ZYcYU6OaJe+nDYSQugXnB7L
> z0LnzYQzrg9Bu8PO/cJjrQBx9kbyKYeviaZEw9p8iagClTMMz2mTNDoZ94ZHG9t5HGEu6wgi
> 6VdUns56lQPPHNuVioPM4tCj0aXB4eeWWD2FDhF/yl2r9ytpdjH4ii28jl8MLWUAYBcal9ds
> 7u3OljyI1ivZWkphD4dwO4aVoPvfzIMs6DncwusUFWQglKhItik9+q1ynSisYMw/FOeZWRuR
> Eac6R6MRnuocjc97p4bMNDicK17FQ9QSQWvFGVt9DV6gQWvJ0IQD+rubg5OktcA5TnqDlDnO
> cVusj82p59G75lCJg0qbuGdHHrocx55DblN1ar3AGKCCxZfjEW1BR+C9W6u5AWeaMCDPUJe4
> oPfI8JIMSdfTPCbjYEn5ODfGgIxOoDGt+gDFk3zWDpY0gNqUJ8Z0i3OxWSO+BlM80dTuyC2F
> RDpZR9Wru19SzGILNhof0yI7H4uj0xstMplARfOBZv3y5t3Vh7v3t3g2WPhH6kSteRC3keau
> CGo1iRK7dW8xMlUVk6oPMXmDyZXDOnptOC6TEHxBLcO4OJogDBG5HJ3CMsaCusGJzfo62jtM
> V4CemMN4qWGNVDIZM8fhX4fJAag2beyJNjFtgfugrjlKVvLDG0PP6s1m9RykDS0cI90cWwcc
> xYt3VCWiQs4YKTFqMBUyOqJhyYntz87XK9Yuy6PhzJJUnR1j6erx8Ng22vVCpe0igoX2qziF
> oZ+XvFMOjyk09tK8NlccINGCpTHVDexUiv65HciEib+DTkPAI2rOKl2YrKPP1hJJQLeeA0mO
> xluQZGen4HJoE4qp+dVq+SyULHY01GvJCpp1dQ6XpOS/Kp8k6NQ0yNz20T8eC3DhFGbyDk2h
> UQSyJ7fg1EVL5+bODdIfZZEU3fHRVgygYUt+hoW9scZEwdGCik1wTqJfWsUWkVgtOhCK7C63
> xOCKtWIrO1Vxyo0CM7WXTLY34JyAIZ2aTThY4QoRI49OaCGdDERd/CYGy+tAWVNw2SsSYs2+
> en8rsCxHRcOskKzM98vHJ1jI1j0+HQnL3LT+uOXN7zSvMWbGSt8gvePoVrlpNttvkvhx9avf
> aQOTDw4OLqQQSnqjHN68R1F8fysFbDwmup+dCbo3phqJ9VctJCQ11qSSsLpWWFKqsi7a1dBb
> U+zzXc0KaT+PKmuPUx7NJzhDXbRZn9A2p23nfLPPgpAAhAcPOWHFd6VRTk+J4efnsnC0IVrE
> cOPqC7nZQTUCfoPeB/3l+scrEe+UT2RODH9vUF64WRl8I37X8VrG5mvZXMdiYxNSzYgLuQ89
> GZDfeKKcpKYU8FGwcc29bwXV0qlkZl9LgaMzCqucgHkbEg0azqFOhGoOXfmmX6s6GhCoVlvU
> ktB9Tip3SqxjWRZ8XXNUc0pLYK/OUFkgsCxIAvmqp7bsIc0pl89u2VPd5vSWPaXmJ63skQ1P
> UHKPNXv5T31tipDr6JdAZpPzX8VpNTsBpheSuZeRVuTkjNy1sQqkNDJkTF2r1MAQ1N7H4T+4
> 6H1sHEry3b7hu3ej0Y0b9l0bLbkXPjk/6Y3Bhx8Pz3unJ7mir56hEJBAXRsQYBlZiJFhOqyx
> CFI8vgF29ilYfgIzi/VAVBuKZb+IP/B4uuQqh/tzvKbyICo6EslI9rCGpk9x8glTwnjq459r
> WK/Q4COPOOjevKBKAjFL2JVayH1P5bRSBZZRLU/fSY04jg/RVVdGzbb47q2sV7EQUeWFGxbR
> QcV2VGVU4WIvUYJ1vZCaLb/9AKtUe3i+hapW8eB6+IlTtRBdmGDVbuvtkHk6lAB+Ke1xi7In
> 8NXnjCSJHKeM6gAJ8iFnc2iKhj5wLzqrbmNrrD5jB7FeLmk4QnKCg/7yK2jXL2wgL1uTnY2Z
> wGNHNz0ZzI5lunJFHzwCaj8Bx7iqgZTzAAHEo2ezYJ1yanAfr5dzdOMiKn5ecHQK9CEG8kLD
> zAo12PDURQO6aqGBHMltsFuO3EHcEq9N8Xce2q0CYvHZWhtuUPpyBe/NCoRH4V4F8RvdqlAQ
> DXs3SmHBApgLd9sM2xbB67a4pp0F21p0UBniGYyo4zlS6L8lwNfDf1uA6CHufDAn2LMSGNTI
> uT8njhSUF7UuXTvQNUotsEzm/d3VG3mTzCq/phBF7xN/TlWhJ+lxOuo3Fcp4+pxxgYV2RfaZ
> vNARZRfJKCaAMh1hKX8Bc127JFlhlEvW1nhYFKLjJW6HqF3oQHTJw3C1hTZm8qjROCb983HU
> u10ras7BzH3YET5Zgpc9xUpHFOqAg9w4TEU4+mP4CL8b5hJfVGKa4jaYCg2NuJpsgMbEeQWA
> UlG2YlKDGrXqtmA+mrKOOqxdtBKRSpzgpyWPVBW4vYzLcIpaSMPJcjgKeSq6tW4/Ec6HrDwV
> k7Kp8q3jagN1qkjWzYKWhNEe9cUFeVBVeWGsLVQ2IiWaKqRKJf1FVkvXgTJF4l4Nea2Grq3c
> S61KSneFvr8434EkarqBowy/JIYyi1iPW02BflGumorVluJQM32DR1ZtvzTWcvlaxZSvkS0D
> TIWIWZrdUixWsWupxNNhBr0H42pqPGtpZmFldccjDsbX6tpXf92nJr5Z21pkhFmmrCuRyxXK
> +v4iT4XyfmFVOThllSfb9yFNGhYn1/ArdfPLshZb8Usv8UKfas68FEntWuBGk2IJ8n+pdJYn
> Xiw2frEkkP6rqCqWOtsISsv77qQsGg/ofHMUpvd8TkOgv1cuKEYVoGuOmThrD1KZKqm0a4s1
> lYvUbe7q7JZ9HbOy2OnXbMU9FWnSTGvCMzevXiwPt4oSqY8SzgLikndp1gk4PUnPqt2WEsW1
> 6l6jL55TZePxGUbzx+dnZjS/JsjjiYA1vI7VXeLovzzRF3reMGU4Phtg7O90OJCp2kboFq9p
> tSLpxpWl5czBvvjoSVFI0TBC9BUx+p47iWHBqEtzqBRK8Tr6wik0ibwyVxLCRev/AXh5lmLw
> XwAA
>
> --y0ulUmNC+osPPQO6--
>
> --H1spWtNR+x+ondvy
> Content-Type: application/pgp-signature
> Content-Disposition: inline
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.4 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
>
> iD8DBQE6aMPigJlk/lQdbnARAmIOAJ9ihldR40Ns9UGGzXHh4z2ZfAUsZwCePbYw
> PuzDI7d9YacXPEgJ3vOY8oo=
> =zefo
> -----END PGP SIGNATURE-----
>
> --H1spWtNR+x+ondvy--
Re: libsvn_fs/delta.c
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
On Fri, Jan 19, 2001 at 10:45:10PM +0100, Branko Èibej wrote:
> Hi Kevin,
>
> I couldn't apply your patch. Could you please post another one, made
> with "cvs diff -up"? I'll take some time to look at it.
Here it is
>
> --
> Brane Èibej
> home: <br...@xbc.nu> http://www.xbc.nu/brane/
> work: <br...@hermes.si> http://www.hermes-softlab.com/
> ACM: <br...@acm.org> http://www.acm.org/
>
>
> ____________________________________________________________
> Get your free domain name and domain-based e-mail from
> Namezero.com. New! Namezero Plus domains now available.
> Find out more at: http://www.namezero.com
>
--
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
Re: libsvn_fs/delta.c
Posted by Branko Čibej <br...@xbc.nu>.
Hi Kevin,
I couldn't apply your patch. Could you please post another one, made
with "cvs diff -up"? I'll take some time to look at it.
--
Brane �ibej
home: <br...@xbc.nu> http://www.xbc.nu/brane/
work: <br...@hermes.si> http://www.hermes-softlab.com/
ACM: <br...@acm.org> http://www.acm.org/
Re: libsvn_fs/delta.c
Posted by Ben Collins-Sussman <su...@newton.collab.net>.
Kevin Pilch-Bisson <ke...@pilch-bisson.net> writes:
> Sounds good, I'll take a look some more at the structure doc. Also, I
> noticed that I made one incorrect assumption in two places, (having to
> do with strcmp and NULL), but I have fixed it. I won't bother sending
> it since you aren't really interested...
Sorry, I didn't mean to sound too harsh... we'll take a look at your
patch when we get a minute. Several of us are in San Francisco now,
so we don't have the time just yet to look at it. Keep reading and
start looking at the low-level files (skel.c, fs.c, *-table.c). :)
Re: libsvn_fs/delta.c
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
On Fri, Jan 19, 2001 at 02:08:27PM -0600, Ben Collins-Sussman wrote:
> Kevin Pilch-Bisson <ke...@pilch-bisson.net> writes:
>
> > Anyway while doing so, I took a look at libsvn_fs/delta.c and found that
> > it didn't even come close to compiling, since it used an api that seems
> > to have either never been implemented, or has been removed. I took the
> > liberty of patching up all the holes to the point where it at least
> > compiles, but I have no way or testing it. If anyone wants it, a diff
> > is included.
>
> The filesystem -- right now -- really doesn't exist yet. The library
> should always compile (as a CVS checkin rule-of-conduct), but most of
> the time this means "just comment out the non-compiling files out of
> Makefile.am".
I noticed that, I just thought it would give me something interested to
do.
>
> Starting next week, we're going to be attacking the filesystem
> full-force, but starting from the bottom up. If you look at
> libsvn_fs/structure, you'll notice that delta.c depends on *all* the
> underlying filesystem APIs below. We're still working at the bottom
> right now. The higher-level .c files have code, but a lot of may be
> old (from previous fs drafts.) If you'd like to help code at the
> bottom, talk to us some more. But for now, your attempt to make
> libsvn_fs compile isn't going to get you anywhere. You've got to
> crawl before you can walk. :)
>
Sounds good, I'll take a look some more at the structure doc. Also, I
noticed that I made one incorrect assumption in two places, (having to
do with strcmp and NULL), but I have fixed it. I won't bother sending
it since you aren't really interested, but at least I got my feet a
little bit wet with some of the subversion code. I've never used apr
before either, so I am learning a bit about the library by using it.
TTYL,
--
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
Re: libsvn_fs/delta.c
Posted by Ben Collins-Sussman <su...@newton.collab.net>.
Kevin Pilch-Bisson <ke...@pilch-bisson.net> writes:
> Anyway while doing so, I took a look at libsvn_fs/delta.c and found that
> it didn't even come close to compiling, since it used an api that seems
> to have either never been implemented, or has been removed. I took the
> liberty of patching up all the holes to the point where it at least
> compiles, but I have no way or testing it. If anyone wants it, a diff
> is included.
The filesystem -- right now -- really doesn't exist yet. The library
should always compile (as a CVS checkin rule-of-conduct), but most of
the time this means "just comment out the non-compiling files out of
Makefile.am".
Starting next week, we're going to be attacking the filesystem
full-force, but starting from the bottom up. If you look at
libsvn_fs/structure, you'll notice that delta.c depends on *all* the
underlying filesystem APIs below. We're still working at the bottom
right now. The higher-level .c files have code, but a lot of may be
old (from previous fs drafts.) If you'd like to help code at the
bottom, talk to us some more. But for now, your attempt to make
libsvn_fs compile isn't going to get you anywhere. You've got to
crawl before you can walk. :)