[jira] [Commented] (CALCITE-3250) Support nested collection type for SqlDataTypeSpec

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908491#comment-16908491 ] 

Julian Hyde commented on CALCITE-3250:
--------------------------------------

SqlTypeNameSpec now has two deriveType methods that do practically the same thing. Next time you touch this code, can you rationalize them? Or, if possible, remove them before they hit a release.

It might be better for that logic to be in the validator rather than in sub-classes of SqlNode. SqlNode is just an AST, it doesn't know much about semantics.

> Support nested collection type for  SqlDataTypeSpec
> ---------------------------------------------------
>
>                 Key: CALCITE-3250
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3250
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>    Affects Versions: 1.20.0
>            Reporter: Danny Chan
>            Assignee: Danny Chan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> According to SQL-2011, collection type can be nested:
> {code:sql}
> <array type> ::=
>   <data type> ARRAY [ <left bracket or trigraph> <maximum cardinality> <right bracket or trigraph> ]
> <maximum cardinality> ::=
>   <unsigned integer>
> {code}
> *Example*:
> {code:sql}
> int array array;
> int multiset array;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)