You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Marin Nozhchev (Jira)" <ji...@apache.org> on 2026/05/26 13:33:00 UTC
[jira] [Updated] (THRIFT-6042) go: connection check should work for Windows
[ https://issues.apache.org/jira/browse/THRIFT-6042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marin Nozhchev updated THRIFT-6042:
-----------------------------------
Description:
As a follow-up to THRIFT-5996, I can extend the connection check initially implemented for THRIFT-5214, to work on Windows. The Windows case is a bit more complex, but the solution is still one screen of code. The complexity is worth it, IMO, because the connection check is really valuable for use cases with long-lived, sometimes idle, connections like the Go database/sql drivers. I maintain a driver like that - [https://github.com/sclgo/impala-go] - so I'm interested in solving this.
I'm happy to prepare a PR if you give me the go ahead. The code I intend to use is at [https://github.com/murfffi/conncheck/blob/main/peek_windows.go] with tests at [https://github.com/murfffi/conncheck/blob/main/conncheck_test.go] . I am the author of the library and I propose to copy the relevant Windows code into Thrift.
was:
As a follow-up to THRIFT-5996, I can extend the connection check initially implemented for THRIFT-5214, to work on Windows. The Windows case is a bit more complex, but the solution is still one screen of code. The complexity is worth it, IMO, because the connection check is really valuable for use cases with long-lived, sometimes idle, connections like the Go database/sql drivers. I maintain a driver like that - [https://github.com/sclgo/impala-go] - so I'm interested in solving this.
I'm happy to prepare a PR if you give me the go ahead. The code I intend to use is at [https://github.com/murfffi/conncheck/blob/main/peek_windows.go] with tests at [https://github.com/murfffi/conncheck/blob/main/conncheck_test.go] .
> go: connection check should work for Windows
> --------------------------------------------
>
> Key: THRIFT-6042
> URL: https://issues.apache.org/jira/browse/THRIFT-6042
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
> Affects Versions: 0.23.0
> Reporter: Marin Nozhchev
> Priority: Major
>
> As a follow-up to THRIFT-5996, I can extend the connection check initially implemented for THRIFT-5214, to work on Windows. The Windows case is a bit more complex, but the solution is still one screen of code. The complexity is worth it, IMO, because the connection check is really valuable for use cases with long-lived, sometimes idle, connections like the Go database/sql drivers. I maintain a driver like that - [https://github.com/sclgo/impala-go] - so I'm interested in solving this.
> I'm happy to prepare a PR if you give me the go ahead. The code I intend to use is at [https://github.com/murfffi/conncheck/blob/main/peek_windows.go] with tests at [https://github.com/murfffi/conncheck/blob/main/conncheck_test.go] . I am the author of the library and I propose to copy the relevant Windows code into Thrift.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)