You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2011/08/31 14:14:10 UTC
[jira] [Created] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
-----------------------------------------------------------------------------------------------------
Key: QPID-3459
URL: https://issues.apache.org/jira/browse/QPID-3459
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.12, 0.11, 0.10, 0.9, 0.8, 0.7, 0.6
Reporter: Alex Rudyy
Assignee: Robbie Gemmell
Priority: Minor
The stack trace from failed test is provided below:
Message 3 was not received
junit.framework.AssertionFailedError: Message 3 was not received
at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3459:
---------------------------------
Assignee: Alex Rudyy (was: Robbie Gemmell)
Status: Open (was: Ready To Review)
I dont think the changes in the patch will resolve the underlying test failure.
>From the test we know that the 5th message has been recieved, and yet the statistcs counter still reports 4, meaning it has not yet been incremented. Synchronizing just those methods should have no effect in that scenario, as the value is retrieved via JMX and so involvs another roundtrip to the broker after the message has been received at the client. Given this, and that the occurences of this failure have only been seen on an old dual core machine, I think its likely that thread scheduling is occurring such that the delivering thread has yielded before incrementing the counter, meaning this synchronization wont help.
Adding additional synchronization on the statistics object around the message delivery and increment would also be required I believe, which isnt going to be nice for performance (and furthermore, the statistics are optional and off by default).An alternative might be to increment the counter immediatley prior to the delivery attempt, although this wasn't done previously since any exceptions thrown during delivery would make the value invalid, and reverting the increment if an exception occurs is not as simple as it sounds since it means manipulating the statistics which may have already moved on to a new reporting interval. Ick to all of the above.
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-3459:
--------------------------------
Assignee: Robbie Gemmell (was: Alex Rudyy)
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3459:
-----------------------------
Attachment: QPID-3459-Increment-delivery-counter-before-transfering-message.patch
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: QPID-3459-Increment-delivery-counter-before-transfering-message.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094463#comment-13094463 ]
Alex Rudyy commented on QPID-3459:
----------------------------------
Also, sometimes this test fails with the following stack trace
Incorrect vhost delivery total expected:<5> but was:<4>
junit.framework.AssertionFailedError: Incorrect vhost delivery total expected:<5> but was:<4>
at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:91)
at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:238)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:132)
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-3459:
--------------------------------
Assignee: Robbie Gemmell (was: Alex Rudyy)
Robbie, could you please review an updated version of patch?
The patch changes the order of operations:
the counter is incremented before sending the message over the wire.
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: QPID-3459-Increment-delivery-counter-before-transfering-message.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3459.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.13
Patch applied.
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.13
>
> Attachments: QPID-3459-Increment-delivery-counter-before-transfering-message.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3459:
-----------------------------
Attachment: (was: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch)
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: QPID-3459-Increment-delivery-counter-before-transfering-message.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3459:
-----------------------------
Status: Ready To Review (was: In Progress)
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: QPID-3459-Increment-delivery-counter-before-transfering-message.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3459:
-----------------------------
Attachment: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-3459:
--------------------------------
Assignee: Alex Rudyy (was: Robbie Gemmell)
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Andrew Kennedy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099673#comment-13099673 ]
Andrew Kennedy commented on QPID-3459:
--------------------------------------
Agree with Robbie here.
FYI, when implementing, I deliberated between full-on synchronisation and using atomic counters, eventually settling for the synchronisation as seen. In testing there was no performance difference between the two mechanisms at any statistically significant level. Adding more synchronisation would cause serialisation of message processing, since the statistics generation happens on the delivery path, which is inadvisable.
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3459) Test
org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically
fails on 0.10 profiles
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3459:
-----------------------------
Status: Ready To Review (was: In Progress)
> Test org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest sporadically fails on 0.10 profiles
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-3459
> URL: https://issues.apache.org/jira/browse/QPID-3459
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Attachments: QPID-3459-Adds-synchronization-to-StatisticsCounter.patch
>
>
> The stack trace from failed test is provided below:
> Message 3 was not received
> junit.framework.AssertionFailedError: Message 3 was not received
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.receiveUsing(MessageStatisticsDeliveryTest.java:107)
> at org.apache.qpid.management.jmx.MessageStatisticsDeliveryTest.testDeliveryAndReceiptStatistics(MessageStatisticsDeliveryTest.java:72)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org