You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/27 12:42:08 UTC
[GitHub] [geode] albertogpz opened a new pull request #7051: GEODE-9774: Clear networkHop variable at function execution exit
albertogpz opened a new pull request #7051:
URL: https://github.com/apache/geode/pull/7051
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7051: GEODE-9774: Clear networkHop variable at function execution exit
Posted by GitBox <gi...@apache.org>.
albertogpz merged pull request #7051:
URL: https://github.com/apache/geode/pull/7051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7051: GEODE-9774: Clear networkHop variable at function execution exit
Posted by GitBox <gi...@apache.org>.
albertogpz merged pull request #7051:
URL: https://github.com/apache/geode/pull/7051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on a change in pull request #7051: GEODE-9774: Clear networkHop variable at function execution exit
Posted by GitBox <gi...@apache.org>.
kirklund commented on a change in pull request #7051:
URL: https://github.com/apache/geode/pull/7051#discussion_r737907499
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/execute/PartitionedRegionFunctionExecutor.java
##########
@@ -215,21 +215,27 @@ public PartitionedRegionFunctionExecutor(PartitionedRegion region, Set filter2,
@Override
public ResultCollector executeFunction(final Function function, long timeout, TimeUnit unit) {
- if (!function.hasResult()) /* NO RESULT:fire-n-forget */ {
- this.pr.executeFunction(function, this, null, this.executeOnBucketSet);
- return NO_RESULT;
- }
- ResultCollector inRc = (rc == null) ? new DefaultResultCollector() : rc;
- ResultCollector rcToReturn =
- this.pr.executeFunction(function, this, inRc, this.executeOnBucketSet);
- if (timeout > 0) {
- try {
- rcToReturn.getResult(timeout, unit);
- } catch (Exception exception) {
- throw new FunctionException(exception);
+ try {
+ if (!function.hasResult()) /* NO RESULT:fire-n-forget */ {
+ this.pr.executeFunction(function, this, null, this.executeOnBucketSet);
+ return NO_RESULT;
+ }
+ ResultCollector inRc = (rc == null) ? new DefaultResultCollector() : rc;
+ ResultCollector rcToReturn =
+ this.pr.executeFunction(function, this, inRc, this.executeOnBucketSet);
+ if (timeout > 0) {
+ try {
+ rcToReturn.getResult(timeout, unit);
+ } catch (Exception exception) {
+ throw new FunctionException(exception);
+ }
+ }
+ return rcToReturn;
+ } finally {
+ if (pr.getNetworkHopType() != PartitionedRegion.NETWORK_HOP_NONE) {
+ pr.clearNetworkHopData();
Review comment:
You should probably add some unit test(s) for this. I'd start a new `PartitionedRegionFunctionExecutorTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7051: GEODE-9774: Clear networkHop variable at function execution exit
Posted by GitBox <gi...@apache.org>.
albertogpz merged pull request #7051:
URL: https://github.com/apache/geode/pull/7051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org