You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/19 14:35:54 UTC
[GitHub] [activemq] jgallimore opened a new pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
jgallimore opened a new pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
URL: https://github.com/apache/activemq/pull/465
…ccount for the connector path
The previous commit to ManagementContext to prevent rebinds on the RMI registry used a hardcoded lookup path, as opposed to considering the connectorPath attribute. This commit should fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] jgallimore commented on a change in pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
Posted by GitBox <gi...@apache.org>.
jgallimore commented on a change in pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
URL: https://github.com/apache/activemq/pull/465#discussion_r381355389
##########
File path: activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ManagementContext.java
##########
@@ -690,10 +690,17 @@ public JmxRegistry(int port) throws RemoteException {
super(port);
}
- @Override
+ private String getLookupName() {
+ if (getConnectorPath() == null || getConnectorPath().length() == 0) {
+ return LOOKUP_NAME;
+ }
+ return getConnectorPath().replaceAll("^/+", "").replaceAll("/+$", "");
Review comment:
Done! Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] coheigea commented on a change in pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
URL: https://github.com/apache/activemq/pull/465#discussion_r381335763
##########
File path: activemq-broker/src/main/java/org/apache/activemq/broker/jmx/ManagementContext.java
##########
@@ -690,10 +690,17 @@ public JmxRegistry(int port) throws RemoteException {
super(port);
}
- @Override
+ private String getLookupName() {
+ if (getConnectorPath() == null || getConnectorPath().length() == 0) {
+ return LOOKUP_NAME;
+ }
+ return getConnectorPath().replaceAll("^/+", "").replaceAll("/+$", "");
Review comment:
As getConnectorPath doesn't change, I guess it would make sense to only perform these regex's once (on setConnectorPath?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] jgallimore closed pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
Posted by GitBox <gi...@apache.org>.
jgallimore closed pull request #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
URL: https://github.com/apache/activemq/pull/465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] jbonofre commented on issue #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
Posted by GitBox <gi...@apache.org>.
jbonofre commented on issue #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
URL: https://github.com/apache/activemq/pull/465#issuecomment-590172095
@jgallimore do you mind to squash the two commits in a single one ? Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq] jgallimore commented on issue #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
Posted by GitBox <gi...@apache.org>.
jgallimore commented on issue #465: Fix issue where the registry lookup was a hardcoded name and didn't a…
URL: https://github.com/apache/activemq/pull/465#issuecomment-590271511
Sure, see #471 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services