You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Radhika Jandhyala via Review Board <no...@reviews.apache.org> on 2018/08/27 21:18:16 UTC
Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree,
ProcessExists`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/#review207996
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika Jandhyala
On Aug. 27, 2018, 9:15 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68532/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2018, 9:15 p.m.)
>
>
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
>
>
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests were (partially) ported by implementing logic similar to
> the what's used on POSIX with `os::Fork` and `os::Exec` (which will
> not be implemented on Windows).
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c
>
>
> Diff: https://reviews.apache.org/r/68532/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>