You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/24 19:38:08 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9649: [sql] Adding lightweight Table class for SQL parsing
codecov-io edited a comment on pull request #9649:
URL: https://github.com/apache/incubator-superset/pull/9649#issuecomment-619203889
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9649?src=pr&el=h1) Report
> Merging [#9649](https://codecov.io/gh/apache/incubator-superset/pull/9649?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7d5f4494d05ff25c9ab89255fb7b7d0274780709&el=desc) will **decrease** coverage by `4.90%`.
> The diff coverage is `97.29%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9649/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9649?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9649 +/- ##
==========================================
- Coverage 70.52% 65.62% -4.91%
==========================================
Files 574 574
Lines 30166 30178 +12
Branches 3066 3066
==========================================
- Hits 21276 19803 -1473
- Misses 8779 10191 +1412
- Partials 111 184 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.76% <ø> (ø)` | |
| #python | `70.43% <97.29%> (-0.14%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9649?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <83.33%> (-0.35%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.00% <100.00%> (+0.16%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [151 more](https://codecov.io/gh/apache/incubator-superset/pull/9649/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9649?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9649?src=pr&el=footer). Last update [7d5f449...4ca6f1a](https://codecov.io/gh/apache/incubator-superset/pull/9649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org