You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by sujith71955 <gi...@git.apache.org> on 2016/09/17 20:52:09 UTC
[GitHub] incubator-carbondata pull request #169: [CARBONDATA-250] Filter result is no...
GitHub user sujith71955 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/169
[CARBONDATA-250] Filter result is not proper when Double data type values with 0.0 and -0.0 will be used.
[**Problem**]
Equals filter query where -0.0 is used in filter model was not giving proper result since the system was comparing double value 0.0 and -0.0 as different and resultset was getting changed.
eg: select log(c4_double,1) from Test_Boundary1 where log(c4_double,1)= -0.0
[**Solution**]
System has to compare double values for its equality and also it will preserve the -0.0 and 0.0 equality as same == operator ,also preserve NaN equality check as per java.lang.Double.equals()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sujith71955/incubator-carbondata master_DoubleTypeEquals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 6b7c39ccb73d84cf2d5943e0542077d26c1a5e87
Author: Venkata Ramana G <ra...@huawei.com>
Date: 2016-09-17T16:38:11Z
[CARBONDATA-250] Filter result is not proper when Double data type values with 0.0 and -0.0 will be used.
[Description] This method will compare double values for its equality and also it will preserve the -0.0 and 0.0 equality as per == ,also preserve NaN equality check as per java.lang.Double.equals()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #169: [CARBONDATA-250] Filter result is no...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---