[GitHub] eolivelli commented on issue #765: Add `isSealed()` to ReadHandle

[GitBox <gi...@apache.org>]

eolivelli commented on issue #765: Add `isSealed()` to ReadHandle
URL: https://github.com/apache/bookkeeper/issues/765#issuecomment-347835424
 
 
   @sijie  @ivankelly 
   I don't know if renaming asyncClose() to seal() is a good option
   In fact calling asyncClose on a readonly handle does not 'seal' it, it works only for writers.
   It is clear for a BK user that a ledger can be written only once, so it is an expected behavior that WriteHandle.close() closes it and there is no other way to append other data.
   
   For "isClosed()", as an user I would expect that Object.isClosed() will return true if I have called Object.close() not if someone else (from another application/JVM/network...) have "sealed" the ledger, so that no new entry is expected.
   So I think it is a good idea to think about this API now.
   I am in favour of isSealed() or something that explains that no other entry will be added in the future
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services