Re: [PR] WIP [Performance] Optimize DFSchema search by field [arrow-datafusion]

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on PR #9104:
URL: https://github.com/apache/arrow-datafusion/pull/9104#issuecomment-1931106464

   > Perhaps for this PR we could keep the focus on improving search by field performance with your initial implementation plus the points from @alamb? I am curious to see if we could still get some gains just from that and then separately look into how `merge` / `new_with_metadata` are called.
   
   Thanks @matthewmturner I just checked that we probably going into the wrong direction. So `index_of_column_by_name` its not a bottleneck, and its called just 6 times. The bigger problem is excessive calling schema transform functions, so this PR doesn't make sense anymore. It cannot bring up a benefit for now, I'm closing it and will create another issue to optimize the optimizer :)  in schema part


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org