You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/04 19:52:57 UTC
[GitHub] [airflow] dimberman opened a new pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
dimberman opened a new pull request #12819:
URL: https://github.com/apache/airflow/pull/12819
fixes https://github.com/apache/airflow/issues/12587
Fixes issue where dag_run object is not populated if the dag_run already
exists and is reset
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12819:
URL: https://github.com/apache/airflow/pull/12819#discussion_r536354578
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -144,6 +144,9 @@ def execute(self, context: Dict):
dag = dag_bag.get_dag(self.trigger_dag_id)
dag.clear(start_date=self.execution_date, end_date=self.execution_date)
+
+ dag_run = DagRun.find(dag_id=dag.dag_id, run_id=run_id)[0]
Review comment:
I am thinking if `dag_run = dag.get_last_dagrun()` would work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12819:
URL: https://github.com/apache/airflow/pull/12819#discussion_r536429794
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -144,6 +144,8 @@ def execute(self, context: Dict):
dag = dag_bag.get_dag(self.trigger_dag_id)
dag.clear(start_date=self.execution_date, end_date=self.execution_date)
+
+ dag_run = dag.get_last_dagrun(include_externally_triggered=True)
Review comment:
See https://github.com/apache/airflow/pull/12819#discussion_r536429605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #12819:
URL: https://github.com/apache/airflow/pull/12819#discussion_r536366356
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -144,6 +144,9 @@ def execute(self, context: Dict):
dag = dag_bag.get_dag(self.trigger_dag_id)
dag.clear(start_date=self.execution_date, end_date=self.execution_date)
+
+ dag_run = DagRun.find(dag_id=dag.dag_id, run_id=run_id)[0]
Review comment:
@turbaszek fixed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #12819:
URL: https://github.com/apache/airflow/pull/12819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12819:
URL: https://github.com/apache/airflow/pull/12819#issuecomment-739048769
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12819:
URL: https://github.com/apache/airflow/pull/12819#discussion_r536429605
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -144,6 +144,9 @@ def execute(self, context: Dict):
dag = dag_bag.get_dag(self.trigger_dag_id)
dag.clear(start_date=self.execution_date, end_date=self.execution_date)
+
+ dag_run = DagRun.find(dag_id=dag.dag_id, run_id=run_id)[0]
Review comment:
I'm sorry but I'm not sure if my suggestion was good. We retrieve the dag run when one already exist. My suggestion would _probably_ work in case of triggering new one. I think your original suggestion was more ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12819:
URL: https://github.com/apache/airflow/pull/12819#discussion_r536429718
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -144,6 +144,8 @@ def execute(self, context: Dict):
dag = dag_bag.get_dag(self.trigger_dag_id)
dag.clear(start_date=self.execution_date, end_date=self.execution_date)
+
+ dag_run = dag.get_last_dagrun(include_externally_triggered=True)
Review comment:
```suggestion
dag_run = DagRun.find(dag_id=dag.dag_id, run_id=run_id)[0]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator
Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #12819:
URL: https://github.com/apache/airflow/pull/12819#discussion_r536442389
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -144,6 +144,9 @@ def execute(self, context: Dict):
dag = dag_bag.get_dag(self.trigger_dag_id)
dag.clear(start_date=self.execution_date, end_date=self.execution_date)
+
+ dag_run = DagRun.find(dag_id=dag.dag_id, run_id=run_id)[0]
Review comment:
@turbaszek you would only be in the if statement if there is a dag_run to get.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org