You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2010/02/24 01:33:35 UTC
svn commit: r915616 -
/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Author: ivaynberg
Date: Wed Feb 24 00:33:34 2010
New Revision: 915616
URL: http://svn.apache.org/viewvc?rev=915616&view=rev
Log:
WICKET-2750 better error handling for modal window setContent()
Modified:
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java?rev=915616&r1=915615&r2=915616&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/ModalWindow.java Wed Feb 24 00:33:34 2010
@@ -29,6 +29,7 @@
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.panel.Panel;
+import org.apache.wicket.markup.repeater.AbstractRepeater;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.Model;
import org.apache.wicket.ng.request.cycle.RequestCycle;
@@ -841,6 +842,11 @@
throw new WicketRuntimeException("Modal window content id is wrong. Component ID:" +
component.getId() + "; content ID: " + getContentId());
}
+ else if (component instanceof AbstractRepeater)
+ {
+ throw new WicketRuntimeException(
+ "A repeater component cannot be used as the content of a modal window, please use repeater's parent");
+ }
component.setOutputMarkupPlaceholderTag(true);
component.setVisible(false);