[GitHub] [airflow] bbovenzi commented on a diff in pull request #31690: Migration of all DAG details to existing grid view dag details panel

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi commented on code in PR #31690:
URL: https://github.com/apache/airflow/pull/31690#discussion_r1214670369


##########
airflow/www/static/js/dag/details/Dag.tsx:
##########
@@ -72,8 +122,13 @@ const Dag = () => {
         <Tr key={val}>
           <Td>
             <Flex alignItems="center">
-              <SimpleStatus state={val as TaskState} mr={2} />
-              <Text>Total {val}</Text>
+              <SimpleStatus state={val as TaskState} />
+              <LinkButton
+                href={getRedirectUri(val)}

Review Comment:
   We probably want this to be just a link, not a button



##########
airflow/www/views.py:
##########
@@ -1267,98 +1267,6 @@ def code(self, dag_id, session: Session = NEW_SESSION):
             wrapped=conf.getboolean("webserver", "default_wrap"),
         )
 
-    @expose("/dag_details")

Review Comment:
   We're missing the redirect for this URL and the legacy one.



##########
airflow/www/templates/airflow/dag.html:
##########
@@ -206,9 +207,6 @@ <h4 class="pull-right js-dataset-triggered" style="user-select: none;-moz-user-s
           <li><a href="{{ url_for('Airflow.gantt', dag_id=dag.dag_id, root=root, num_runs=num_runs_arg, base_date=base_date_arg, execution_date=execution_date_arg) }}">
             <span class="material-icons" aria-hidden="true">vertical_distribute</span>
             Gantt</a></li>
-          <li><a href="{{ url_for('Airflow.dag_details', dag_id=dag.dag_id) }}">

Review Comment:
   For now, let's leave this and just change the URL. I think it will be best to switch all of these buttons over at once.



##########
airflow/www/templates/airflow/dags.html:
##########
@@ -399,10 +399,6 @@ <h2>{{ page_title }}</h2>
                       <span class="material-icons" aria-hidden="true">code</span>
                       Code
                     </a>
-                    <a href="{{ url_for('Airflow.dag_details', dag_id=dag.dag_id) }}" class="dags-table-more__link">

Review Comment:
   Let's leave this and just change the URL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org