You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/04 09:17:38 UTC

[GitHub] [cloudstack] utchoang opened a new pull request, #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

utchoang opened a new pull request, #6197:
URL: https://github.com/apache/cloudstack/pull/6197

   ### Description
   
   This PR for fixes:
   
   - [x] The login button in Single Sign-On tab not working
   - [x] Single Sign-On tab is disabled when logout from the application
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1087320781

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6197 (SL-JID-1339)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1087315614

   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] rohityadavcloud commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1090031600

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1090032382

   @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] utchoang commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
utchoang commented on PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1087314609

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez merged pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1092326182

   Ping for review @rohityadavcloud @Pearl1594 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6197: UI: fixes login button not work and Single Sign-On tab disabled after logout

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6197:
URL: https://github.com/apache/cloudstack/pull/6197#issuecomment-1090037396

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6197 (SL-JID-1345)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org