You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sdap.apache.org by GitBox <gi...@apache.org> on 2021/03/26 13:12:06 UTC
[GitHub] [incubator-sdap-nexus] twnone opened a new pull request #125: SDAP-304 : Added optional domsconfig "create_keyspace_granted"
twnone opened a new pull request #125:
URL: https://github.com/apache/incubator-sdap-nexus/pull/125
Value can be : True [default] / False
Admin must setup the value to False if the Cassandra user has restricted permissions on the cluster.
The value will be checked before creating DOMS keyspace.
If the user is not permitted to create a keyspace on the Cassandra cluster, then the keyspace will be directly selected & the tables will be created (if needed).
Tested by dropping an existing table ; when Nexus starts, the table is correctly created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] skorper commented on a change in pull request #125: SDAP-304 : Added optional domsconfig "create_keyspace_granted"
Posted by GitBox <gi...@apache.org>.
skorper commented on a change in pull request #125:
URL: https://github.com/apache/incubator-sdap-nexus/pull/125#discussion_r610025874
##########
File path: analysis/webservice/algorithms/doms/DomsInitialization.py
##########
@@ -47,6 +47,10 @@ def init(self, config):
cassDatacenter = domsconfig.get("cassandra", "local_datacenter")
cassVersion = int(domsconfig.get("cassandra", "protocol_version"))
cassPolicy = domsconfig.get("cassandra", "dc_policy")
+ try:
+ cassCreateKeyspaceGranted = domsconfig.get("cassandra", "create_keyspace_granted")
+ except NoOptionError:
Review comment:
@twnone This line caused errors when running my test, but seemed to work when I changed it to
```suggestion
except configparser.NoOptionError:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] ngachung merged pull request #125: SDAP-304 : Added optional domsconfig "create_keyspace_granted"
Posted by GitBox <gi...@apache.org>.
ngachung merged pull request #125:
URL: https://github.com/apache/incubator-sdap-nexus/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sdap-nexus] twnone commented on pull request #125: SDAP-304 : Added optional domsconfig "create_keyspace_granted"
Posted by GitBox <gi...@apache.org>.
twnone commented on pull request #125:
URL: https://github.com/apache/incubator-sdap-nexus/pull/125#issuecomment-816562781
@skorper You are right, the exception processing was not correctly tested on my side ; a lesson was learned here. The issue should be fixed in my last commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org