You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/07/26 22:06:10 UTC

[GitHub] [arrow-datafusion] sarutak opened a new pull request, #7107: Change `rust-version` in Cargo.toml to comply with MSRV

sarutak opened a new pull request, #7107:
URL: https://github.com/apache/arrow-datafusion/pull/7107

   # Which issue does this PR close?
   
   Closes #7106 
   
   # Rationale for this change
   
   As I explained in #7106, we can't build `datafusion` with Rust 1.64 which is specified in Cargo.toml.
   
   # What changes are included in this PR?
   
   Changed `rust-version` in Cargo.toml. I decided the version as reported by `cargo msrv`.
   
   # Are these changes tested?
   
   Confirmed I can build with Rust `1.70`.
   
   # Are there any user-facing changes?
   No. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] sarutak commented on pull request #7107: Change `rust-version` in Cargo.toml to comply with MSRV

Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #7107:
URL: https://github.com/apache/arrow-datafusion/pull/7107#issuecomment-1654092894

   @alamb 
   > There was a similar issue https://github.com/apache/arrow-rs/issues/4487 on arrow-rs a few weeks ago and part of that PR was to add a CI check to ensure the msrv was valid.
   >
   > Are you willing to try and add such a check for DataFusion so the toml file doesn't drift out of sync again?
   
   Thank you for letting me know!
   It's nice to have, and I'll try it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #7107: Change `rust-version` in Cargo.toml to comply with MSRV

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7107:
URL: https://github.com/apache/arrow-datafusion/pull/7107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #7107: Change `rust-version` in Cargo.toml to comply with MSRV

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7107:
URL: https://github.com/apache/arrow-datafusion/pull/7107#issuecomment-1653325554

   Thank you very much @sarutak 
   
   There was a similar issue https://github.com/apache/arrow-rs/issues/4487 on arrow-rs a few weeks ago and part of that PR was to add a CI check to ensure the msrv was valid.
   
   Are you willing to try and add such a check for DataFusion so the toml file doesn't drift out of sync again?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org