You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Arsen Babych <ab...@hortonworks.com> on 2014/02/11 17:31:48 UTC
Review Request 17949: Write unnitests for STORM install script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17949/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-4607
https://issues.apache.org/jira/browse/AMBARI-4607
Repository: ambari
Description
-------
Write unnitests for STORM install script
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/rest_api.py 7b12597
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/service_check.py 1cfbc48
ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/yaml_config.py 1f56486
ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_client.py bdb0a2f
ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_service_check.py 71c1936
ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 79c24ee
ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 870bc22
ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 810d6df
ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py cd63f42
ambari-server/src/test/python/stacks/2.1.1/STORM/test_service_check.py PRE-CREATION
ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_drpc_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_logviewer_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_nimbus.py PRE-CREATION
ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_rest_api_service.py PRE-CREATION
ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_supervisor.py PRE-CREATION
ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_ui_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.1.1/configs/default.json 611645e
ambari-server/src/test/python/stacks/2.1.1/configs/secured.json c4f9a37
Diff: https://reviews.apache.org/r/17949/diff/
Testing
-------
Thanks,
Arsen Babych
Re: Review Request 17949: Write unnitests for STORM install script
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17949/#review34199
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 11, 2014, 4:31 p.m., Arsen Babych wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17949/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 4:31 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-4607
> https://issues.apache.org/jira/browse/AMBARI-4607
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Write unnitests for STORM install script
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/rest_api.py 7b12597
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/service_check.py 1cfbc48
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/yaml_config.py 1f56486
> ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_client.py bdb0a2f
> ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_service_check.py 71c1936
> ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 79c24ee
> ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 870bc22
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 810d6df
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py cd63f42
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_service_check.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_drpc_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_logviewer_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_nimbus.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_rest_api_service.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_supervisor.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_ui_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/configs/default.json 611645e
> ambari-server/src/test/python/stacks/2.1.1/configs/secured.json c4f9a37
>
> Diff: https://reviews.apache.org/r/17949/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arsen Babych
>
>
Re: Review Request 17949: Write unnitests for STORM install script
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17949/#review34196
-----------------------------------------------------------
ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_service_check.py
<https://reviews.apache.org/r/17949/#comment64210>
decimal filemode
ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py
<https://reviews.apache.org/r/17949/#comment64212>
decimal filemode
- Dmitro Lisnichenko
On Feb. 11, 2014, 4:31 p.m., Arsen Babych wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17949/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 4:31 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-4607
> https://issues.apache.org/jira/browse/AMBARI-4607
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Write unnitests for STORM install script
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/rest_api.py 7b12597
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/service_check.py 1cfbc48
> ambari-server/src/main/resources/stacks/HDP/2.1.1/services/STORM/package/scripts/yaml_config.py 1f56486
> ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_client.py bdb0a2f
> ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_service_check.py 71c1936
> ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 79c24ee
> ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 870bc22
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py 810d6df
> ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py cd63f42
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_service_check.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_drpc_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_logviewer_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_nimbus.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_rest_api_service.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_supervisor.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/STORM/test_storm_ui_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.1.1/configs/default.json 611645e
> ambari-server/src/test/python/stacks/2.1.1/configs/secured.json c4f9a37
>
> Diff: https://reviews.apache.org/r/17949/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arsen Babych
>
>