You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2025/07/22 21:56:57 UTC
[PR] fix: build issues on master with 'npm run dev' [superset]
mistercrunch opened a new pull request, #34272:
URL: https://github.com/apache/superset/pull/34272
## Summary
- Fixed webpack alias for missing
`@icons/material/UnfoldMoreHorizontalIcon` in react-color dependency
- Added `.js` extension to resolve module not found error during build
## Test plan
- [x] `npm run dev` builds without module resolution errors
- [x] react-color components render correctly with fallback icon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223922627
##########
superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.js:
##########
@@ -24,7 +24,7 @@ import {
getSequentialSchemeRegistry,
CategoricalColorNamespace,
} from '@superset-ui/core';
-import Datamap from 'datamaps/dist/datamaps.world.min';
+import Datamap from 'datamaps/dist/datamaps.all.min';
Review Comment:
This could increase the size of our js bundle. Just FYI in case we see something in the future and are looking for a reason for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223977070
##########
superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.js:
##########
@@ -24,7 +24,7 @@ import {
getSequentialSchemeRegistry,
CategoricalColorNamespace,
} from '@superset-ui/core';
-import Datamap from 'datamaps/dist/datamaps.world.min';
+import Datamap from 'datamaps/dist/datamaps.all.min';
Review Comment:
yeah main mission is fixing `master` for now ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223934151
##########
superset-frontend/webpack.config.js:
##########
@@ -319,6 +319,13 @@ const config = {
'./node_modules/@storybook/react-dom-shim/dist/react-16',
),
),
+ // Workaround for react-color trying to import non-existent icon
+ '@icons/material/UnfoldMoreHorizontalIcon': path.resolve(
+ path.join(
+ APP_DIR,
+ './node_modules/@icons/material/CubeUnfoldedIcon.js',
+ ),
+ ),
Review Comment:
@mistercrunch is our bot friend right? There is indeed a UnfoldMoreHorizontalIcon file in that node module at `./node_modules/@icons/material/UnfoldMoreHorizontalIcon`, so I'm not sure what's up it being considered nonexistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223928828
##########
superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.js:
##########
@@ -24,7 +24,7 @@ import {
getSequentialSchemeRegistry,
CategoricalColorNamespace,
} from '@superset-ui/core';
-import Datamap from 'datamaps/dist/datamaps.world.min';
+import Datamap from 'datamaps/dist/datamaps.all.min';
Review Comment:
114KB vs 142KB. You're right, but _probably_ nothing to lose sleep over?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #34272:
URL: https://github.com/apache/superset/pull/34272#issuecomment-3109940790
> @mistercrunch how did you encounter the build issue? I'm currently running latest master with changs in PR being uncommented but unable to reproduce it :(
oh now you're making me doubt whether my issues could have been local (?) Clearly there's some things that happened recently that didn't play nice with the frontend build cache. Or maybe your environment is ok because of some caching.
Now thinking that if I had time, I'd start clean with a new cloned repo and see if my issues can be reproduced prior to this PR.
What I'd do (or might do if I can find the time...):
- start super fresh, git clone in a new folder (no cache!) as of the SHA right before this commit here got merged on `master`
- nuke database
- nuke npm cache, any other cache ...
- `docker compose up`, see if things build or if we see any build-related issues
- if no issues, revert this PR ...
- if there are issues, try as of after this PR to see if my PR indeed fixes issues
Now after this fix or sometime yesterday, I did discover I had a zombie `npm run dev` process that was causing havoc. This whole saga could be related to that, but I'm unclear on that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223922627
##########
superset-frontend/plugins/legacy-plugin-chart-world-map/src/WorldMap.js:
##########
@@ -24,7 +24,7 @@ import {
getSequentialSchemeRegistry,
CategoricalColorNamespace,
} from '@superset-ui/core';
-import Datamap from 'datamaps/dist/datamaps.world.min';
+import Datamap from 'datamaps/dist/datamaps.all.min';
Review Comment:
This could increase the size of our js bundle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #34272:
URL: https://github.com/apache/superset/pull/34272#issuecomment-3109237795
@mistercrunch how did you encounter the build issue? I'm currently running latest `master` with changs in PR being uncommented but unable to reproduce it :(
<img width="1464" height="789" alt="image" src="https://github.com/user-attachments/assets/9d3a2c4d-6469-49eb-92a4-0dfa98aea0bf" />
<img width="1464" height="885" alt="image" src="https://github.com/user-attachments/assets/76fe791a-3ac4-43a5-a4a5-a2e29f259e49" />
<img width="1464" height="885" alt="image" src="https://github.com/user-attachments/assets/2801f564-d0c3-489d-8ac2-17c037cf7b41" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223908738
##########
superset-frontend/webpack.config.js:
##########
@@ -319,6 +319,13 @@ const config = {
'./node_modules/@storybook/react-dom-shim/dist/react-16',
),
),
+ // Workaround for react-color trying to import non-existent icon
+ '@icons/material/UnfoldMoreHorizontalIcon': path.resolve(
+ path.join(
+ APP_DIR,
+ './node_modules/@icons/material/CubeUnfoldedIcon.js',
+ ),
+ ),
Review Comment:
### Icon Substitution Mismatch <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The webpack alias substitutes UnfoldMoreHorizontalIcon with CubeUnfoldedIcon, which are visually different icons that could impact the user interface.
###### Why this matters
Using a different icon than what was intended by react-color could confuse users and break the expected visual functionality of the color picker component.
###### Suggested change ∙ *Feature Preview*
Instead of substituting with a different icon, consider:
1. Either installing the correct @icons/material package that contains UnfoldMoreHorizontalIcon
2. Or create a minimal implementation of UnfoldMoreHorizontalIcon that matches the expected visual:
```javascript
// Create a new file: @icons/material/UnfoldMoreHorizontalIcon.js
export default function UnfoldMoreHorizontalIcon(props) {
return (
<svg viewBox="0 0 24 24" {...props}>
<path d="M12 18l4-4h-8l4 4zm0-12l-4 4h8l-4-4z" />
</svg>
);
}
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:002a17ba-b5b9-4e92-bf92-f20197c34db4 -->
[](002a17ba-b5b9-4e92-bf92-f20197c34db4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223934431
##########
superset-frontend/webpack.config.js:
##########
@@ -319,6 +319,13 @@ const config = {
'./node_modules/@storybook/react-dom-shim/dist/react-16',
),
),
+ // Workaround for react-color trying to import non-existent icon
+ '@icons/material/UnfoldMoreHorizontalIcon': path.resolve(
+ path.join(
+ APP_DIR,
+ './node_modules/@icons/material/CubeUnfoldedIcon.js',
+ ),
+ ),
Review Comment:
If the icon file exists at that path, you're right - there may be an issue with webpack's resolution rather than a missing file. Could you check if there are any import/export issues in the UnfoldMoreHorizontalIcon file itself? Alternatively, we could try removing the alias since the file exists where react-color expects it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: build issues on master with 'npm run dev' [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #34272:
URL: https://github.com/apache/superset/pull/34272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org