You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2019/08/01 05:28:09 UTC

[GitHub] [incubator-weex] weex-bot commented on issue #2772: [iOS] Convert to immutable instance. Make code stronger.

weex-bot commented on issue #2772: [iOS] Convert to immutable instance. Make code stronger.
URL: https://github.com/apache/incubator-weex/pull/2772#issuecomment-517125384
 
 
   
   <!--
     0 failure: 
     4 warning:  If you update the..., If your PR is abo..., Current pr not bi..., No Changelog chan...
     1 messages
     
   -->
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>If you update the code, maybe you should update the documentation and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation:https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document 
   </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. 
    here is a demo link:http://dotwe.org/vue?spm=a2c7j.-guide-contribute-contribute-code.0.0.3e93748cmxz3yt</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Current pr not bind the milestone</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Messages</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:book:</td>
         <td>danger test finished.</td>
       </tr>
     </tbody>
   </table>
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services