You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by TengYao Chi <ki...@gmail.com> on 2024/09/16 13:47:11 UTC
[VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Hi everyone,
Based on our discussion
<https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg>, I
believe this KIP is now ready for a vote.
Sincerely,
TengYao
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by TengYao Chi <ki...@gmail.com>.
Hello everyone,
The vote is now closed, and the KIP has been accepted with 4 binding +1s
from Chia-Ping, Chris, David, and Lianet, as well as 3 non-binding +1 from
Kirk, TaiJuWu, and Andrew.
Thank you all for your participation!
Sincerely,
TengYao
TengYao Chi <ki...@gmail.com> 於 2024年10月3日 週四 下午7:41寫道：
> Hi Lianet,
> Thank you for the reminder.
> I have updated the content. 😀
>
> Best,
> TengYao
>
> Lianet M. <li...@gmail.com> 於 2024年10月3日 週四 下午6:50寫道：
>
>> Hello TengYao, just one last minor comment. The KIP refers in multiple
>> places to bumping the heartbeat RPC from version 0 to version 1. We should
>> update that given that the RPC is already in version 1.
>>
>> With that I'm +1 (binding)
>>
>> Thanks!
>> Lianet
>>
>> On Thu, Oct 3, 2024 at 5:01 AM David Jacot <dj...@confluent.io.invalid>
>> wrote:
>>
>> > +1 (binding)
>> >
>> > Thanks for the KIP!
>> >
>> > Best,
>> > David
>> >
>> > On Thu, Oct 3, 2024 at 10:49 AM TengYao Chi <ki...@gmail.com>
>> wrote:
>> >
>> > > Hello everyone,
>> > > As the vote has been pending for two weeks, I would like to push it
>> > > manually.
>> > > Thank you for your attention.
>> > >
>> > > Best,
>> > > TengYao
>> > >
>> > > Chris Egerton <fe...@gmail.com> 於 2024年9月19日 週四 上午1:42寫道：
>> > >
>> > > > Thanks for the KIP! +1 (binding)
>> > > >
>> > > > On Tue, Sep 17, 2024 at 12:45 PM Andrew Schofield <
>> > > > andrew_schofield_jira@outlook.com> wrote:
>> > > >
>> > > > > +1 (non-binding)
>> > > > >
>> > > > > ________________________________________
>> > > > > From: 吳岱儒 <tj...@gmail.com>
>> > > > > Sent: 17 September 2024 04:24
>> > > > > To: dev@kafka.apache.org <de...@kafka.apache.org>
>> > > > > Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over
>> the
>> > > > > ConsumerGroupHeartbeat RPC
>> > > > >
>> > > > > +1 (non-binding)
>> > > > >
>> > > > > Best,
>> > > > > TaiJuWu
>> > > > >
>> > > > > Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
>> > > > >
>> > > > > > +1 (binding)
>> > > > > >
>> > > > > > thanks for reaching out to the corner case.
>> > > > > >
>> > > > > > Best,
>> > > > > > Chia-Ping
>> > > > > >
>> > > > > > Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
>> > > > > >
>> > > > > > > Hi TengYao,
>> > > > > > >
>> > > > > > > +1 (non-binding)
>> > > > > > >
>> > > > > > > Thanks for all the hard work with the tricky edge cases :)
>> > > > > > >
>> > > > > > > Kirk
>> > > > > > >
>> > > > > > > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <
>> kitingiao@gmail.com>
>> > > > > wrote:
>> > > > > > > >
>> > > > > > > > Hi everyone,
>> > > > > > > >
>> > > > > > > > Based on our discussion
>> > > > > > > > <
>> > > https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
>> > > > > > > > regarding KIP-1082 <
>> > https://cwiki.apache.org/confluence/x/XBDOEg
>> > > >,
>> > > > I
>> > > > > > > > believe this KIP is now ready for a vote.
>> > > > > > > >
>> > > > > > > > Sincerely,
>> > > > > > > > TengYao
>> > > > > > >
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by TengYao Chi <ki...@gmail.com>.
Hi Lianet,
Thank you for the reminder.
I have updated the content. 😀
Best,
TengYao
Lianet M. <li...@gmail.com> 於 2024年10月3日 週四 下午6:50寫道：
> Hello TengYao, just one last minor comment. The KIP refers in multiple
> places to bumping the heartbeat RPC from version 0 to version 1. We should
> update that given that the RPC is already in version 1.
>
> With that I'm +1 (binding)
>
> Thanks!
> Lianet
>
> On Thu, Oct 3, 2024 at 5:01 AM David Jacot <dj...@confluent.io.invalid>
> wrote:
>
> > +1 (binding)
> >
> > Thanks for the KIP!
> >
> > Best,
> > David
> >
> > On Thu, Oct 3, 2024 at 10:49 AM TengYao Chi <ki...@gmail.com> wrote:
> >
> > > Hello everyone,
> > > As the vote has been pending for two weeks, I would like to push it
> > > manually.
> > > Thank you for your attention.
> > >
> > > Best,
> > > TengYao
> > >
> > > Chris Egerton <fe...@gmail.com> 於 2024年9月19日 週四 上午1:42寫道：
> > >
> > > > Thanks for the KIP! +1 (binding)
> > > >
> > > > On Tue, Sep 17, 2024 at 12:45 PM Andrew Schofield <
> > > > andrew_schofield_jira@outlook.com> wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > ________________________________________
> > > > > From: 吳岱儒 <tj...@gmail.com>
> > > > > Sent: 17 September 2024 04:24
> > > > > To: dev@kafka.apache.org <de...@kafka.apache.org>
> > > > > Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over the
> > > > > ConsumerGroupHeartbeat RPC
> > > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > Best,
> > > > > TaiJuWu
> > > > >
> > > > > Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > thanks for reaching out to the corner case.
> > > > > >
> > > > > > Best,
> > > > > > Chia-Ping
> > > > > >
> > > > > > Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
> > > > > >
> > > > > > > Hi TengYao,
> > > > > > >
> > > > > > > +1 (non-binding)
> > > > > > >
> > > > > > > Thanks for all the hard work with the tricky edge cases :)
> > > > > > >
> > > > > > > Kirk
> > > > > > >
> > > > > > > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <
> kitingiao@gmail.com>
> > > > > wrote:
> > > > > > > >
> > > > > > > > Hi everyone,
> > > > > > > >
> > > > > > > > Based on our discussion
> > > > > > > > <
> > > https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > > > > > > > regarding KIP-1082 <
> > https://cwiki.apache.org/confluence/x/XBDOEg
> > > >,
> > > > I
> > > > > > > > believe this KIP is now ready for a vote.
> > > > > > > >
> > > > > > > > Sincerely,
> > > > > > > > TengYao
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by "Lianet M." <li...@gmail.com>.
Hello TengYao, just one last minor comment. The KIP refers in multiple
places to bumping the heartbeat RPC from version 0 to version 1. We should
update that given that the RPC is already in version 1.
With that I'm +1 (binding)
Thanks!
Lianet
On Thu, Oct 3, 2024 at 5:01 AM David Jacot <dj...@confluent.io.invalid>
wrote:
> +1 (binding)
>
> Thanks for the KIP!
>
> Best,
> David
>
> On Thu, Oct 3, 2024 at 10:49 AM TengYao Chi <ki...@gmail.com> wrote:
>
> > Hello everyone,
> > As the vote has been pending for two weeks, I would like to push it
> > manually.
> > Thank you for your attention.
> >
> > Best,
> > TengYao
> >
> > Chris Egerton <fe...@gmail.com> 於 2024年9月19日 週四 上午1:42寫道：
> >
> > > Thanks for the KIP! +1 (binding)
> > >
> > > On Tue, Sep 17, 2024 at 12:45 PM Andrew Schofield <
> > > andrew_schofield_jira@outlook.com> wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > ________________________________________
> > > > From: 吳岱儒 <tj...@gmail.com>
> > > > Sent: 17 September 2024 04:24
> > > > To: dev@kafka.apache.org <de...@kafka.apache.org>
> > > > Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over the
> > > > ConsumerGroupHeartbeat RPC
> > > >
> > > > +1 (non-binding)
> > > >
> > > > Best,
> > > > TaiJuWu
> > > >
> > > > Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > thanks for reaching out to the corner case.
> > > > >
> > > > > Best,
> > > > > Chia-Ping
> > > > >
> > > > > Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
> > > > >
> > > > > > Hi TengYao,
> > > > > >
> > > > > > +1 (non-binding)
> > > > > >
> > > > > > Thanks for all the hard work with the tricky edge cases :)
> > > > > >
> > > > > > Kirk
> > > > > >
> > > > > > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com>
> > > > wrote:
> > > > > > >
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > Based on our discussion
> > > > > > > <
> > https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > > > > > > regarding KIP-1082 <
> https://cwiki.apache.org/confluence/x/XBDOEg
> > >,
> > > I
> > > > > > > believe this KIP is now ready for a vote.
> > > > > > >
> > > > > > > Sincerely,
> > > > > > > TengYao
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by David Jacot <dj...@confluent.io.INVALID>.
+1 (binding)
Thanks for the KIP!
Best,
David
On Thu, Oct 3, 2024 at 10:49 AM TengYao Chi <ki...@gmail.com> wrote:
> Hello everyone,
> As the vote has been pending for two weeks, I would like to push it
> manually.
> Thank you for your attention.
>
> Best,
> TengYao
>
> Chris Egerton <fe...@gmail.com> 於 2024年9月19日 週四 上午1:42寫道：
>
> > Thanks for the KIP! +1 (binding)
> >
> > On Tue, Sep 17, 2024 at 12:45 PM Andrew Schofield <
> > andrew_schofield_jira@outlook.com> wrote:
> >
> > > +1 (non-binding)
> > >
> > > ________________________________________
> > > From: 吳岱儒 <tj...@gmail.com>
> > > Sent: 17 September 2024 04:24
> > > To: dev@kafka.apache.org <de...@kafka.apache.org>
> > > Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over the
> > > ConsumerGroupHeartbeat RPC
> > >
> > > +1 (non-binding)
> > >
> > > Best,
> > > TaiJuWu
> > >
> > > Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
> > >
> > > > +1 (binding)
> > > >
> > > > thanks for reaching out to the corner case.
> > > >
> > > > Best,
> > > > Chia-Ping
> > > >
> > > > Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
> > > >
> > > > > Hi TengYao,
> > > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > Thanks for all the hard work with the tricky edge cases :)
> > > > >
> > > > > Kirk
> > > > >
> > > > > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > Hi everyone,
> > > > > >
> > > > > > Based on our discussion
> > > > > > <
> https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > > > > > regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg
> >,
> > I
> > > > > > believe this KIP is now ready for a vote.
> > > > > >
> > > > > > Sincerely,
> > > > > > TengYao
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by TengYao Chi <ki...@gmail.com>.
Hello everyone,
As the vote has been pending for two weeks, I would like to push it
manually.
Thank you for your attention.
Best,
TengYao
Chris Egerton <fe...@gmail.com> 於 2024年9月19日 週四 上午1:42寫道：
> Thanks for the KIP! +1 (binding)
>
> On Tue, Sep 17, 2024 at 12:45 PM Andrew Schofield <
> andrew_schofield_jira@outlook.com> wrote:
>
> > +1 (non-binding)
> >
> > ________________________________________
> > From: 吳岱儒 <tj...@gmail.com>
> > Sent: 17 September 2024 04:24
> > To: dev@kafka.apache.org <de...@kafka.apache.org>
> > Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over the
> > ConsumerGroupHeartbeat RPC
> >
> > +1 (non-binding)
> >
> > Best,
> > TaiJuWu
> >
> > Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
> >
> > > +1 (binding)
> > >
> > > thanks for reaching out to the corner case.
> > >
> > > Best,
> > > Chia-Ping
> > >
> > > Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
> > >
> > > > Hi TengYao,
> > > >
> > > > +1 (non-binding)
> > > >
> > > > Thanks for all the hard work with the tricky edge cases :)
> > > >
> > > > Kirk
> > > >
> > > > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com>
> > wrote:
> > > > >
> > > > > Hi everyone,
> > > > >
> > > > > Based on our discussion
> > > > > <https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > > > > regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg>,
> I
> > > > > believe this KIP is now ready for a vote.
> > > > >
> > > > > Sincerely,
> > > > > TengYao
> > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by Chris Egerton <fe...@gmail.com>.
Thanks for the KIP! +1 (binding)
On Tue, Sep 17, 2024 at 12:45 PM Andrew Schofield <
andrew_schofield_jira@outlook.com> wrote:
> +1 (non-binding)
>
> ________________________________________
> From: 吳岱儒 <tj...@gmail.com>
> Sent: 17 September 2024 04:24
> To: dev@kafka.apache.org <de...@kafka.apache.org>
> Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over the
> ConsumerGroupHeartbeat RPC
>
> +1 (non-binding)
>
> Best,
> TaiJuWu
>
> Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
>
> > +1 (binding)
> >
> > thanks for reaching out to the corner case.
> >
> > Best,
> > Chia-Ping
> >
> > Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
> >
> > > Hi TengYao,
> > >
> > > +1 (non-binding)
> > >
> > > Thanks for all the hard work with the tricky edge cases :)
> > >
> > > Kirk
> > >
> > > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com>
> wrote:
> > > >
> > > > Hi everyone,
> > > >
> > > > Based on our discussion
> > > > <https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > > > regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg>, I
> > > > believe this KIP is now ready for a vote.
> > > >
> > > > Sincerely,
> > > > TengYao
> > >
> > >
> >
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by Andrew Schofield <an...@outlook.com>.
+1 (non-binding)
________________________________________
From: 吳岱儒 <tj...@gmail.com>
Sent: 17 September 2024 04:24
To: dev@kafka.apache.org <de...@kafka.apache.org>
Subject: Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
+1 (non-binding)
Best,
TaiJuWu
Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
> +1 (binding)
>
> thanks for reaching out to the corner case.
>
> Best,
> Chia-Ping
>
> Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
>
> > Hi TengYao,
> >
> > +1 (non-binding)
> >
> > Thanks for all the hard work with the tricky edge cases :)
> >
> > Kirk
> >
> > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com> wrote:
> > >
> > > Hi everyone,
> > >
> > > Based on our discussion
> > > <https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > > regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg>, I
> > > believe this KIP is now ready for a vote.
> > >
> > > Sincerely,
> > > TengYao
> >
> >
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by 吳岱儒 <tj...@gmail.com>.
+1 (non-binding)
Best,
TaiJuWu
Chia-Ping Tsai <ch...@gmail.com> 於 2024年9月16日 週一 下午11:41寫道：
> +1 (binding)
>
> thanks for reaching out to the corner case.
>
> Best,
> Chia-Ping
>
> Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
>
> > Hi TengYao,
> >
> > +1 (non-binding)
> >
> > Thanks for all the hard work with the tricky edge cases :)
> >
> > Kirk
> >
> > > On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com> wrote:
> > >
> > > Hi everyone,
> > >
> > > Based on our discussion
> > > <https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > > regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg>, I
> > > believe this KIP is now ready for a vote.
> > >
> > > Sincerely,
> > > TengYao
> >
> >
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by Chia-Ping Tsai <ch...@gmail.com>.
+1 (binding)
thanks for reaching out to the corner case.
Best,
Chia-Ping
Kirk True <ki...@kirktrue.pro> 於 2024年9月16日 週一 下午11:36寫道：
> Hi TengYao,
>
> +1 (non-binding)
>
> Thanks for all the hard work with the tricky edge cases :)
>
> Kirk
>
> > On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com> wrote:
> >
> > Hi everyone,
> >
> > Based on our discussion
> > <https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> > regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg>, I
> > believe this KIP is now ready for a vote.
> >
> > Sincerely,
> > TengYao
>
>
Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC
Posted by Kirk True <ki...@kirktrue.pro>.
Hi TengYao,
+1 (non-binding)
Thanks for all the hard work with the tricky edge cases :)
Kirk
> On Sep 16, 2024, at 6:47 AM, TengYao Chi <ki...@gmail.com> wrote:
>
> Hi everyone,
>
> Based on our discussion
> <https://lists.apache.org/thread/vvytypk3l8cvv8yltrckfg6yf7ovd371>
> regarding KIP-1082 <https://cwiki.apache.org/confluence/x/XBDOEg>, I
> believe this KIP is now ready for a vote.
>
> Sincerely,
> TengYao