You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/05/20 08:44:45 UTC
[GitHub] [spark] beliefer opened a new pull request, #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
beliefer opened a new pull request, #41242:
URL: https://github.com/apache/spark/pull/41242
### What changes were proposed in this pull request?
The pr aims to assign a name to the error class _LEGACY_ERROR_TEMP_2400.
### Why are the changes needed?
Improve the error framework.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
Exists test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
URL: https://github.com/apache/spark/pull/41242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #41242:
URL: https://github.com/apache/spark/pull/41242#discussion_r1199699440
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -85,7 +85,7 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
private def checkLimitLikeClause(name: String, limitExpr: Expression): Unit = {
limitExpr match {
case e if !e.foldable => limitExpr.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2400",
+ errorClass = "LIMIT_LIKE_EXPRESSION_IS_UNFOLDABLE",
messageParameters = Map(
"name" -> name,
"limitExpr" -> limitExpr.sql))
Review Comment:
Please, wrap the expression `limitExpr` by `toSQLExpr()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41242:
URL: https://github.com/apache/spark/pull/41242#issuecomment-1555864892
ping @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #41242:
URL: https://github.com/apache/spark/pull/41242#discussion_r1199860069
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -85,7 +85,7 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
private def checkLimitLikeClause(name: String, limitExpr: Expression): Unit = {
limitExpr match {
case e if !e.foldable => limitExpr.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2400",
+ errorClass = "LIMIT_LIKE_EXPRESSION_IS_UNFOLDABLE",
messageParameters = Map(
"name" -> name,
"limitExpr" -> limitExpr.sql))
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #41242:
URL: https://github.com/apache/spark/pull/41242#issuecomment-1556632758
+1, LGTM. Merging to master.
Thank you, @beliefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #41242: [SPARK-43598][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_2400
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41242:
URL: https://github.com/apache/spark/pull/41242#issuecomment-1556688113
@MaxGekk Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org