You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/06/19 13:02:16 UTC

[PR] Strengthen review-pr anti-drip workflow [shardingsphere]

terrymanu opened a new pull request, #38874:
URL: https://github.com/apache/shardingsphere/pull/38874

   Add an anti-drip review gate that requires a frozen review inventory, origin classification, latest-delta plus full-path review, and deduplication by independent fix boundary before producing final PR feedback.
   
   Add a local review inventory helper script to surface changed-file categories, new public production types, test-reference hints, lifecycle and protocol clues, risky state sentinels, and optional GitHub file-list scope matching.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Strengthen review-pr anti-drip workflow [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38874:
URL: https://github.com/apache/shardingsphere/pull/38874


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Strengthen review-pr anti-drip workflow [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #38874:
URL: https://github.com/apache/shardingsphere/pull/38874#issuecomment-4752931236

   ### Summary
   
   - **Merge Decision: Mergeable**
   - **Reason:** The latest PR head fixes the inventory helper command issue and the remaining changes are scoped, verifiable, and do not affect ShardingSphere runtime behavior.
   
   ### Evidence
   
   - The inventory helper command now uses `python3` in `.codex/skills/review-pr/SKILL.md:248`, matching the script shebang in `.codex/skills/review-pr/scripts/build_review_inventory.py:1`.
   - The anti-drip workflow now explicitly requires a frozen review inventory, candidate-origin classification, deduplication by independent fix boundary, latest-head full-path review, and a final adversarial pass before producing one consolidated review.
   - The helper script is local-only, does not query GitHub, uses local git refs to reproduce triple-dot PR scope, reports dirty-worktree contamination, and marks its output as heuristic rather than review evidence.
   - The latest delta from the previous PR head only changes the documented helper command from `python` to `python3`; no unrelated files or substantive scope expansion were found.
   - No production Java, parser, JDBC, Proxy, dependency, distribution, released artifact, or user-facing ShardingSphere behavior is changed.
   
   ### Review Details
   
   - **Reviewed Scope:** Reviewed `.codex/skills/review-pr/SKILL.md` and `.codex/skills/review-pr/scripts/build_review_inventory.py` at PR head `dcfcc3b85743364321c11526b205bd01e6ffaf0a`; base and local merge-base were both `9bf5bf5d720e2629424c2caf2f385d645cc98d9b`. The local triple-dot file list matched GitHub `/pulls/38874/files` exactly: 2 files, no mismatch. No linked issue or GitHub-visible prior review comments were present.
   - **Not Reviewed Scope:** GitHub Actions/check-run status was not reviewed by workflow rule. ShardingSphere runtime modules were not reviewed because the PR only changes the repo-local review skill and helper script.
   - **Verification:** `python3 .codex/skills/review-pr/scripts/build_review_inventory.py --help` exited 0; Python AST syntax parsing for `build_review_inventory.py` exited 0; inventory generation with the GitHub file list exited 0 and reported `matched=true`; mismatch smoke verification exited 0 and reported `matched=false`; `git diff --check` for the changed files exited 0; `./mvnw spotless:check -Pcheck -T1C` exited 0; `./mvnw checkstyle:check -Pcheck -T1C` exited 0; `./mvnw apache-rat:check -Pcheck -T1C` exited 0.
   - **Release Note / User Docs:** Not required; this is a repo-local Codex review workflow/tooling change and does not change user-facing ShardingSphere behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org