You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/05/31 04:37:50 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #2741] Add kyuubi-spark-connector-common module
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new d24c18dbb [KYUUBI #2741] Add kyuubi-spark-connector-common module
d24c18dbb is described below
commit d24c18dbb27682840b930bd2ada15ae7f6b00296
Author: jiaoqingbo <11...@qq.com>
AuthorDate: Tue May 31 12:37:40 2022 +0800
[KYUUBI #2741] Add kyuubi-spark-connector-common module
### _Why are the changes needed?_
fix #2741
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #2777 from jiaoqingbo/kyuubi-2741.
Closes #2741
ec7185e9 [jiaoqingbo] code review
33114d18 [jiaoqingbo] code review
df603c8d [jiaoqingbo] Merge branch 'master' into kyuubi-2741
767e4365 [jiaoqingbo] [KYUUBI #2741]add kyuubi-spark-connector-common module to contain things that are commonly used by multiple spark connectors
8e79bd9e [jiaoqingbo] invoke ci
c5c7b81a [jiaoqingbo] [KYUUBI #2741]add kyuubi-spark-connector-common module to contain things that are commonly used by multiple spark connectors
b0196d61 [jiaoqingbo] invoke ci
af3dab2e [jiaoqingbo] [KYUUBI #2741]add kyuubi-spark-connector-common module to contain things that are commonly used by multiple spark connectors
Authored-by: jiaoqingbo <11...@qq.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.../pom.xml | 103 +--------------------
.../spark/connector/common}/SparkUtils.scala | 2 +-
.../src/test/resources/log4j.properties | 44 +++++++++
.../connector/common}/LocalSparkSession.scala | 2 +-
.../spark/kyuubi-spark-connector-tpcds/pom.xml | 16 ++++
.../spark/connector/tpcds/LocalSparkSession.scala | 39 --------
.../spark/connector/tpcds/TPCDSCatalogSuite.scala | 3 +-
.../spark/connector/tpcds/TPCDSQuerySuite.scala | 2 +-
.../spark/connector/tpcds/TPCDSTableSuite.scala | 2 +-
.../spark/kyuubi-spark-connector-tpch/pom.xml | 15 +++
.../kyuubi/spark/connector/tpch/SparkUtils.scala | 78 ----------------
.../spark/connector/tpch/TPCHCatalogSuite.scala | 1 +
pom.xml | 1 +
13 files changed, 85 insertions(+), 223 deletions(-)
diff --git a/extensions/spark/kyuubi-spark-connector-tpcds/pom.xml b/extensions/spark/kyuubi-spark-connector-common/pom.xml
similarity index 50%
copy from extensions/spark/kyuubi-spark-connector-tpcds/pom.xml
copy to extensions/spark/kyuubi-spark-connector-common/pom.xml
index b75e417db..906d0f398 100644
--- a/extensions/spark/kyuubi-spark-connector-tpcds/pom.xml
+++ b/extensions/spark/kyuubi-spark-connector-common/pom.xml
@@ -27,8 +27,8 @@
</parent>
<modelVersion>4.0.0</modelVersion>
- <artifactId>kyuubi-spark-connector-tpcds_2.12</artifactId>
- <name>Kyuubi Spark TPC-DS Connector</name>
+ <artifactId>kyuubi-spark-connector-common_2.12</artifactId>
+ <name>Kyuubi Spark Connector Common</name>
<packaging>jar</packaging>
<url>https://kyuubi.apache.org/</url>
@@ -51,16 +51,6 @@
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>io.trino.tpcds</groupId>
- <artifactId>tpcds</artifactId>
- </dependency>
-
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- </dependency>
-
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_${scala.binary.version}</artifactId>
@@ -88,56 +78,6 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
-
- <dependency>
- <groupId>org.apache.kyuubi</groupId>
- <artifactId>kyuubi-common_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.kyuubi</groupId>
- <artifactId>kyuubi-common_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <type>test-jar</type>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-client-api</artifactId>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-client-runtime</artifactId>
- <scope>test</scope>
- </dependency>
-
- <!--
- Spark requires `commons-collections` and `commons-io` but got them from transitive
- dependencies of `hadoop-client`. As we are using Hadoop Shaded Client, we need add
- them explicitly. See more details at SPARK-33212.
- -->
- <dependency>
- <groupId>commons-collections</groupId>
- <artifactId>commons-collections</artifactId>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>commons-io</groupId>
- <artifactId>commons-io</artifactId>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>jakarta.xml.bind</groupId>
- <artifactId>jakarta.xml.bind-api</artifactId>
- <scope>test</scope>
- </dependency>
</dependencies>
<build>
@@ -145,45 +85,6 @@
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
<plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-dependency-plugin</artifactId>
- <configuration>
- <skip>true</skip>
- </configuration>
- </plugin>
-
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <configuration>
- <shadedArtifactAttached>false</shadedArtifactAttached>
- <artifactSet>
- <includes>
- <include>io.trino.tpcds:tpcds</include>
- <include>com.google.guava:guava</include>
- </includes>
- </artifactSet>
- <relocations>
- <relocation>
- <pattern>com.google.common</pattern>
- <shadedPattern>${kyuubi.shade.packageName}.com.google.common</shadedPattern>
- <includes>
- <include>com.google.common.**</include>
- </includes>
- </relocation>
- </relocations>
- </configuration>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
diff --git a/extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/SparkUtils.scala b/extensions/spark/kyuubi-spark-connector-common/src/main/scala/org/apache/kyuubi/spark/connector/common/SparkUtils.scala
similarity index 98%
rename from extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/SparkUtils.scala
rename to extensions/spark/kyuubi-spark-connector-common/src/main/scala/org/apache/kyuubi/spark/connector/common/SparkUtils.scala
index 3e3da3a0d..dbff8f7b7 100644
--- a/extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/SparkUtils.scala
+++ b/extensions/spark/kyuubi-spark-connector-common/src/main/scala/org/apache/kyuubi/spark/connector/common/SparkUtils.scala
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.kyuubi.spark.connector.tpcds
+package org.apache.kyuubi.spark.connector.common
import org.apache.spark.SPARK_VERSION
diff --git a/extensions/spark/kyuubi-spark-connector-common/src/test/resources/log4j.properties b/extensions/spark/kyuubi-spark-connector-common/src/test/resources/log4j.properties
new file mode 100644
index 000000000..68d6a0e66
--- /dev/null
+++ b/extensions/spark/kyuubi-spark-connector-common/src/test/resources/log4j.properties
@@ -0,0 +1,44 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Set everything to be logged to the file target/unit-tests.log
+log4j.rootLogger=INFO, CA, FA
+
+# Console Appender
+log4j.appender.CA=org.apache.log4j.ConsoleAppender
+log4j.appender.CA.layout=org.apache.log4j.PatternLayout
+log4j.appender.CA.layout.ConversionPattern=%d{HH:mm:ss.SSS} %p %c: %m%n
+log4j.appender.CA.Threshold = FATAL
+
+# File Appender
+log4j.appender.FA=org.apache.log4j.FileAppender
+log4j.appender.FA.append=false
+log4j.appender.FA.file=target/unit-tests.log
+log4j.appender.FA.layout=org.apache.log4j.PatternLayout
+log4j.appender.FA.layout.ConversionPattern=%d{HH:mm:ss.SSS} %t %p %c{2}: %m%n
+
+# Set the logger level of File Appender to WARN
+log4j.appender.FA.Threshold = DEBUG
+
+# SPARK-34128: Suppress undesirable TTransportException warnings involved in THRIFT-4805
+log4j.appender.CA.filter.1=org.apache.log4j.varia.StringMatchFilter
+log4j.appender.CA.filter.1.StringToMatch=Thrift error occurred during processing of message
+log4j.appender.CA.filter.1.AcceptOnMatch=false
+
+log4j.appender.FA.filter.1=org.apache.log4j.varia.StringMatchFilter
+log4j.appender.FA.filter.1.StringToMatch=Thrift error occurred during processing of message
+log4j.appender.FA.filter.1.AcceptOnMatch=false
diff --git a/extensions/spark/kyuubi-spark-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/LocalSparkSession.scala b/extensions/spark/kyuubi-spark-connector-common/src/test/scala/org/apache/kyuubi/spark/connector/common/LocalSparkSession.scala
similarity index 96%
rename from extensions/spark/kyuubi-spark-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/LocalSparkSession.scala
rename to extensions/spark/kyuubi-spark-connector-common/src/test/scala/org/apache/kyuubi/spark/connector/common/LocalSparkSession.scala
index 8b60be98c..8474118a6 100644
--- a/extensions/spark/kyuubi-spark-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/LocalSparkSession.scala
+++ b/extensions/spark/kyuubi-spark-connector-common/src/test/scala/org/apache/kyuubi/spark/connector/common/LocalSparkSession.scala
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.kyuubi.spark.connector.tpch
+package org.apache.kyuubi.spark.connector.common
import org.apache.spark.sql.SparkSession
diff --git a/extensions/spark/kyuubi-spark-connector-tpcds/pom.xml b/extensions/spark/kyuubi-spark-connector-tpcds/pom.xml
index b75e417db..25d11d806 100644
--- a/extensions/spark/kyuubi-spark-connector-tpcds/pom.xml
+++ b/extensions/spark/kyuubi-spark-connector-tpcds/pom.xml
@@ -33,6 +33,21 @@
<url>https://kyuubi.apache.org/</url>
<dependencies>
+
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-spark-connector-common_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-spark-connector-common_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
@@ -162,6 +177,7 @@
<includes>
<include>io.trino.tpcds:tpcds</include>
<include>com.google.guava:guava</include>
+ <include>org.apache.kyuubi:kyuubi-spark-connector-common_${scala.binary.version}</include>
</includes>
</artifactSet>
<relocations>
diff --git a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/LocalSparkSession.scala b/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/LocalSparkSession.scala
deleted file mode 100644
index 261093001..000000000
--- a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/LocalSparkSession.scala
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.kyuubi.spark.connector.tpcds
-
-import org.apache.spark.sql.SparkSession
-
-object LocalSparkSession {
- def stop(spark: SparkSession): Unit = {
- if (spark != null) {
- spark.stop()
- }
- // To avoid RPC rebinding to the same port, since it doesn't unbind immediately on shutdown
- System.clearProperty("spark.driver.port")
- }
-
- /** Runs `f` by passing in `sc` and ensures that `sc` is stopped. */
- def withSparkSession[T](sc: SparkSession)(f: SparkSession => T): T = {
- try {
- f(sc)
- } finally {
- stop(sc)
- }
- }
-}
diff --git a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSCatalogSuite.scala b/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSCatalogSuite.scala
index a7f4c5738..3ecfeabb7 100644
--- a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSCatalogSuite.scala
+++ b/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSCatalogSuite.scala
@@ -22,7 +22,8 @@ import org.apache.spark.sql.{AnalysisException, SparkSession}
import org.apache.spark.sql.util.CaseInsensitiveStringMap
import org.apache.kyuubi.KyuubiFunSuite
-import org.apache.kyuubi.spark.connector.tpcds.LocalSparkSession.withSparkSession
+import org.apache.kyuubi.spark.connector.common.LocalSparkSession.withSparkSession
+import org.apache.kyuubi.spark.connector.common.SparkUtils
class TPCDSCatalogSuite extends KyuubiFunSuite {
diff --git a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSQuerySuite.scala b/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSQuerySuite.scala
index c3145b810..629ff01ed 100644
--- a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSQuerySuite.scala
+++ b/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSQuerySuite.scala
@@ -23,7 +23,7 @@ import org.apache.spark.SparkConf
import org.apache.spark.sql.SparkSession
import org.apache.kyuubi.KyuubiFunSuite
-import org.apache.kyuubi.spark.connector.tpcds.LocalSparkSession.withSparkSession
+import org.apache.kyuubi.spark.connector.common.LocalSparkSession.withSparkSession
class TPCDSQuerySuite extends KyuubiFunSuite {
diff --git a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTableSuite.scala b/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTableSuite.scala
index aaa6f1f42..ec384bfe1 100644
--- a/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTableSuite.scala
+++ b/extensions/spark/kyuubi-spark-connector-tpcds/src/test/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTableSuite.scala
@@ -23,7 +23,7 @@ import org.apache.spark.SparkConf
import org.apache.spark.sql.SparkSession
import org.apache.kyuubi.KyuubiFunSuite
-import org.apache.kyuubi.spark.connector.tpcds.LocalSparkSession.withSparkSession
+import org.apache.kyuubi.spark.connector.common.LocalSparkSession.withSparkSession
class TPCDSTableSuite extends KyuubiFunSuite {
diff --git a/extensions/spark/kyuubi-spark-connector-tpch/pom.xml b/extensions/spark/kyuubi-spark-connector-tpch/pom.xml
index a5c575c57..070d0f50d 100644
--- a/extensions/spark/kyuubi-spark-connector-tpch/pom.xml
+++ b/extensions/spark/kyuubi-spark-connector-tpch/pom.xml
@@ -33,6 +33,20 @@
<url>https://kyuubi.apache.org/</url>
<dependencies>
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-spark-connector-common_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.kyuubi</groupId>
+ <artifactId>kyuubi-spark-connector-common_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
@@ -162,6 +176,7 @@
<includes>
<include>io.trino.tpch:tpch</include>
<include>com.google.guava:guava</include>
+ <include>org.apache.kyuubi:kyuubi-spark-connector-common_${scala.binary.version}</include>
</includes>
</artifactSet>
<relocations>
diff --git a/extensions/spark/kyuubi-spark-connector-tpch/src/main/scala/org/apache/kyuubi/spark/connector/tpch/SparkUtils.scala b/extensions/spark/kyuubi-spark-connector-tpch/src/main/scala/org/apache/kyuubi/spark/connector/tpch/SparkUtils.scala
deleted file mode 100644
index 84b2835ba..000000000
--- a/extensions/spark/kyuubi-spark-connector-tpch/src/main/scala/org/apache/kyuubi/spark/connector/tpch/SparkUtils.scala
+++ /dev/null
@@ -1,78 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.kyuubi.spark.connector.tpch
-
-import org.apache.spark.SPARK_VERSION
-
-object SparkUtils {
-
- /**
- * Given a Kyuubi/Spark/Hive version string,
- * return the (major version number, minor version number).
- * E.g., for 2.0.1-SNAPSHOT, return (2, 0).
- */
- def majorMinorVersion(version: String): (Int, Int) = {
- """^(\d+)\.(\d+)(\..*)?$""".r.findFirstMatchIn(version) match {
- case Some(m) =>
- (m.group(1).toInt, m.group(2).toInt)
- case None =>
- throw new IllegalArgumentException(s"Tried to parse '$version' as a project" +
- s" version string, but it could not find the major and minor version numbers.")
- }
- }
-
- /**
- * Given a Kyuubi/Spark/Hive version string, return the major version number.
- * E.g., for 2.0.1-SNAPSHOT, return 2.
- */
- def majorVersion(version: String): Int = majorMinorVersion(version)._1
-
- /**
- * Given a Kyuubi/Spark/Hive version string, return the minor version number.
- * E.g., for 2.0.1-SNAPSHOT, return 0.
- */
- def minorVersion(version: String): Int = majorMinorVersion(version)._2
-
- def isSparkVersionAtMost(ver: String): Boolean = {
- val runtimeMajor = majorVersion(SPARK_VERSION)
- val targetMajor = majorVersion(ver)
- (runtimeMajor < targetMajor) || {
- val runtimeMinor = minorVersion(SPARK_VERSION)
- val targetMinor = minorVersion(ver)
- runtimeMajor == targetMajor && runtimeMinor <= targetMinor
- }
- }
-
- def isSparkVersionAtLeast(ver: String): Boolean = {
- val runtimeMajor = majorVersion(SPARK_VERSION)
- val targetMajor = majorVersion(ver)
- (runtimeMajor > targetMajor) || {
- val runtimeMinor = minorVersion(SPARK_VERSION)
- val targetMinor = minorVersion(ver)
- runtimeMajor == targetMajor && runtimeMinor >= targetMinor
- }
- }
-
- def isSparkVersionEqualTo(ver: String): Boolean = {
- val runtimeMajor = majorVersion(SPARK_VERSION)
- val targetMajor = majorVersion(ver)
- val runtimeMinor = minorVersion(SPARK_VERSION)
- val targetMinor = minorVersion(ver)
- runtimeMajor == targetMajor && runtimeMinor == targetMinor
- }
-}
diff --git a/extensions/spark/kyuubi-spark-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/TPCHCatalogSuite.scala b/extensions/spark/kyuubi-spark-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/TPCHCatalogSuite.scala
index 5b52480a5..730deab73 100644
--- a/extensions/spark/kyuubi-spark-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/TPCHCatalogSuite.scala
+++ b/extensions/spark/kyuubi-spark-connector-tpch/src/test/scala/org/apache/kyuubi/spark/connector/tpch/TPCHCatalogSuite.scala
@@ -21,6 +21,7 @@ import org.apache.spark.sql.{AnalysisException, SparkSession}
import org.apache.spark.sql.util.CaseInsensitiveStringMap
import org.apache.kyuubi.KyuubiFunSuite
+import org.apache.kyuubi.spark.connector.common.SparkUtils
class TPCHCatalogSuite extends KyuubiFunSuite {
diff --git a/pom.xml b/pom.xml
index 73666cc2e..73286779c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -68,6 +68,7 @@
<module>dev/kyuubi-codecov</module>
<module>extensions/server/kyuubi-server-plugin</module>
<module>extensions/spark/kyuubi-spark-authz</module>
+ <module>extensions/spark/kyuubi-spark-connector-common</module>
<module>extensions/spark/kyuubi-spark-connector-tpcds</module>
<module>extensions/spark/kyuubi-spark-connector-tpch</module>
<module>externals/kyuubi-download</module>