You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ColtenOuO (via GitHub)" <gi...@apache.org> on 2026/05/01 06:24:33 UTC
[PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
ColtenOuO opened a new pull request, #66193:
URL: https://github.com/apache/airflow/pull/66193
## Summary
Completes the SIM105 cleanup started in PR **#66178** by:
1. Replacing the remaining `try-except-pass` blocks with `contextlib.suppress(...)` across 8 files in `airflow-core/`, `task-sdk/`, and `dev/`.
2. Moving `"SIM105"` from `lint.ignore` back to `lint.extend-select` in [`pyproject.toml`](https://github.com/apache/airflow/blob/main/pyproject.toml).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
Posted by "ColtenOuO (via GitHub)" <gi...@apache.org>.
ColtenOuO commented on PR #66193:
URL: https://github.com/apache/airflow/pull/66193#issuecomment-4360533068
Done! — rebased on the latest main.
Since the providers split (#66178) merged, a new SIM105 violation landed on `main` in `providers/mongo/tests/conftest.py` (introduced by #66154). I included its fix in this PR.
`ruff check --select SIM105 .` → All checks passed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66193:
URL: https://github.com/apache/airflow/pull/66193#issuecomment-4363541545
### Backport failed to create: v3-2-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/25249328472'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/commit/251fe925b5484fe6ff11e6b6de46ef8099c320c9"><img src='https://img.shields.io/badge/Commit-251fe92-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 251fe92 v3-2-test
```
This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
Posted by "ColtenOuO (via GitHub)" <gi...@apache.org>.
ColtenOuO commented on PR #66193:
URL: https://github.com/apache/airflow/pull/66193#issuecomment-4359706057
Awesome! Thanks for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
Posted by "ColtenOuO (via GitHub)" <gi...@apache.org>.
ColtenOuO commented on PR #66193:
URL: https://github.com/apache/airflow/pull/66193#issuecomment-4358144928
This PR depends on #66178, I'll mark this PR as Draft until #66178 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #66193:
URL: https://github.com/apache/airflow/pull/66193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #66193:
URL: https://github.com/apache/airflow/pull/66193#issuecomment-4359767208
> Awesome! Thanks for your help! I've changed this PR back to Open.
Oh, but there is now a conflict with pyproject.toml. Bas you merge/rebase this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use contextlib.suppress instead of try-except-pass and re-enable SIM105 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #66193:
URL: https://github.com/apache/airflow/pull/66193#issuecomment-4358601279
Cool! Other PR is merged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org