You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/06/16 20:49:26 UTC
[GitHub] [yunikorn-core] pbacsko opened a new pull request, #572: [YUNIKORN-1816] Fixed placement rule no longer works due to incorrect validation
pbacsko opened a new pull request, #572:
URL: https://github.com/apache/yunikorn-core/pull/572
### What is this PR for?
Valid "fixed" placement rule definitions are now rejected because a bug in the validator logic.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1816
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko closed pull request #572: [YUNIKORN-1816] Fixed placement rule no longer works due to incorrect validation
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #572: [YUNIKORN-1816] Fixed placement rule no longer works due to incorrect validation
URL: https://github.com/apache/yunikorn-core/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #572: [YUNIKORN-1816] Fixed placement rule no longer works due to incorrect validation
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #572:
URL: https://github.com/apache/yunikorn-core/pull/572#issuecomment-1595374202
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/572?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#572](https://app.codecov.io/gh/apache/yunikorn-core/pull/572?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0cad0c3) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/a6a90bb0408a3004592f06d8a79335ac326dcfe4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a6a90bb) will **decrease** coverage by `0.11%`.
> The diff coverage is `72.15%`.
```diff
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 75.45% 75.35% -0.11%
==========================================
Files 73 73
Lines 12057 12101 +44
==========================================
+ Hits 9098 9119 +21
- Misses 2638 2656 +18
- Partials 321 326 +5
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/572?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/common/configs/configvalidator.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/572?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `87.03% <72.15%> (-2.76%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/572/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko commented on pull request #572: [YUNIKORN-1816] Fixed placement rule no longer works due to incorrect validation
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #572:
URL: https://github.com/apache/yunikorn-core/pull/572#issuecomment-1597360684
Note: the validation logic got more complicated, simply because we missed numerous cases when the original code was merged. I added comments to clarify things, but if there are questions, let's discuss them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org