You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/01/13 10:43:01 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4975:
Adding pinot-batch-ingestion-spark module
fx19880617 opened a new pull request #4975: Adding pinot-batch-ingestion-spark module
URL: https://github.com/apache/incubator-pinot/pull/4975
1. refactor common code to `pinot-batch-ingestion-common` module.
2. adding pinot-batch-ingestion-spark module to build segment and push under spark environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on a change in pull request
#4975: Adding pinot-batch-ingestion-spark module
Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4975: Adding pinot-batch-ingestion-spark module
URL: https://github.com/apache/incubator-pinot/pull/4975#discussion_r366034956
##########
File path: pinot-distribution/pinot-assembly.xml
##########
@@ -114,6 +114,7 @@
<exclude>**/pinot-stream-ingestion/pinot-stream-ingestion/**</exclude>
<exclude>**/pinot-stream-ingestion/pinot-kafka-*/**</exclude>
<exclude>**/pinot-batch-ingestion/pinot-batch-ingestion/**</exclude>
+ <exclude>**/pinot-batch-ingestion/pinot-batch-ingestion-common/**</exclude>
<exclude>**/pinot-batch-ingestion/pinot-ingestion-common/**</exclude>
Review comment:
please check the path here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on a change in pull request
#4975: Adding pinot-batch-ingestion-spark module
Posted by GitBox <gi...@apache.org>.
kishoreg commented on a change in pull request #4975: Adding pinot-batch-ingestion-spark module
URL: https://github.com/apache/incubator-pinot/pull/4975#discussion_r366035100
##########
File path: pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/pom.xml
##########
@@ -0,0 +1,88 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>pinot-batch-ingestion</artifactId>
+ <groupId>org.apache.pinot</groupId>
+ <version>0.3.0-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>pinot-batch-ingestion-common</artifactId>
+ <name>Pinot Batch Ingestion Common</name>
+ <url>https://pinot.apache.org/</url>
+ <properties>
+ <pinot.root>${basedir}/../../..</pinot.root>
+ </properties>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-spi</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
Review comment:
this should be provided?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4975:
Adding pinot-batch-ingestion-spark module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4975: Adding pinot-batch-ingestion-spark module
URL: https://github.com/apache/incubator-pinot/pull/4975#issuecomment-573973429
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=h1) Report
> Merging [#4975](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/a0fd481489ce8272bc59f8f02793be214d40dc63?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `1.06%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4975 +/- ##
============================================
+ Coverage 57.35% 57.37% +0.02%
Complexity 12 12
============================================
Files 1174 1176 +2
Lines 62246 62381 +135
Branches 9148 9167 +19
============================================
+ Hits 35703 35793 +90
- Misses 23876 23918 +42
- Partials 2667 2670 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/pinot/spi/ingestion/batch/spec/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...inot/spi/ingestion/batch/IngestionJobLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL0luZ2VzdGlvbkpvYkxhdW5jaGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...s/admin/command/LaunchDataIngestionJobCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvTGF1bmNoRGF0YUluZ2VzdGlvbkpvYkNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/spi/ingestion/batch/spec/PushJobSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvUHVzaEpvYlNwZWMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...not/spi/ingestion/batch/spec/RecordReaderSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvUmVjb3JkUmVhZGVyU3BlYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ingestion/batch/spec/SegmentNameGeneratorSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvU2VnbWVudE5hbWVHZW5lcmF0b3JTcGVjLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...i/ingestion/batch/spec/ExecutionFrameworkSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvRXhlY3V0aW9uRnJhbWV3b3JrU3BlYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...tion/batch/common/SegmentGenerationTaskRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vcGlub3QtYmF0Y2gtaW5nZXN0aW9uLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2luZ2VzdGlvbi9iYXRjaC9jb21tb24vU2VnbWVudEdlbmVyYXRpb25UYXNrUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ngestion/batch/spec/SegmentGenerationTaskSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvU2VnbWVudEdlbmVyYXRpb25UYXNrU3BlYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| ... and [39 more](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=footer). Last update [a0fd481...232cd13](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #4975: Adding
pinot-batch-ingestion-spark module
Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #4975: Adding pinot-batch-ingestion-spark module
URL: https://github.com/apache/incubator-pinot/pull/4975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #4975: Adding
pinot-batch-ingestion-spark module
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4975: Adding pinot-batch-ingestion-spark module
URL: https://github.com/apache/incubator-pinot/pull/4975#issuecomment-573973429
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=h1) Report
> Merging [#4975](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/37886c4c135a276f0fd9b266348b7bab82198b79?src=pr&el=desc) will **increase** coverage by `20.91%`.
> The diff coverage is `1.06%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4975 +/- ##
============================================
+ Coverage 36.29% 57.2% +20.91%
- Complexity 0 12 +12
============================================
Files 1174 1176 +2
Lines 62244 62379 +135
Branches 9148 9167 +19
============================================
+ Hits 22592 35686 +13094
+ Misses 37617 24021 -13596
- Partials 2035 2672 +637
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/pinot/spi/ingestion/batch/spec/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...inot/spi/ingestion/batch/IngestionJobLauncher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL0luZ2VzdGlvbkpvYkxhdW5jaGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...he/pinot/tools/admin/command/QuickstartRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvUXVpY2tzdGFydFJ1bm5lci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...s/admin/command/LaunchDataIngestionJobCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvTGF1bmNoRGF0YUluZ2VzdGlvbkpvYkNvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/spi/ingestion/batch/spec/PushJobSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvUHVzaEpvYlNwZWMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...not/spi/ingestion/batch/spec/RecordReaderSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvUmVjb3JkUmVhZGVyU3BlYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ingestion/batch/spec/SegmentNameGeneratorSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvU2VnbWVudE5hbWVHZW5lcmF0b3JTcGVjLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...i/ingestion/batch/spec/ExecutionFrameworkSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvRXhlY3V0aW9uRnJhbWV3b3JrU3BlYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...tion/batch/common/SegmentGenerationTaskRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vcGlub3QtYmF0Y2gtaW5nZXN0aW9uLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2luZ2VzdGlvbi9iYXRjaC9jb21tb24vU2VnbWVudEdlbmVyYXRpb25UYXNrUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ngestion/batch/spec/SegmentGenerationTaskSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvaW5nZXN0aW9uL2JhdGNoL3NwZWMvU2VnbWVudEdlbmVyYXRpb25UYXNrU3BlYy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| ... and [602 more](https://codecov.io/gh/apache/incubator-pinot/pull/4975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=footer). Last update [37886c4...389ce7b](https://codecov.io/gh/apache/incubator-pinot/pull/4975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org