You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/15 01:26:52 UTC

[GitHub] [kafka] satishd commented on a diff in pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration

satishd commented on code in PR #12989:
URL: https://github.com/apache/kafka/pull/12989#discussion_r1049118373


##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -75,16 +75,16 @@ public class TopicConfig {
         "\"delete\" retention policy. This represents an SLA on how soon consumers must read " +
         "their data. If set to -1, no time limit is applied.";
 
-    public static final String REMOTE_LOG_STORAGE_ENABLE_CONFIG = "remote.storage.enable";
+    public static final String REMOTE_LOG_STORAGE_ENABLE_CONFIG = "remote.log.storage.enable";

Review Comment:
   Topic configurations do not include "log". That is why we decided not to have for the newly introduced configs. Same for other configs mentioned in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org