[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #3677: Support materialized view load and insert

[GitBox <gi...@apache.org>]

HangyuanLiu commented on a change in pull request #3677:
URL: https://github.com/apache/incubator-doris/pull/3677#discussion_r438517645



##########
File path: fe/src/main/java/org/apache/doris/load/Load.java
##########
@@ -1013,6 +1013,13 @@ public static void initColumns(Table tbl, List<ImportColumnDesc> columnExprs,
                 slotDescByName.put(realColName, slotDesc);
             }
         }
+        // The extension column of the materialized view is added to the expression evaluation of load
+        for (Column column : tbl.getFullSchema()) {
+            if (column.getDefineExpr() != null) {

Review comment:
       > Are you sure that this is correct`column(a, tmp_c) set(b=f(c), c=b)`？
   
   Fix done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org