You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/25 07:26:31 UTC
[GitHub] [spark] sungpeo opened a new pull request #33830: SPARK-36582 Spark HistoryPage show 'NotFound' in not logged multiple …
sungpeo opened a new pull request #33830:
URL: https://github.com/apache/spark/pull/33830
…attempts
attemptId should be always, so deleted hasMultipleAttempts
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
attemptId should be always, so deleted hasMultipleAttempts
described in https://issues.apache.org/jira/browse/SPARK-36582
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-906129982
@sungpeo According to the issue description, the root cause seems that applications can fail to log to the history. Should we rather fix the root cause?
```
But, applications in yarn could be failed even not logged to spark application history.
```
Also, does this issue happens only with YARN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-906129982
@sungpeo According to the issue description, the root cause seems that applications can be failed to logged to the history. Should we rather fix the root cause?
```
But, applications in yarn could be failed even not logged to spark application history.
```
Also, does this issue happens only with YARN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-906129982
@sungpeo According to the issue description, the root cause seems that applications can fail to log to the history. Should we rather fix the root cause?
```
But, applications in yarn could be failed even not logged to spark application history.
```
Also, does this issue happen only with YARN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sungpeo commented on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-906234027
@sarutak
In this case (with YARN), yarn application(=spark driver in cluster mode) couldn't initiate at all due to YARN's failure. Naturally, the application could not write logs.
I don't know how spark handle the other framework's attempt process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33830: SPARK-36582 Spark HistoryPage show 'NotFound' in not logged multiple …
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-905976797
cc @sarutak and @gengliangwang FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-905977294
@sungpeo mind describing "Does this PR introduce any user-facing change?" and "How was this patch tested?"? it should have a screenshot if it fixes UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-913278879
@sungpeo I tried running a test app which the driver succeeds at the second attempt (the first attempt will fail), and watched the appliation list with HistoryServer but I couldn't reproduce this issue.
Does this issue still happen with the latest `master` on your environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-995315732
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33830:
URL: https://github.com/apache/spark/pull/33830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sungpeo commented on pull request #33830: [SPARK-36582][UI] Spark HistoryPage show 'NotFound' in not logged multiple attempts
Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-905984832
@HyukjinKwon
I changed the first comment to add what you commented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33830: SPARK-36582 Spark HistoryPage show 'NotFound' in not logged multiple …
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33830:
URL: https://github.com/apache/spark/pull/33830#issuecomment-905267884
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org