[GitHub] [doris] zhangstar333 commented on a diff in pull request #16033: [fix](jdbc) fix jdbc driver bug and external datasource p2 test case issue

[GitBox <gi...@apache.org>]

zhangstar333 commented on code in PR #16033:
URL: https://github.com/apache/doris/pull/16033#discussion_r1073016535


##########
fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java:
##########
@@ -248,9 +248,11 @@ private void init(String driverUrl, String sql, int batchSize, String driverClas
 
             dataSource = new HikariDataSource(config);
             conn = dataSource.getConnection();
+            conn.setAutoCommit(false);
             if (op == TJdbcOperation.READ) {

Review Comment:
   should set it to false only the op==READ



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org