You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mice xia <mi...@tcloudcomputing.com> on 2012/07/27 08:43:26 UTC
Review Request: Fix bug: attaching data volumes failed with NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6172/
-----------------------------------------------------------
Review request for cloudstack and Chiradeep Vittal.
Description
-------
_volumeHostDao in UserVmManagerImpl is not instantiated, which leads to NPE
-changes in UserVmManagerImpl
add @Inject annotation to _volumeHostDao
Diffs
-----
server/src/com/cloud/vm/UserVmManagerImpl.java 649e215
Diff: https://reviews.apache.org/r/6172/diff/
Testing
-------
attach and detach volumes successfully
Thanks,
mice xia
Re: Review Request: Fix bug: attaching data volumes failed with NPE
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6172/#review9544
-----------------------------------------------------------
Ship it!
- Chiradeep Vittal
On July 27, 2012, 6:43 a.m., mice xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6172/
> -----------------------------------------------------------
>
> (Updated July 27, 2012, 6:43 a.m.)
>
>
> Review request for cloudstack and Chiradeep Vittal.
>
>
> Description
> -------
>
> _volumeHostDao in UserVmManagerImpl is not instantiated, which leads to NPE
>
> -changes in UserVmManagerImpl
> add @Inject annotation to _volumeHostDao
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/UserVmManagerImpl.java 649e215
>
> Diff: https://reviews.apache.org/r/6172/diff/
>
>
> Testing
> -------
>
> attach and detach volumes successfully
>
>
> Thanks,
>
> mice xia
>
>