You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2014/10/12 02:44:06 UTC
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
GitHub user grkvlt opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/237
Change references to org.apache.brooklyn for Maven groupId
Should be merged once the _org.apache.brooklyn_ artifacts are available on the OSS Sonatype Nexus server:
- https://oss.sonatype.org/#nexus-search;quick~org.apache.brooklyn
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/incubator-brooklyn fix/org-apache-brooklyn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #237
----
commit 415a4317b1f3036bcd0add4bb9fd6832fc246568
Author: Andrew Kennedy <gr...@apache.org>
Date: 2014-10-12T00:32:48Z
Change references to org.apache.brooklyn for Maven groupId
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/237#issuecomment-59004266
Closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/237#discussion_r18778373
--- Diff: software/base/src/test/java/brooklyn/entity/brooklynnode/BrooklynNodeTest.java ---
@@ -58,8 +58,8 @@ public void tearDown() throws Exception {
@Test
public void testGeneratesCorrectSnapshotDownload() throws Exception {
- String version = "0.6.0-SNAPSHOT";
- String expectedUrl = "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=io.brooklyn&v="+version+"&a=brooklyn-dist&c=dist&e=tar.gz";
+ String version = "0.7.0-SNAPSHOT"; // BROOKLYN_VERSION
--- End diff --
Again, this is the wrong URL for `org.apache.brooklyn` snapshot artifacts (I'm guessing).
There is also a chicken-and-egg problem. When we next bump the version number to 0.8.0-SNAPSHOT, then this artifact will not be in apache nexus (or sonatype) so the test will fail. The version would (by default) not be pushed until all tests pass. So it would require manual intervention to fix. Should we just live with that? If so, we should note it in the release process docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/237#issuecomment-59004229
Yes, that's why I didn't merge it, I wasn't sure about the changeover to the Apache SNAPSHOT repository. @richardcloudsoft explained it nicely on the list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/237#discussion_r18778253
--- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNode.java ---
@@ -73,7 +73,7 @@
BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new StringAttributeSensorAndConfigKey(
SoftwareProcess.DOWNLOAD_URL,
"<#if version?contains(\"SNAPSHOT\")>"+
- "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=io.brooklyn&v=${version}&a=brooklyn-dist&c=dist&e=tar.gz" +
+ "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.brooklyn&v=${version}&a=brooklyn-dist&c=dist&e=tar.gz" +
--- End diff --
I don't think we'll be pushing `org.apache.brooklyn` to sonatype - I presume we'll push it to the apache nexus. @richardcloudsoft any thoughts on that, and what will the URL look of artifacts look like?
Also, if we wanted to support installing older versions then we'd need a conditional on the URL.
But I'm fine with it only supporting the more recent 0.7.0 and higher.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/237#discussion_r18778402
--- Diff: usage/dist/src/main/dist/conf/catalog.xml ---
@@ -28,10 +28,10 @@
<description>Deploys a demonstration web application to JBoss clusters around the world</description>
<iconUrl>http://releng3.cloudsoftcorp.com/downloads/brooklyn/img/JBoss_by_Red_Hat.png</iconUrl>
</template>
-
+
<classpath>
- <entry>https://oss.sonatype.org/service/local/artifact/maven/redirect?r=releases&g=io.brooklyn.example&a=brooklyn-example-simple-web-cluster&v=0.7.0-SNAPSHOT&e=jar</entry> <!-- BROOKLYN_VERSION -->
- <entry>https://oss.sonatype.org/service/local/artifact/maven/redirect?r=releases&g=io.brooklyn.example&a=brooklyn-example-global-web-fabric&v=0.7.0-SNAPSHOT&e=jar</entry> <!-- BROOKLYN_VERSION -->
+ <entry>https://oss.sonatype.org/service/local/artifact/maven/redirect?r=releases&g=org.apache.brooklyn.example&a=brooklyn-example-simple-web-cluster&v=0.7.0-SNAPSHOT&e=jar</entry> <!-- BROOKLYN_VERSION -->
--- End diff --
Again, will these be in apache nexus rather than sonatype URLs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Change references to org.apache.b...
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/237#discussion_r18778411
--- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNode.java ---
@@ -73,7 +73,7 @@
BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new StringAttributeSensorAndConfigKey(
SoftwareProcess.DOWNLOAD_URL,
"<#if version?contains(\"SNAPSHOT\")>"+
- "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=io.brooklyn&v=${version}&a=brooklyn-dist&c=dist&e=tar.gz" +
+ "https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.brooklyn&v=${version}&a=brooklyn-dist&c=dist&e=tar.gz" +
--- End diff --
Yes, we should switch over to Apache infrastructure for SNAPSHOT publishing now (the old group IDs were a blocker for that task) - I'll investigate setting that up. Once up and running, the new URL will be under https://repository.apache.org/content/repositories/snapshots/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---