You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ramanathan Muthaiah <ru...@gmail.com> on 2006/12/17 11:44:05 UTC
Fwd: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Re-sending again. . .
/Ram
---------- Forwarded message ----------
From: Ramanathan Muthaiah <ru...@gmail.com>
Date: Dec 11, 2006 1:39 PM
Subject: Fwd: [PATCH] : New Feature "search" in Subversion FAQ Page
To: dev@subversion.tigris.org
Trying my luck second time. . .
/Ram
---------- Forwarded message ----------
From: Ramanathan Muthaiah <ru...@gmail.com>
Date: Dec 6, 2006 8:20 PM
Subject: Fwd: [PATCH] : New Feature "search" in FAQ Page
To: dev@subversion.tigris.org
Re-sending as the previous post did not evoke any response.
/Ram
---------- Forwarded message ----------
From: Ramanathan Muthaiah <ru...@gmail.com>
Date: Dec 1, 2006 1:49 AM
Subject: [PATCH] : New Feature "search" in FAQ Page
To: dev@subversion.tigris.org
As discussed in this thread,
http://svn.haxx.se/dev/archive-2006-11/0230.shtml
am providing the patch for this feature in the Subversion's FAQ page.
[[[
New search feature in the Subversion's FAQ page to enable search of
the entire Subversion site or WWW
www/faq.html
This is a new feature that provides the options to search. With this
patch, the search window is enabled and is visible at the top of the
web page (in http://subversion.tigris.org/faq.html)
This patch provides two search options.
First option, to search the entrie http://subversion.tigris.org
Second option, to search the WWW
Both the searches, display the search results in the same browser window.
Suggested by: Benjamin A. Okopnik
Francis Daly
Kapil Hari Paranjape
Samuel Kotel Bisbee-vonKaufmann
]]]
I have tested the changes in my local copy and it seems ok (except
that the search is aligned to left and not centered).
Output from "svn diff" is in the attached file and is also shown below
for reference.
===================================================================
--- www/faq.html (revision 22482)
+++ www/faq.html (working copy)
@@ -20,6 +20,39 @@
<![CDATA[=========================================================]]>
+<!-- SiteSearch Google -->
+<form method="get" action="http://www.google.com/custom" target="_top">
+
+<table border="0" bgcolor="#ffffff">
+<tr><td nowrap="nowrap" valign="top" align="left" height="32">
+<a href="http://www.google.com/">
+
+<img src="http://www.google.com/logos/Logo_25wht.gif" border="0"
alt="Google"></a>
+</td>
+<td nowrap="nowrap">
+<input type="hidden" name="domains" value="http://subversion.tigris.org">
+<input type="text" name="q" size="31" maxlength="255" value="">
+<input type="submit" name="sa" value="Search">
+</td></tr>
+<tr>
+ <td> </td>
+<td nowrap="nowrap">
+<table>
+<tr>
+<td>
+<input type="radio" name="sitesearch" value="">
+<font size="+1" color="#000000">WWW</font>
+</td>
+<td>
+<input type="radio" name="sitesearch"
value="http://subversion.tigris.org" checked="checked">
+<font size="+1" color="#000000">subversion.tigris.org</font>
+</td>
+</tr>
+</table>
+</td></tr></table>
+</form>
+<!-- SiteSearch Google -->
+</td></tr></table>
<div class="h2"><!-- no 'id' or 'title' attribute for TOC -->
<h2>Table of Contents</h2>
===================================================================
/Ram
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Posted by Ramanathan Muthaiah <ru...@gmail.com>.
> People can just use their regular page-search feature in their browser,
> our FAQ works well with that. I don't think I see a reason to apply this
> patch, but perhaps I missed some point in an earlier discussion
> (Ramanathan, please let me know if so).
Karl,
Please, you may ignore the submitted patch.
/Ram
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Posted by Karl Fogel <kf...@red-bean.com>.
On 1/16/07, Hyrum K. Wright <hy...@mail.utexas.edu> wrote:
> Ramanathan Muthaiah wrote:
> > Maybe the holidays' are overshadowing my PATCH mail :--))
> >
> > Trying re-send to DEV list. . .
>
> Any comments on this? I'll file an issue if nothing becomes of it in
> the next few days.
People can just use their regular page-search feature in their browser,
our FAQ works well with that. I don't think I see a reason to apply this
patch, but perhaps I missed some point in an earlier discussion
(Ramanathan, please let me know if so).
-Karl
> > On 12/20/06, Ramanathan Muthaiah <ru...@gmail.com> wrote:
> >> Hi Erik,
> >>
> >> Am submitting changes as per your previous e-mail.
> >>
> >> > Here is the patch to revert the changes that was part of my earlier
> >> > patch and inlieu this shall add a simple NOTE at the top of the
> >> > Subversion's FAQ page about the serach option in the side-bar.
> >> >
> >> > I verified the changes in my local browsers and found it to be
> >> working fine.
> >> >
> >> > Output of "svn diff . . ." follows (same is given in the attachment
> >> as well):
> >> >
> >> > Index: /home/ram/svn_faq/www/faq.html
> >> > ===================================================================
> >> > --- /home/ram/svn_faq/www/faq.html (revision 22482)
> >> > +++ /home/ram/svn_faq/www/faq.html (working copy)
> >> > @@ -16,10 +16,14 @@
> >> > <body>
> >> > <div class="app">
> >> >
> >> > +
> >> > <h1>Subversion FAQ</h1>
> >> >
> >> > +<h2><center> NOTE : Use the <em>search option in the side-bar</em> to
> >> > do quick search </center></h2>
> >> > +
> >> > <![CDATA[=========================================================]]>
> >> >
> >> > +
> >> > <div class="h2"><!-- no 'id' or 'title' attribute for TOC -->
> >> > <h2>Table of Contents</h2>
> >> >
> >> > =============================================
> >>
> >> /Ram
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Posted by Daniel Rall <dl...@collab.net>.
I personally never saw much value in this, and still don't.
On Tue, 16 Jan 2007, Hyrum K. Wright wrote:
> Ramanathan Muthaiah wrote:
> > Maybe the holidays' are overshadowing my PATCH mail :--))
> >
> > Trying re-send to DEV list. . .
>
> Any comments on this? I'll file an issue if nothing becomes of it in
> the next few days.
>
> -Hyrum
>
> > On 12/20/06, Ramanathan Muthaiah <ru...@gmail.com> wrote:
> >> Hi Erik,
> >>
> >> Am submitting changes as per your previous e-mail.
> >>
> >> > Here is the patch to revert the changes that was part of my earlier
> >> > patch and inlieu this shall add a simple NOTE at the top of the
> >> > Subversion's FAQ page about the serach option in the side-bar.
> >> >
> >> > I verified the changes in my local browsers and found it to be
> >> working fine.
> >> >
> >> > Output of "svn diff . . ." follows (same is given in the attachment
> >> as well):
> >> >
> >> > Index: /home/ram/svn_faq/www/faq.html
> >> > ===================================================================
> >> > --- /home/ram/svn_faq/www/faq.html (revision 22482)
> >> > +++ /home/ram/svn_faq/www/faq.html (working copy)
> >> > @@ -16,10 +16,14 @@
> >> > <body>
> >> > <div class="app">
> >> >
> >> > +
> >> > <h1>Subversion FAQ</h1>
> >> >
> >> > +<h2><center> NOTE : Use the <em>search option in the side-bar</em> to
> >> > do quick search </center></h2>
> >> > +
> >> > <![CDATA[=========================================================]]>
> >> >
> >> > +
> >> > <div class="h2"><!-- no 'id' or 'title' attribute for TOC -->
> >> > <h2>Table of Contents</h2>
> >> >
> >> > =============================================
> >>
> >> /Ram
>
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ
Page
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Ramanathan Muthaiah wrote:
> Maybe the holidays' are overshadowing my PATCH mail :--))
>
> Trying re-send to DEV list. . .
Any comments on this? I'll file an issue if nothing becomes of it in
the next few days.
-Hyrum
> On 12/20/06, Ramanathan Muthaiah <ru...@gmail.com> wrote:
>> Hi Erik,
>>
>> Am submitting changes as per your previous e-mail.
>>
>> > Here is the patch to revert the changes that was part of my earlier
>> > patch and inlieu this shall add a simple NOTE at the top of the
>> > Subversion's FAQ page about the serach option in the side-bar.
>> >
>> > I verified the changes in my local browsers and found it to be
>> working fine.
>> >
>> > Output of "svn diff . . ." follows (same is given in the attachment
>> as well):
>> >
>> > Index: /home/ram/svn_faq/www/faq.html
>> > ===================================================================
>> > --- /home/ram/svn_faq/www/faq.html (revision 22482)
>> > +++ /home/ram/svn_faq/www/faq.html (working copy)
>> > @@ -16,10 +16,14 @@
>> > <body>
>> > <div class="app">
>> >
>> > +
>> > <h1>Subversion FAQ</h1>
>> >
>> > +<h2><center> NOTE : Use the <em>search option in the side-bar</em> to
>> > do quick search </center></h2>
>> > +
>> > <![CDATA[=========================================================]]>
>> >
>> > +
>> > <div class="h2"><!-- no 'id' or 'title' attribute for TOC -->
>> > <h2>Table of Contents</h2>
>> >
>> > =============================================
>>
>> /Ram
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Posted by Ramanathan Muthaiah <ru...@gmail.com>.
Maybe the holidays' are overshadowing my PATCH mail :--))
Trying re-send to DEV list. . .
/Ram
On 12/20/06, Ramanathan Muthaiah <ru...@gmail.com> wrote:
> Hi Erik,
>
> Am submitting changes as per your previous e-mail.
>
> > Here is the patch to revert the changes that was part of my earlier
> > patch and inlieu this shall add a simple NOTE at the top of the
> > Subversion's FAQ page about the serach option in the side-bar.
> >
> > I verified the changes in my local browsers and found it to be working fine.
> >
> > Output of "svn diff . . ." follows (same is given in the attachment as well):
> >
> > Index: /home/ram/svn_faq/www/faq.html
> > ===================================================================
> > --- /home/ram/svn_faq/www/faq.html (revision 22482)
> > +++ /home/ram/svn_faq/www/faq.html (working copy)
> > @@ -16,10 +16,14 @@
> > <body>
> > <div class="app">
> >
> > +
> > <h1>Subversion FAQ</h1>
> >
> > +<h2><center> NOTE : Use the <em>search option in the side-bar</em> to
> > do quick search </center></h2>
> > +
> > <![CDATA[=========================================================]]>
> >
> > +
> > <div class="h2"><!-- no 'id' or 'title' attribute for TOC -->
> > <h2>Table of Contents</h2>
> >
> > =============================================
>
> /Ram
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Posted by Ramanathan Muthaiah <ru...@gmail.com>.
Hi Erik,
Am submitting changes as per your previous e-mail.
> Here is the patch to revert the changes that was part of my earlier
> patch and inlieu this shall add a simple NOTE at the top of the
> Subversion's FAQ page about the serach option in the side-bar.
>
> I verified the changes in my local browsers and found it to be working fine.
>
> Output of "svn diff . . ." follows (same is given in the attachment as well):
>
> Index: /home/ram/svn_faq/www/faq.html
> ===================================================================
> --- /home/ram/svn_faq/www/faq.html (revision 22482)
> +++ /home/ram/svn_faq/www/faq.html (working copy)
> @@ -16,10 +16,14 @@
> <body>
> <div class="app">
>
> +
> <h1>Subversion FAQ</h1>
>
> +<h2><center> NOTE : Use the <em>search option in the side-bar</em> to
> do quick search </center></h2>
> +
> <![CDATA[=========================================================]]>
>
> +
> <div class="h2"><!-- no 'id' or 'title' attribute for TOC -->
> <h2>Table of Contents</h2>
>
> =============================================
/Ram
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Posted by Ramanathan Muthaiah <ru...@gmail.com>.
> > Re-sending again. . .
> >
> > /Ram
>
> Thanks! Committed as r22736. (The webpage will lag, but update automatically.)
Here is the patch to revert the changes that was part of my earlier
patch and inlieu this shall add a simple NOTE at the top of the
Subversion's FAQ page about the serach option in the side-bar.
I verified the changes in my local browsers and found it to be working fine.
Output of "svn diff . . ." follows (same is given in the attachment as well):
Index: /home/ram/svn_faq/www/faq.html
===================================================================
--- /home/ram/svn_faq/www/faq.html (revision 22482)
+++ /home/ram/svn_faq/www/faq.html (working copy)
@@ -16,10 +16,14 @@
<body>
<div class="app">
+
<h1>Subversion FAQ</h1>
+<h2><center> NOTE : Use the <em>search option in the side-bar</em> to
do quick search </center></h2>
+
<![CDATA[=========================================================]]>
+
<div class="h2"><!-- no 'id' or 'title' attribute for TOC -->
<h2>Table of Contents</h2>
=============================================
/Ram
Re: [PATCH] : Proposal for New Feature "search" in Subversion FAQ Page
Posted by Erik Huelsmann <eh...@gmail.com>.
On 12/17/06, Ramanathan Muthaiah <ru...@gmail.com> wrote:
> Re-sending again. . .
>
> /Ram
Thanks! Committed as r22736. (The webpage will lag, but update automatically.)
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org