You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "jongyoul (via GitHub)" <gi...@apache.org> on 2025/10/04 04:22:32 UTC
[PR] [ZEPPELIN-6345] Merge zeppelin-zengine to zeppelin-server [zeppelin]
jongyoul opened a new pull request, #5095:
URL: https://github.com/apache/zeppelin/pull/5095
### What is this PR for?
This PR merges the `zeppelin-zengine` module into `zeppelin-server` to simplify the project architecture. The zengine module contained core engine functionality for notebook management, paragraph execution, and interpreter management, which is tightly coupled with the server. This merge reduces build complexity while preserving all git history using `git mv` for file movements.
### What type of PR is it?
Refactoring
### Todos
* [x] Move all source files from zeppelin-zengine to zeppelin-server using git mv (183 files)
* [x] Merge zengine dependencies into zeppelin-server pom.xml
* [x] Update zeppelin-plugins to depend on zeppelin-server instead of zeppelin-zengine
* [x] Update zeppelin-interpreter-integration dependencies
* [x] Update zeppelin-integration dependencies
* [x] Remove zeppelin-zengine module from root pom.xml
* [x] Update GitHub Actions workflows
* [x] Remove zeppelin-zengine directory
* [X] Verify full build succeeds: `./mvnw clean package`
### What is the Jira issue?
* ZEPPELIN-6345
### How should this be tested?
* CI
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3404328839
How about switching to the unshaded `ZeppelinConfiguration` as in [this commit](https://github.com/tbonelee/zeppelin/commit/5cf4d99be919127ca11336ecdb9b8ef45550e089)? (`2.` from my previous comment.) Maybe `rawString` fixes some cases, but by skipping required shaded classes it creates new issues.
It seems to fix all the failing jobs(), though I'd prefere a more explicit fix if possible.
(Failed E2E test was fixed in other PR)
<img width="284" height="158" alt="image" src="https://github.com/user-attachments/assets/8591cd92-d1e3-4f87-a281-72eaa3949d90" />
<img width="289" height="412" alt="image" src="https://github.com/user-attachments/assets/49b44e8d-e9a2-408b-981e-395455a3d4c5" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "seung-00 (via GitHub)" <gi...@apache.org>.
seung-00 commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3703775806
@jongyoul
Hi, It seems this PR has been inactive for some time. If you’re okay with it, I’d be happy to take over and continue the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3372358963
There are still some references to `zeppelin-zengine` left in the shell scripts under `/bin`.
(e.g., https://github.com/jongyoul/zeppelin/blob/5cc2196bf7afc172cf6f9f7d7cc5f64f9f70b31b/bin/interpreter.sh#L115)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on code in PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#discussion_r2417028467
##########
zeppelin-server/pom.xml:
##########
@@ -50,50 +55,176 @@
<dependencies>
+ <!-- Dependencies from merged zeppelin-zengine module -->
<dependency>
<groupId>${project.groupId}</groupId>
- <artifactId>zeppelin-zengine</artifactId>
+ <artifactId>zeppelin-common</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>zeppelin-interpreter</artifactId>
<version>${project.version}</version>
<exclusions>
<exclusion>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-core</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-json</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-server</artifactId>
+ <groupId>javax.inject</groupId>
+ <artifactId>javax.inject</artifactId>
</exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>zeppelin-jupyter</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
<exclusion>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
</exclusion>
- <!-- using jcl-over-slf4j instead -->
<exclusion>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
+ <groupId>org.jsoup</groupId>
+ <artifactId>jsoup</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>jakarta.inject</groupId>
+ <artifactId>jakarta.inject-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>commons-cli</groupId>
+ <artifactId>commons-cli</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-vfs2-jackrabbit1</artifactId>
+ <version>${commons.vfs2.version}</version>
Review Comment:
Thank you for pointing out. I'll handle it soon. Moreover, we have an issue related to logging library and I will solve it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on code in PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#discussion_r2416218280
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/display/AngularObjectBuilder.java:
##########
@@ -1,26 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.zeppelin.display;
-
-public class AngularObjectBuilder {
Review Comment:
Looks like the class was duplicated in the both modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "f-lab-lyan (via GitHub)" <gi...@apache.org>.
f-lab-lyan commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-4379004438
@Reamer No worries! Thank you 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul merged PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on code in PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#discussion_r2414776925
##########
zeppelin-server/pom.xml:
##########
@@ -50,50 +55,176 @@
<dependencies>
+ <!-- Dependencies from merged zeppelin-zengine module -->
<dependency>
<groupId>${project.groupId}</groupId>
- <artifactId>zeppelin-zengine</artifactId>
+ <artifactId>zeppelin-common</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>zeppelin-interpreter</artifactId>
<version>${project.version}</version>
<exclusions>
<exclusion>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-core</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-json</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.sun.jersey</groupId>
- <artifactId>jersey-server</artifactId>
+ <groupId>javax.inject</groupId>
+ <artifactId>javax.inject</artifactId>
</exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>zeppelin-jupyter</artifactId>
+ <version>${project.version}</version>
+ <exclusions>
<exclusion>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
</exclusion>
- <!-- using jcl-over-slf4j instead -->
<exclusion>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
+ <groupId>org.jsoup</groupId>
+ <artifactId>jsoup</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>jakarta.inject</groupId>
+ <artifactId>jakarta.inject-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>commons-cli</groupId>
+ <artifactId>commons-cli</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-vfs2-jackrabbit1</artifactId>
+ <version>${commons.vfs2.version}</version>
Review Comment:
`commons-logging` should be excluded, it's done via `jcl-over-slf4j`
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/display/AngularObjectBuilder.java:
##########
@@ -1,26 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.zeppelin.display;
-
-public class AngularObjectBuilder {
Review Comment:
The file has been removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on code in PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#discussion_r2416518124
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/display/AngularObjectBuilder.java:
##########
@@ -1,26 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.zeppelin.display;
-
-public class AngularObjectBuilder {
Review Comment:
Ahh, I hadn't looked at that. I can confirm the duplication, so that comment is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-4379017475
@Reamer Mo worries! Thank you 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3406942038
Quick question with limited context. Why is `ZeppelinConfiguration` in the `zeppelin-interpreter` module? It looks like a general configuration class, so I wondered why it lives under interpreter. Because it sits in `zeppelin-interpreter`, it gets shaded and tends to be used first, which might relate to the failing tests. If it’s reasonable, would moving `ZeppelinConfiguration` to a more general module be a better fit and also resolve the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-4379030857
Merged into master (036c8a05).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-4237161557
> @Reamer @tbonelee Hello, I did the task again after merging moving ZeppelinConfiguration PR. The CI failure happens master currently. Could you please help to review it again?
Sorry for the late reply. I'll take a look at the change in the next few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3368008356
@Reamer could you please check it? We might resolve this issue easier than we think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3409482135
> Why is `ZeppelinConfiguration` in the `zeppelin-interpreter` module?
In my opinion, we should split this up. ZeppelinConfiguration belongs to the Zeppelin server, and the Zeppelin interpreter should really only work on a HashMap with ConfigKey and ConfigValue.
The entire loading of the configuration and possibly also a reload should all belong to the server.
Currently, the Zeppelin server transmits the configuration from the server to the remote interpreter when it starts up. See https://github.com/apache/zeppelin/blob/a03dcbcefc4e6d36993fd537d41626e27eb8e05a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java#L202-L207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3704302322
@seung-00 Thank you! It's also a blocker for your work, and I'd be happy for you to help solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3406844666
On the official site, the only reference I could find is the Javadoc link for the type used by the `<relocations>` property (https://maven.apache.org/components/plugins/maven-shade-plugin/apidocs/org/apache/maven/plugins/shade/relocation/SimpleRelocator.html), which doesn’t provide much detail.
I skimmed the code and initially assumed rawString was an option to exclude string literals in .java files from being shaded (https://github.com/apache/maven-shade-plugin/blob/073e7ca970c15a8cae64e2de9517fe8d471b5373/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java#L217). I only tried the rawString option to quickly check whether our test failures were caused by shading string literals in java code, so I didn’t investigate it more rigorously.
However, looking at the issue where this option was introduced (https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-104?filter=allissues) and re-read the whole code of `SimpleRelocator`, the primary intent seems to be treating patterns as regex. If that’s the case, a pattern like `com.google` would be interpreted as a regex, which could lead to unexpected relocations.
I’ve struck through my earlier explanation about `rawString` since it was inaccurate. Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3368735681
I looked into the failing Selenium test to find the cause.
My working hypothesis is that `maven-shade-plugin` is rewriting a string-literal, the default value of `ZEPPELIN_CONFIG_STORAGE_CLASS` inside `zeppelin-interpreter`'s `ZeppelinConfiguration`. I didn't directly inspect the effective classpath, but the behavior suggests that when the shaded class is resolved first, the rewritten default appears, and when the original class is resolved first the unmodified default remains. This inference comes from the two checks below.
1. **Shade raw-string check** : Adding `<rawString>true</rawString>` in the relocation option makes the `ZEPPELIN_CONFIG_STORAGE_CLASS` default value to remain as the original literal value.
2. **Classpath order check** : Reordering dependencies so that `zeppelin-server` appears before `spark-interpreter` also gives the same result as 1. Before the zengine and server merge, the `zeppelin-zengine` dependency also appeared before `spark-interpreter`.
Sharing these observations in case they help fix the failing Selenium test.
https://github.com/apache/zeppelin/blob/190ecd6a2febd58616e0fdbb2686fbd2b2ea7e7a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L1037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3406285868
@tbonelee
Have you found any good documentation regarding `rawString`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6355] Merge zeppelin-zengine to zeppelin-server [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5095:
URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-4186989938
@Reamer @tbonelee Hello, I did the task again after merging moving ZeppelinConfiguration PR. The CI failure happens master currently. Could you please help to review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org