[asterixdb] branch master updated: [NO ISSUE][FUN] round() remove unnecessary Math.abs()

[ht...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

htowaileb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 68183c9  [NO ISSUE][FUN] round() remove unnecessary Math.abs()
68183c9 is described below

commit 68183c9d0111ded02380711e017d93c0f138b530
Author: Hussain Towaileb <Hu...@Couchbase.com>
AuthorDate: Thu Jun 13 17:46:56 2019 +0300

    [NO ISSUE][FUN] round() remove unnecessary Math.abs()
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    - Removed unnecessary Math.abs().
    
    Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/3438
    Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Hussain Towaileb <hu...@gmail.com>
    Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
---
 .../asterix/runtime/evaluators/functions/NumericRoundEvaluator.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
index c06fd35..11aa620 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
@@ -172,7 +172,7 @@ class NumericRoundEvaluator extends AbstractScalarEval {
         if (roundingDigit >= 0) {
 
             // Multiplier based on round digit
-            double multiplier = Math.pow(10, Math.abs(roundingDigit));
+            double multiplier = Math.pow(10, roundingDigit);
 
             switch (valueTypeTag) {
                 // For zero and positive digit rounding, no need to do anything for integers
@@ -209,8 +209,8 @@ class NumericRoundEvaluator extends AbstractScalarEval {
         }
         // Left of decimal (negative roundingDigit value)
         else {
-            // Multiplier based on round digit
-            double multiplier = Math.pow(10, Math.abs(roundingDigit));
+            // Multiplier based on round digit (convert to positive digit)
+            double multiplier = Math.pow(10, -roundingDigit);
 
             switch (valueTypeTag) {
                 case TINYINT: