You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/01/29 15:35:12 UTC
[kudu-CR] [java] Use Java built-in Base64 to generate randomString
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15127
Change subject: [java] Use Java built-in Base64 to generate randomString
......................................................................
[java] Use Java built-in Base64 to generate randomString
Currently we use DatatypeConverter to generate random Base64
Strings in DataGenerator.java. This patch changes to use the
Java built-in Base64 class instead.
Change-Id: I99d511bb8c161159b3ee477460246bc368cc2979
---
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/15127/1
--
To view, visit http://gerrit.cloudera.org:8080/15127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99d511bb8c161159b3ee477460246bc368cc2979
Gerrit-Change-Number: 15127
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Use Java built-in Base64 to generate randomString
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15127 )
Change subject: [java] Use Java built-in Base64 to generate randomString
......................................................................
[java] Use Java built-in Base64 to generate randomString
Currently we use DatatypeConverter to generate random Base64
Strings in DataGenerator.java. This patch changes to use the
Java built-in Base64 class instead.
Change-Id: I99d511bb8c161159b3ee477460246bc368cc2979
Reviewed-on: http://gerrit.cloudera.org:8080/15127
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I99d511bb8c161159b3ee477460246bc368cc2979
Gerrit-Change-Number: 15127
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Use Java built-in Base64 to generate randomString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15127 )
Change subject: [java] Use Java built-in Base64 to generate randomString
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99d511bb8c161159b3ee477460246bc368cc2979
Gerrit-Change-Number: 15127
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jan 2020 17:52:08 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Use Java built-in Base64 to generate randomString
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [java] Use Java built-in Base64 to generate randomString
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I99d511bb8c161159b3ee477460246bc368cc2979
Gerrit-Change-Number: 15127
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Use Java built-in Base64 to generate randomString
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15127 )
Change subject: [java] Use Java built-in Base64 to generate randomString
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99d511bb8c161159b3ee477460246bc368cc2979
Gerrit-Change-Number: 15127
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Jan 2020 15:56:51 +0000
Gerrit-HasComments: No