You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by sebb <se...@gmail.com> on 2015/12/03 14:17:05 UTC
Re: apache-website-template git commit: Add LICENSE and NOTICE files
PING
On 28 November 2015 at 22:59, sebb <se...@gmail.com> wrote:
> On 28 November 2015 at 16:26, <lr...@apache.org> wrote:
>> Repository: apache-website-template
>> Updated Branches:
>> refs/heads/master b140c230c -> 9e881e247
>>
>>
>> Add LICENSE and NOTICE files
>>
>> Properly document LICENSE for each component
>> included on this website, including necessary
>> required attribution notices in the NOTICE
>> file.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/apache-website-template/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/apache-website-template/commit/9e881e24
>> Tree: http://git-wip-us.apache.org/repos/asf/apache-website-template/tree/9e881e24
>> Diff: http://git-wip-us.apache.org/repos/asf/apache-website-template/diff/9e881e24
>>
>> Branch: refs/heads/master
>> Commit: 9e881e247790425e75730c2d24a9952e77764e32
>> Parents: b140c23
>> Author: Luciano Resende <lr...@apache.org>
>> Authored: Sat Nov 28 08:25:52 2015 -0800
>> Committer: Luciano Resende <lr...@apache.org>
>> Committed: Sat Nov 28 08:25:52 2015 -0800
>>
>> ----------------------------------------------------------------------
>> LICENSE | 232 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> NOTICE | 11 +++
>> 2 files changed, 243 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/9e881e24/LICENSE
>> ----------------------------------------------------------------------
>> diff --git a/LICENSE b/LICENSE
>> new file mode 100644
>> index 0000000..7736772
>> --- /dev/null
>> +++ b/LICENSE
>> @@ -0,0 +1,232 @@
>> + Apache License
>> + Version 2.0, January 2004
>> + http://www.apache.org/licenses/
>> +
>> + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
>> +
>> + 1. Definitions.
>> +
>> + "License" shall mean the terms and conditions for use, reproduction,
>> + and distribution as defined by Sections 1 through 9 of this document.
>> +
>> + "Licensor" shall mean the copyright owner or entity authorized by
>> + the copyright owner that is granting the License.
>> +
>> + "Legal Entity" shall mean the union of the acting entity and all
>> + other entities that control, are controlled by, or are under common
>> + control with that entity. For the purposes of this definition,
>> + "control" means (i) the power, direct or indirect, to cause the
>> + direction or management of such entity, whether by contract or
>> + otherwise, or (ii) ownership of fifty percent (50%) or more of the
>> + outstanding shares, or (iii) beneficial ownership of such entity.
>> +
>> + "You" (or "Your") shall mean an individual or Legal Entity
>> + exercising permissions granted by this License.
>> +
>> + "Source" form shall mean the preferred form for making modifications,
>> + including but not limited to software source code, documentation
>> + source, and configuration files.
>> +
>> + "Object" form shall mean any form resulting from mechanical
>> + transformation or translation of a Source form, including but
>> + not limited to compiled object code, generated documentation,
>> + and conversions to other media types.
>> +
>> + "Work" shall mean the work of authorship, whether in Source or
>> + Object form, made available under the License, as indicated by a
>> + copyright notice that is included in or attached to the work
>> + (an example is provided in the Appendix below).
>> +
>> + "Derivative Works" shall mean any work, whether in Source or Object
>> + form, that is based on (or derived from) the Work and for which the
>> + editorial revisions, annotations, elaborations, or other modifications
>> + represent, as a whole, an original work of authorship. For the purposes
>> + of this License, Derivative Works shall not include works that remain
>> + separable from, or merely link (or bind by name) to the interfaces of,
>> + the Work and Derivative Works thereof.
>> +
>> + "Contribution" shall mean any work of authorship, including
>> + the original version of the Work and any modifications or additions
>> + to that Work or Derivative Works thereof, that is intentionally
>> + submitted to Licensor for inclusion in the Work by the copyright owner
>> + or by an individual or Legal Entity authorized to submit on behalf of
>> + the copyright owner. For the purposes of this definition, "submitted"
>> + means any form of electronic, verbal, or written communication sent
>> + to the Licensor or its representatives, including but not limited to
>> + communication on electronic mailing lists, source code control systems,
>> + and issue tracking systems that are managed by, or on behalf of, the
>> + Licensor for the purpose of discussing and improving the Work, but
>> + excluding communication that is conspicuously marked or otherwise
>> + designated in writing by the copyright owner as "Not a Contribution."
>> +
>> + "Contributor" shall mean Licensor and any individual or Legal Entity
>> + on behalf of whom a Contribution has been received by Licensor and
>> + subsequently incorporated within the Work.
>> +
>> + 2. Grant of Copyright License. Subject to the terms and conditions of
>> + this License, each Contributor hereby grants to You a perpetual,
>> + worldwide, non-exclusive, no-charge, royalty-free, irrevocable
>> + copyright license to reproduce, prepare Derivative Works of,
>> + publicly display, publicly perform, sublicense, and distribute the
>> + Work and such Derivative Works in Source or Object form.
>> +
>> + 3. Grant of Patent License. Subject to the terms and conditions of
>> + this License, each Contributor hereby grants to You a perpetual,
>> + worldwide, non-exclusive, no-charge, royalty-free, irrevocable
>> + (except as stated in this section) patent license to make, have made,
>> + use, offer to sell, sell, import, and otherwise transfer the Work,
>> + where such license applies only to those patent claims licensable
>> + by such Contributor that are necessarily infringed by their
>> + Contribution(s) alone or by combination of their Contribution(s)
>> + with the Work to which such Contribution(s) was submitted. If You
>> + institute patent litigation against any entity (including a
>> + cross-claim or counterclaim in a lawsuit) alleging that the Work
>> + or a Contribution incorporated within the Work constitutes direct
>> + or contributory patent infringement, then any patent licenses
>> + granted to You under this License for that Work shall terminate
>> + as of the date such litigation is filed.
>> +
>> + 4. Redistribution. You may reproduce and distribute copies of the
>> + Work or Derivative Works thereof in any medium, with or without
>> + modifications, and in Source or Object form, provided that You
>> + meet the following conditions:
>> +
>> + (a) You must give any other recipients of the Work or
>> + Derivative Works a copy of this License; and
>> +
>> + (b) You must cause any modified files to carry prominent notices
>> + stating that You changed the files; and
>> +
>> + (c) You must retain, in the Source form of any Derivative Works
>> + that You distribute, all copyright, patent, trademark, and
>> + attribution notices from the Source form of the Work,
>> + excluding those notices that do not pertain to any part of
>> + the Derivative Works; and
>> +
>> + (d) If the Work includes a "NOTICE" text file as part of its
>> + distribution, then any Derivative Works that You distribute must
>> + include a readable copy of the attribution notices contained
>> + within such NOTICE file, excluding those notices that do not
>> + pertain to any part of the Derivative Works, in at least one
>> + of the following places: within a NOTICE text file distributed
>> + as part of the Derivative Works; within the Source form or
>> + documentation, if provided along with the Derivative Works; or,
>> + within a display generated by the Derivative Works, if and
>> + wherever such third-party notices normally appear. The contents
>> + of the NOTICE file are for informational purposes only and
>> + do not modify the License. You may add Your own attribution
>> + notices within Derivative Works that You distribute, alongside
>> + or as an addendum to the NOTICE text from the Work, provided
>> + that such additional attribution notices cannot be construed
>> + as modifying the License.
>> +
>> + You may add Your own copyright statement to Your modifications and
>> + may provide additional or different license terms and conditions
>> + for use, reproduction, or distribution of Your modifications, or
>> + for any such Derivative Works as a whole, provided Your use,
>> + reproduction, and distribution of the Work otherwise complies with
>> + the conditions stated in this License.
>> +
>> + 5. Submission of Contributions. Unless You explicitly state otherwise,
>> + any Contribution intentionally submitted for inclusion in the Work
>> + by You to the Licensor shall be under the terms and conditions of
>> + this License, without any additional terms or conditions.
>> + Notwithstanding the above, nothing herein shall supersede or modify
>> + the terms of any separate license agreement you may have executed
>> + with Licensor regarding such Contributions.
>> +
>> + 6. Trademarks. This License does not grant permission to use the trade
>> + names, trademarks, service marks, or product names of the Licensor,
>> + except as required for reasonable and customary use in describing the
>> + origin of the Work and reproducing the content of the NOTICE file.
>> +
>> + 7. Disclaimer of Warranty. Unless required by applicable law or
>> + agreed to in writing, Licensor provides the Work (and each
>> + Contributor provides its Contributions) on an "AS IS" BASIS,
>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> + implied, including, without limitation, any warranties or conditions
>> + of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
>> + PARTICULAR PURPOSE. You are solely responsible for determining the
>> + appropriateness of using or redistributing the Work and assume any
>> + risks associated with Your exercise of permissions under this License.
>> +
>> + 8. Limitation of Liability. In no event and under no legal theory,
>> + whether in tort (including negligence), contract, or otherwise,
>> + unless required by applicable law (such as deliberate and grossly
>> + negligent acts) or agreed to in writing, shall any Contributor be
>> + liable to You for damages, including any direct, indirect, special,
>> + incidental, or consequential damages of any character arising as a
>> + result of this License or out of the use or inability to use the
>> + Work (including but not limited to damages for loss of goodwill,
>> + work stoppage, computer failure or malfunction, or any and all
>> + other commercial damages or losses), even if such Contributor
>> + has been advised of the possibility of such damages.
>> +
>> + 9. Accepting Warranty or Additional Liability. While redistributing
>> + the Work or Derivative Works thereof, You may choose to offer,
>> + and charge a fee for, acceptance of support, warranty, indemnity,
>> + or other liability obligations and/or rights consistent with this
>> + License. However, in accepting such obligations, You may act only
>> + on Your own behalf and on Your sole responsibility, not on behalf
>> + of any other Contributor, and only if You agree to indemnify,
>> + defend, and hold each Contributor harmless for any liability
>> + incurred by, or claims asserted against, such Contributor by reason
>> + of your accepting any such warranty or additional liability.
>> +
>> + END OF TERMS AND CONDITIONS
>> +
>> + APPENDIX: How to apply the Apache License to your work.
>> +
>> + To apply the Apache License to your work, attach the following
>> + boilerplate notice, with the fields enclosed by brackets "{}"
>> + replaced with your own identifying information. (Don't include
>> + the brackets!) The text should be enclosed in the appropriate
>> + comment syntax for the file format. We also recommend that a
>> + file or class name and description of purpose be included on the
>> + same "printed page" as the copyright notice for easier
>> + identification within third-party archives.
>> +
>> + Copyright {yyyy} {name of copyright owner}
>> +
>> + Licensed under the Apache License, Version 2.0 (the "License");
>> + you may not use this file except in compliance with the License.
>> + You may obtain a copy of the License at
>> +
>> + http://www.apache.org/licenses/LICENSE-2.0
>> +
>> + Unless required by applicable law or agreed to in writing, software
>> + distributed under the License is distributed on an "AS IS" BASIS,
>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + See the License for the specific language governing permissions and
>> + limitations under the License.
>> +
>> +===============================================================================
>> +
>> +The following components included on this website are distributed under MIT license :
>> +
>> +- Jekyll
>> +- Jekyll Bootstrap
>> +- Bootstrap
>> +- jQuery
>> +
>> +The MIT License (MIT):
>> +
>> +Permission is hereby granted, free of charge, to any person obtaining a copy
>> +of this software and associated documentation files (the "Software"), to deal
>> +in the Software without restriction, including without limitation the rights
>> +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
>> +copies of the Software, and to permit persons to whom the Software is
>> +furnished to do so, subject to the following conditions:
>> +
>> +The above copyright notice and this permission notice shall be included in all
>> +copies or substantial portions of the Software.
>> +
>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
>> +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
>> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
>> +SOFTWARE.
>> +
>> +
>
> The LICENSE looks OK.
>
>> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/9e881e24/NOTICE
>> ----------------------------------------------------------------------
>> diff --git a/NOTICE b/NOTICE
>> new file mode 100644
>> index 0000000..a4fed15
>> --- /dev/null
>> +++ b/NOTICE
>> @@ -0,0 +1,11 @@
>
> The ASF Copright header is missing
>
> See http://www.apache.org/legal/src-headers.html#notice
>
>> +This product includes software developed at
>> +The Apache Software Foundation (http://www.apache.org/).
>> +
>
> That paragraph is OK
>
>> +This product uses Jekyll software (http://jekyllrb.com/)
>> +Copyright (c) 2008-2015 Tom Preston-Werner
>> +
>> +This product includes Boostrap software (http://getbootstrap.com/)
>> +Copyright (c) 2011-2015 Twitter, Inc
>> +
>> +This product includes jQuery software (http://jquery.com/)
>> +Copyright jQuery Foundation and other contributors, https://jquery.org/
>
> AFAICT these 3 attributions are NOT necessary for MIT licensed code, see
>
> http://www.apache.org/dev/licensing-howto.html#permissive-deps
>
>
> Please check and fix accordingly.
>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: cvs-help@incubator.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Alex Harui <ah...@adobe.com>.
Hi Roberta,
Can you ask this on your other thread and include more information about
whether this is a file that has been donated to the ASF or is third-party?
On 12/3/15, 8:40 AM, "Roberta Marton" <ro...@esgyn.com> wrote:
>I have a question regarding the NOTICE and LICENSE file as it pertains to
>an
>MIT or BSD license.
>If I, for example, have a source file with a copyright notice followed by
>MIT license text, can't I just put the copyright notice in the LICENSE
>file
>with a pointer to the MIT license text (or actually include the text)?
>Do I need to add anything in the NOTICE file? In
>http://www.apache.org/legal/src-headers.html#header-existingcopyright
>seems
>to imply that the copyright should be added to the NOTICE file.
>
>When I look at other projects LICENSE and NOTICE files; everyone seems to
>do
>it differently, even with the same copyright details.
>
> Regards,
> Roberta
>
>-----Original Message-----
>From: Marvin Humphrey [mailto:marvin@rectangular.com]
>Sent: Thursday, December 3, 2015 6:16 AM
>To: general@incubator.apache.org
>Cc: lresende@apache.org
>Subject: Re: apache-website-template git commit: Add LICENSE and NOTICE
>files
>
>On Thu, Dec 3, 2015 at 5:17 AM, sebb <se...@gmail.com> wrote:
>> PING
>
>I'd also like to see this addressed. Licensing documentation for
>Incubator
>sample code should adhere to best practices.
>
>> On 28 November 2015 at 22:59, sebb <se...@gmail.com> wrote:
>>> On 28 November 2015 at 16:26, <lr...@apache.org> wrote:
>
>>>> +The following components included on this website are distributed
>>>>under
>>>> MIT license :
>>>> +
>>>> +- Jekyll
>>>> +- Jekyll Bootstrap
>>>> +- Bootstrap
>>>> +- jQuery
>>>> +
>>>> +The MIT License (MIT):
>>>> +
>>>> +Permission is hereby granted, free of charge, to any person
>>>> +obtaining a copy of this software and associated documentation
>>>> +files (the "Software"), to deal in the Software without
>>>> +restriction, including without limitation the rights to use, copy,
>>>> +modify, merge, publish, distribute, sublicense, and/or sell copies
>>>> +of the Software, and to permit persons to whom the Software is
>>>> furnished to do so, subject to the following conditions:
>>>> +
>>>> +The above copyright notice and this permission notice shall be
>>>> +included in all copies or substantial portions of the Software.
>>>> +
>>>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>>>> +EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>>>> +MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>>>> +NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
>>>> +BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
>>>> +ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
>>>> +CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
>>>> SOFTWARE.
>>>> +
>>>> +
>>>
>>> The LICENSE looks OK.
>
>+1, it's OK, though I'd make one suggestion.
>
>The addition of the MIT license text minus the copyright notice (the
>intent
>is clearly to generalize so that it applies to 4 different dependencies)
>is
>a bit irregular. The copyright notice is an integral part of the MIT
>license -- it's actually a license template and is only completed when the
>copyright notice has the owner filled in.
>
> http://opensource.org/licenses/MIT
>
>To addresss the irregularity, I'd suggest either prepending the template
>line `Copyright (c) <year> <copyright holders>` -- or simply omitting the
>text of the MIT license, instead including filepath pointers to where the
>deps can be found in the distro.
>
>>>> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/
>>>> 9e881e24/NOTICE
>>>> --------------------------------------------------------------------
>>>> --
>>>> diff --git a/NOTICE b/NOTICE
>>>> new file mode 100644
>>>> index 0000000..a4fed15
>>>> --- /dev/null
>>>> +++ b/NOTICE
>>>> @@ -0,0 +1,11 @@
>>>
>>> The ASF Copright header is missing
>>>
>>> See http://www.apache.org/legal/src-headers.html#notice
>>>
>
>+1
>
>Just the copyright notice, i.e. this:
>
> Apache [PRODUCT_NAME]
> Copyright [yyyy] The Apache Software Foundation
>
>Actually, what should "[PRODUCT_NAME]" be in this case?
>
>>>> +This product includes software developed at The Apache Software
>>>> +Foundation (http://www.apache.org/).
>>>> +
>>>
>>> That paragraph is OK
>>>
>>>> +This product uses Jekyll software (http://jekyllrb.com/) Copyright
>>>> +(c) 2008-2015 Tom Preston-Werner
>>>> +
>>>> +This product includes Boostrap software (http://getbootstrap.com/)
>>>> +Copyright (c) 2011-2015 Twitter, Inc
>>>> +
>>>> +This product includes jQuery software (http://jquery.com/)
>>>> +Copyright jQuery Foundation and other contributors,
>>>> +https://jquery.org/
>>>
>>> AFAICT these 3 attributions are NOT necessary for MIT licensed code,
>>> see
>>>
>>> http://www.apache.org/dev/licensing-howto.html#permissive-deps
>
>+1, those should definitely be removed.
>
>Marvin Humphrey
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>For additional commands, e-mail: general-help@incubator.apache.org
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>For additional commands, e-mail: general-help@incubator.apache.org
>
RE: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Roberta Marton <ro...@esgyn.com>.
I have a question regarding the NOTICE and LICENSE file as it pertains to an
MIT or BSD license.
If I, for example, have a source file with a copyright notice followed by
MIT license text, can't I just put the copyright notice in the LICENSE file
with a pointer to the MIT license text (or actually include the text)?
Do I need to add anything in the NOTICE file? In
http://www.apache.org/legal/src-headers.html#header-existingcopyright seems
to imply that the copyright should be added to the NOTICE file.
When I look at other projects LICENSE and NOTICE files; everyone seems to do
it differently, even with the same copyright details.
Regards,
Roberta
-----Original Message-----
From: Marvin Humphrey [mailto:marvin@rectangular.com]
Sent: Thursday, December 3, 2015 6:16 AM
To: general@incubator.apache.org
Cc: lresende@apache.org
Subject: Re: apache-website-template git commit: Add LICENSE and NOTICE
files
On Thu, Dec 3, 2015 at 5:17 AM, sebb <se...@gmail.com> wrote:
> PING
I'd also like to see this addressed. Licensing documentation for Incubator
sample code should adhere to best practices.
> On 28 November 2015 at 22:59, sebb <se...@gmail.com> wrote:
>> On 28 November 2015 at 16:26, <lr...@apache.org> wrote:
>>> +The following components included on this website are distributed under
>>> MIT license :
>>> +
>>> +- Jekyll
>>> +- Jekyll Bootstrap
>>> +- Bootstrap
>>> +- jQuery
>>> +
>>> +The MIT License (MIT):
>>> +
>>> +Permission is hereby granted, free of charge, to any person
>>> +obtaining a copy of this software and associated documentation
>>> +files (the "Software"), to deal in the Software without
>>> +restriction, including without limitation the rights to use, copy,
>>> +modify, merge, publish, distribute, sublicense, and/or sell copies
>>> +of the Software, and to permit persons to whom the Software is
>>> furnished to do so, subject to the following conditions:
>>> +
>>> +The above copyright notice and this permission notice shall be
>>> +included in all copies or substantial portions of the Software.
>>> +
>>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>>> +EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>>> +MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>>> +NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
>>> +BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
>>> +ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
>>> +CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
>>> SOFTWARE.
>>> +
>>> +
>>
>> The LICENSE looks OK.
+1, it's OK, though I'd make one suggestion.
The addition of the MIT license text minus the copyright notice (the intent
is clearly to generalize so that it applies to 4 different dependencies) is
a bit irregular. The copyright notice is an integral part of the MIT
license -- it's actually a license template and is only completed when the
copyright notice has the owner filled in.
http://opensource.org/licenses/MIT
To addresss the irregularity, I'd suggest either prepending the template
line `Copyright (c) <year> <copyright holders>` -- or simply omitting the
text of the MIT license, instead including filepath pointers to where the
deps can be found in the distro.
>>> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/
>>> 9e881e24/NOTICE
>>> --------------------------------------------------------------------
>>> --
>>> diff --git a/NOTICE b/NOTICE
>>> new file mode 100644
>>> index 0000000..a4fed15
>>> --- /dev/null
>>> +++ b/NOTICE
>>> @@ -0,0 +1,11 @@
>>
>> The ASF Copright header is missing
>>
>> See http://www.apache.org/legal/src-headers.html#notice
>>
+1
Just the copyright notice, i.e. this:
Apache [PRODUCT_NAME]
Copyright [yyyy] The Apache Software Foundation
Actually, what should "[PRODUCT_NAME]" be in this case?
>>> +This product includes software developed at The Apache Software
>>> +Foundation (http://www.apache.org/).
>>> +
>>
>> That paragraph is OK
>>
>>> +This product uses Jekyll software (http://jekyllrb.com/) Copyright
>>> +(c) 2008-2015 Tom Preston-Werner
>>> +
>>> +This product includes Boostrap software (http://getbootstrap.com/)
>>> +Copyright (c) 2011-2015 Twitter, Inc
>>> +
>>> +This product includes jQuery software (http://jquery.com/)
>>> +Copyright jQuery Foundation and other contributors,
>>> +https://jquery.org/
>>
>> AFAICT these 3 attributions are NOT necessary for MIT licensed code,
>> see
>>
>> http://www.apache.org/dev/licensing-howto.html#permissive-deps
+1, those should definitely be removed.
Marvin Humphrey
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Luciano Resende <lu...@gmail.com>.
On Sat, Dec 5, 2015 at 12:20 PM, Julian Hyde <jh...@apache.org> wrote:
> Thanks, Luciano. I've got a couple of issues to discuss, which I'll
> log as github issues, so we can discuss there.
>
> Julian
>
>
>
Great, I have created a JIRA issue to enable issues for the repository
https://issues.apache.org/jira/browse/INFRA-10901
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Julian Hyde <jh...@apache.org>.
Thanks, Luciano. I've got a couple of issues to discuss, which I'll
log as github issues, so we can discuss there.
Julian
On Fri, Dec 4, 2015 at 10:37 PM, Luciano Resende <lu...@gmail.com> wrote:
> I have merged your changes now, and will push as soon as a fix couple
> little navigation issues.
>
> Thanks.
>
> On Friday, December 4, 2015, Julian Hyde <jh...@apache.org> wrote:
>
>> I’ve been making some changes to the template and submitting them as
>> github pull requests. (I made 5 pull requests a couple of weeks ago, which
>> weren’t noticed, and Luciano subsequently made very some similar changes.
>> Frustrating.)
>>
>> I don’t want to clutter this list with dev traffic, but there’s no other
>> forum. In the absence of a dev list, Luciano, can I suggest that you watch
>> github pull requests [1] closely. We can discuss on github, as long as you
>> notice the pull requests come in.
>>
>> Julian
>>
>> [1] https://github.com/apache/apache-website-template/pulls
>>
>>
>> > On Dec 3, 2015, at 11:27 AM, Luciano Resende <lresende@apache.org
>> <javascript:;>> wrote:
>> >
>> > On Thu, Dec 3, 2015 at 6:16 AM, Marvin Humphrey <marvin@rectangular.com
>> <javascript:;>>
>> > wrote:
>> >
>> >> On Thu, Dec 3, 2015 at 5:17 AM, sebb <sebbaz@gmail.com <javascript:;>>
>> wrote:
>> >>> PING
>> >>
>> >> I'd also like to see this addressed. Licensing documentation for
>> Incubator
>> >> sample code should adhere to best practices.
>> >>
>> >>> On 28 November 2015 at 22:59, sebb <sebbaz@gmail.com <javascript:;>>
>> wrote:
>> >>>> On 28 November 2015 at 16:26, <lresende@apache.org <javascript:;>>
>> wrote:
>> >>
>> >>>>> +The following components included on this website are distributed
>> >> under MIT license :
>> >>>>> +
>> >>>>> +- Jekyll
>> >>>>> +- Jekyll Bootstrap
>> >>>>> +- Bootstrap
>> >>>>> +- jQuery
>> >>>>> +
>> >>>>> +The MIT License (MIT):
>> >>>>> +
>> >>>>> +Permission is hereby granted, free of charge, to any person
>> obtaining
>> >> a copy
>> >>>>> +of this software and associated documentation files (the
>> "Software"),
>> >> to deal
>> >>>>> +in the Software without restriction, including without limitation
>> the
>> >> rights
>> >>>>> +to use, copy, modify, merge, publish, distribute, sublicense, and/or
>> >> sell
>> >>>>> +copies of the Software, and to permit persons to whom the Software
>> is
>> >>>>> +furnished to do so, subject to the following conditions:
>> >>>>> +
>> >>>>> +The above copyright notice and this permission notice shall be
>> >> included in all
>> >>>>> +copies or substantial portions of the Software.
>> >>>>> +
>> >>>>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> >> EXPRESS OR
>> >>>>> +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> >> MERCHANTABILITY,
>> >>>>> +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> >> SHALL THE
>> >>>>> +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>> >>>>> +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> >> ARISING FROM,
>> >>>>> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> >> DEALINGS IN THE
>> >>>>> +SOFTWARE.
>> >>>>> +
>> >>>>> +
>> >>>>
>> >>>> The LICENSE looks OK.
>> >>
>> >> +1, it's OK, though I'd make one suggestion.
>> >>
>> >> The addition of the MIT license text minus the copyright notice (the
>> >> intent is
>> >> clearly to generalize so that it applies to 4 different dependencies)
>> is a
>> >> bit
>> >> irregular. The copyright notice is an integral part of the MIT license
>> --
>> >> it's actually a license template and is only completed when the
>> copyright
>> >> notice has the owner filled in.
>> >>
>> >> http://opensource.org/licenses/MIT
>> >>
>> >> To addresss the irregularity, I'd suggest either prepending the template
>> >> line
>> >> `Copyright (c) <year> <copyright holders>` -- or simply omitting the
>> text
>> >> of
>> >> the MIT license, instead including filepath pointers to where the deps
>> >> can be found in the distro.
>> >>
>> >>>>>
>> >>
>> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/9e881e24/NOTICE
>> >>>>>
>> ----------------------------------------------------------------------
>> >>>>> diff --git a/NOTICE b/NOTICE
>> >>>>> new file mode 100644
>> >>>>> index 0000000..a4fed15
>> >>>>> --- /dev/null
>> >>>>> +++ b/NOTICE
>> >>>>> @@ -0,0 +1,11 @@
>> >>>>
>> >>>> The ASF Copright header is missing
>> >>>>
>> >>>> See http://www.apache.org/legal/src-headers.html#notice
>> >>>>
>> >>
>> >> +1
>> >>
>> >> Just the copyright notice, i.e. this:
>> >>
>> >> Apache [PRODUCT_NAME]
>> >> Copyright [yyyy] The Apache Software Foundation
>> >>
>> >> Actually, what should "[PRODUCT_NAME]" be in this case?
>> >>
>> >>>>> +This product includes software developed at
>> >>>>> +The Apache Software Foundation (http://www.apache.org/).
>> >>>>> +
>> >>>>
>> >>>> That paragraph is OK
>> >>>>
>> >>>>> +This product uses Jekyll software (http://jekyllrb.com/)
>> >>>>> +Copyright (c) 2008-2015 Tom Preston-Werner
>> >>>>> +
>> >>>>> +This product includes Boostrap software (http://getbootstrap.com/)
>> >>>>> +Copyright (c) 2011-2015 Twitter, Inc
>> >>>>> +
>> >>>>> +This product includes jQuery software (http://jquery.com/)
>> >>>>> +Copyright jQuery Foundation and other contributors,
>> >> https://jquery.org/
>> >>>>
>> >>>> AFAICT these 3 attributions are NOT necessary for MIT licensed code,
>> see
>> >>>>
>> >>>> http://www.apache.org/dev/licensing-howto.html#permissive-deps
>> >>
>> >> +1, those should definitely be removed.
>> >>
>> >> Marvin Humphrey
>> >>
>> >
>> >
>> > Again, apologies for taking a bit long to address this, as these comments
>> > got automatically archived.
>> >
>> > I have addressed both of comments now, where :
>> >
>> > - License now have one entry per dependency, with proper copyright notice
>> > - Notice file has been cleaned up and added Apache Copyright entry
>> >
>> > Please let me know if there are other issues that still needs to be
>> > addressed.
>> >
>> > --
>> > Luciano Resende
>> > http://people.apache.org/~lresende
>> > http://twitter.com/lresende1975
>> > http://lresende.blogspot.com/
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> <javascript:;>
>> For additional commands, e-mail: general-help@incubator.apache.org
>> <javascript:;>
>>
>>
>
> --
> Sent from my Mobile device
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Luciano Resende <lu...@gmail.com>.
I have merged your changes now, and will push as soon as a fix couple
little navigation issues.
Thanks.
On Friday, December 4, 2015, Julian Hyde <jh...@apache.org> wrote:
> I’ve been making some changes to the template and submitting them as
> github pull requests. (I made 5 pull requests a couple of weeks ago, which
> weren’t noticed, and Luciano subsequently made very some similar changes.
> Frustrating.)
>
> I don’t want to clutter this list with dev traffic, but there’s no other
> forum. In the absence of a dev list, Luciano, can I suggest that you watch
> github pull requests [1] closely. We can discuss on github, as long as you
> notice the pull requests come in.
>
> Julian
>
> [1] https://github.com/apache/apache-website-template/pulls
>
>
> > On Dec 3, 2015, at 11:27 AM, Luciano Resende <lresende@apache.org
> <javascript:;>> wrote:
> >
> > On Thu, Dec 3, 2015 at 6:16 AM, Marvin Humphrey <marvin@rectangular.com
> <javascript:;>>
> > wrote:
> >
> >> On Thu, Dec 3, 2015 at 5:17 AM, sebb <sebbaz@gmail.com <javascript:;>>
> wrote:
> >>> PING
> >>
> >> I'd also like to see this addressed. Licensing documentation for
> Incubator
> >> sample code should adhere to best practices.
> >>
> >>> On 28 November 2015 at 22:59, sebb <sebbaz@gmail.com <javascript:;>>
> wrote:
> >>>> On 28 November 2015 at 16:26, <lresende@apache.org <javascript:;>>
> wrote:
> >>
> >>>>> +The following components included on this website are distributed
> >> under MIT license :
> >>>>> +
> >>>>> +- Jekyll
> >>>>> +- Jekyll Bootstrap
> >>>>> +- Bootstrap
> >>>>> +- jQuery
> >>>>> +
> >>>>> +The MIT License (MIT):
> >>>>> +
> >>>>> +Permission is hereby granted, free of charge, to any person
> obtaining
> >> a copy
> >>>>> +of this software and associated documentation files (the
> "Software"),
> >> to deal
> >>>>> +in the Software without restriction, including without limitation
> the
> >> rights
> >>>>> +to use, copy, modify, merge, publish, distribute, sublicense, and/or
> >> sell
> >>>>> +copies of the Software, and to permit persons to whom the Software
> is
> >>>>> +furnished to do so, subject to the following conditions:
> >>>>> +
> >>>>> +The above copyright notice and this permission notice shall be
> >> included in all
> >>>>> +copies or substantial portions of the Software.
> >>>>> +
> >>>>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >> EXPRESS OR
> >>>>> +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> >> MERCHANTABILITY,
> >>>>> +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >> SHALL THE
> >>>>> +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> >>>>> +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >> ARISING FROM,
> >>>>> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >> DEALINGS IN THE
> >>>>> +SOFTWARE.
> >>>>> +
> >>>>> +
> >>>>
> >>>> The LICENSE looks OK.
> >>
> >> +1, it's OK, though I'd make one suggestion.
> >>
> >> The addition of the MIT license text minus the copyright notice (the
> >> intent is
> >> clearly to generalize so that it applies to 4 different dependencies)
> is a
> >> bit
> >> irregular. The copyright notice is an integral part of the MIT license
> --
> >> it's actually a license template and is only completed when the
> copyright
> >> notice has the owner filled in.
> >>
> >> http://opensource.org/licenses/MIT
> >>
> >> To addresss the irregularity, I'd suggest either prepending the template
> >> line
> >> `Copyright (c) <year> <copyright holders>` -- or simply omitting the
> text
> >> of
> >> the MIT license, instead including filepath pointers to where the deps
> >> can be found in the distro.
> >>
> >>>>>
> >>
> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/9e881e24/NOTICE
> >>>>>
> ----------------------------------------------------------------------
> >>>>> diff --git a/NOTICE b/NOTICE
> >>>>> new file mode 100644
> >>>>> index 0000000..a4fed15
> >>>>> --- /dev/null
> >>>>> +++ b/NOTICE
> >>>>> @@ -0,0 +1,11 @@
> >>>>
> >>>> The ASF Copright header is missing
> >>>>
> >>>> See http://www.apache.org/legal/src-headers.html#notice
> >>>>
> >>
> >> +1
> >>
> >> Just the copyright notice, i.e. this:
> >>
> >> Apache [PRODUCT_NAME]
> >> Copyright [yyyy] The Apache Software Foundation
> >>
> >> Actually, what should "[PRODUCT_NAME]" be in this case?
> >>
> >>>>> +This product includes software developed at
> >>>>> +The Apache Software Foundation (http://www.apache.org/).
> >>>>> +
> >>>>
> >>>> That paragraph is OK
> >>>>
> >>>>> +This product uses Jekyll software (http://jekyllrb.com/)
> >>>>> +Copyright (c) 2008-2015 Tom Preston-Werner
> >>>>> +
> >>>>> +This product includes Boostrap software (http://getbootstrap.com/)
> >>>>> +Copyright (c) 2011-2015 Twitter, Inc
> >>>>> +
> >>>>> +This product includes jQuery software (http://jquery.com/)
> >>>>> +Copyright jQuery Foundation and other contributors,
> >> https://jquery.org/
> >>>>
> >>>> AFAICT these 3 attributions are NOT necessary for MIT licensed code,
> see
> >>>>
> >>>> http://www.apache.org/dev/licensing-howto.html#permissive-deps
> >>
> >> +1, those should definitely be removed.
> >>
> >> Marvin Humphrey
> >>
> >
> >
> > Again, apologies for taking a bit long to address this, as these comments
> > got automatically archived.
> >
> > I have addressed both of comments now, where :
> >
> > - License now have one entry per dependency, with proper copyright notice
> > - Notice file has been cleaned up and added Apache Copyright entry
> >
> > Please let me know if there are other issues that still needs to be
> > addressed.
> >
> > --
> > Luciano Resende
> > http://people.apache.org/~lresende
> > http://twitter.com/lresende1975
> > http://lresende.blogspot.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> <javascript:;>
> For additional commands, e-mail: general-help@incubator.apache.org
> <javascript:;>
>
>
--
Sent from my Mobile device
Re: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Julian Hyde <jh...@apache.org>.
I’ve been making some changes to the template and submitting them as github pull requests. (I made 5 pull requests a couple of weeks ago, which weren’t noticed, and Luciano subsequently made very some similar changes. Frustrating.)
I don’t want to clutter this list with dev traffic, but there’s no other forum. In the absence of a dev list, Luciano, can I suggest that you watch github pull requests [1] closely. We can discuss on github, as long as you notice the pull requests come in.
Julian
[1] https://github.com/apache/apache-website-template/pulls
> On Dec 3, 2015, at 11:27 AM, Luciano Resende <lr...@apache.org> wrote:
>
> On Thu, Dec 3, 2015 at 6:16 AM, Marvin Humphrey <ma...@rectangular.com>
> wrote:
>
>> On Thu, Dec 3, 2015 at 5:17 AM, sebb <se...@gmail.com> wrote:
>>> PING
>>
>> I'd also like to see this addressed. Licensing documentation for Incubator
>> sample code should adhere to best practices.
>>
>>> On 28 November 2015 at 22:59, sebb <se...@gmail.com> wrote:
>>>> On 28 November 2015 at 16:26, <lr...@apache.org> wrote:
>>
>>>>> +The following components included on this website are distributed
>> under MIT license :
>>>>> +
>>>>> +- Jekyll
>>>>> +- Jekyll Bootstrap
>>>>> +- Bootstrap
>>>>> +- jQuery
>>>>> +
>>>>> +The MIT License (MIT):
>>>>> +
>>>>> +Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>>>>> +of this software and associated documentation files (the "Software"),
>> to deal
>>>>> +in the Software without restriction, including without limitation the
>> rights
>>>>> +to use, copy, modify, merge, publish, distribute, sublicense, and/or
>> sell
>>>>> +copies of the Software, and to permit persons to whom the Software is
>>>>> +furnished to do so, subject to the following conditions:
>>>>> +
>>>>> +The above copyright notice and this permission notice shall be
>> included in all
>>>>> +copies or substantial portions of the Software.
>>>>> +
>>>>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> EXPRESS OR
>>>>> +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> MERCHANTABILITY,
>>>>> +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>>>> +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>>>>> +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING FROM,
>>>>> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> DEALINGS IN THE
>>>>> +SOFTWARE.
>>>>> +
>>>>> +
>>>>
>>>> The LICENSE looks OK.
>>
>> +1, it's OK, though I'd make one suggestion.
>>
>> The addition of the MIT license text minus the copyright notice (the
>> intent is
>> clearly to generalize so that it applies to 4 different dependencies) is a
>> bit
>> irregular. The copyright notice is an integral part of the MIT license --
>> it's actually a license template and is only completed when the copyright
>> notice has the owner filled in.
>>
>> http://opensource.org/licenses/MIT
>>
>> To addresss the irregularity, I'd suggest either prepending the template
>> line
>> `Copyright (c) <year> <copyright holders>` -- or simply omitting the text
>> of
>> the MIT license, instead including filepath pointers to where the deps
>> can be found in the distro.
>>
>>>>>
>> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/9e881e24/NOTICE
>>>>> ----------------------------------------------------------------------
>>>>> diff --git a/NOTICE b/NOTICE
>>>>> new file mode 100644
>>>>> index 0000000..a4fed15
>>>>> --- /dev/null
>>>>> +++ b/NOTICE
>>>>> @@ -0,0 +1,11 @@
>>>>
>>>> The ASF Copright header is missing
>>>>
>>>> See http://www.apache.org/legal/src-headers.html#notice
>>>>
>>
>> +1
>>
>> Just the copyright notice, i.e. this:
>>
>> Apache [PRODUCT_NAME]
>> Copyright [yyyy] The Apache Software Foundation
>>
>> Actually, what should "[PRODUCT_NAME]" be in this case?
>>
>>>>> +This product includes software developed at
>>>>> +The Apache Software Foundation (http://www.apache.org/).
>>>>> +
>>>>
>>>> That paragraph is OK
>>>>
>>>>> +This product uses Jekyll software (http://jekyllrb.com/)
>>>>> +Copyright (c) 2008-2015 Tom Preston-Werner
>>>>> +
>>>>> +This product includes Boostrap software (http://getbootstrap.com/)
>>>>> +Copyright (c) 2011-2015 Twitter, Inc
>>>>> +
>>>>> +This product includes jQuery software (http://jquery.com/)
>>>>> +Copyright jQuery Foundation and other contributors,
>> https://jquery.org/
>>>>
>>>> AFAICT these 3 attributions are NOT necessary for MIT licensed code, see
>>>>
>>>> http://www.apache.org/dev/licensing-howto.html#permissive-deps
>>
>> +1, those should definitely be removed.
>>
>> Marvin Humphrey
>>
>
>
> Again, apologies for taking a bit long to address this, as these comments
> got automatically archived.
>
> I have addressed both of comments now, where :
>
> - License now have one entry per dependency, with proper copyright notice
> - Notice file has been cleaned up and added Apache Copyright entry
>
> Please let me know if there are other issues that still needs to be
> addressed.
>
> --
> Luciano Resende
> http://people.apache.org/~lresende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Luciano Resende <lr...@apache.org>.
On Thu, Dec 3, 2015 at 6:16 AM, Marvin Humphrey <ma...@rectangular.com>
wrote:
> On Thu, Dec 3, 2015 at 5:17 AM, sebb <se...@gmail.com> wrote:
> > PING
>
> I'd also like to see this addressed. Licensing documentation for Incubator
> sample code should adhere to best practices.
>
> > On 28 November 2015 at 22:59, sebb <se...@gmail.com> wrote:
> >> On 28 November 2015 at 16:26, <lr...@apache.org> wrote:
>
> >>> +The following components included on this website are distributed
> under MIT license :
> >>> +
> >>> +- Jekyll
> >>> +- Jekyll Bootstrap
> >>> +- Bootstrap
> >>> +- jQuery
> >>> +
> >>> +The MIT License (MIT):
> >>> +
> >>> +Permission is hereby granted, free of charge, to any person obtaining
> a copy
> >>> +of this software and associated documentation files (the "Software"),
> to deal
> >>> +in the Software without restriction, including without limitation the
> rights
> >>> +to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> >>> +copies of the Software, and to permit persons to whom the Software is
> >>> +furnished to do so, subject to the following conditions:
> >>> +
> >>> +The above copyright notice and this permission notice shall be
> included in all
> >>> +copies or substantial portions of the Software.
> >>> +
> >>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> >>> +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> >>> +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> >>> +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> >>> +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> >>> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS IN THE
> >>> +SOFTWARE.
> >>> +
> >>> +
> >>
> >> The LICENSE looks OK.
>
> +1, it's OK, though I'd make one suggestion.
>
> The addition of the MIT license text minus the copyright notice (the
> intent is
> clearly to generalize so that it applies to 4 different dependencies) is a
> bit
> irregular. The copyright notice is an integral part of the MIT license --
> it's actually a license template and is only completed when the copyright
> notice has the owner filled in.
>
> http://opensource.org/licenses/MIT
>
> To addresss the irregularity, I'd suggest either prepending the template
> line
> `Copyright (c) <year> <copyright holders>` -- or simply omitting the text
> of
> the MIT license, instead including filepath pointers to where the deps
> can be found in the distro.
>
> >>>
> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/9e881e24/NOTICE
> >>> ----------------------------------------------------------------------
> >>> diff --git a/NOTICE b/NOTICE
> >>> new file mode 100644
> >>> index 0000000..a4fed15
> >>> --- /dev/null
> >>> +++ b/NOTICE
> >>> @@ -0,0 +1,11 @@
> >>
> >> The ASF Copright header is missing
> >>
> >> See http://www.apache.org/legal/src-headers.html#notice
> >>
>
> +1
>
> Just the copyright notice, i.e. this:
>
> Apache [PRODUCT_NAME]
> Copyright [yyyy] The Apache Software Foundation
>
> Actually, what should "[PRODUCT_NAME]" be in this case?
>
> >>> +This product includes software developed at
> >>> +The Apache Software Foundation (http://www.apache.org/).
> >>> +
> >>
> >> That paragraph is OK
> >>
> >>> +This product uses Jekyll software (http://jekyllrb.com/)
> >>> +Copyright (c) 2008-2015 Tom Preston-Werner
> >>> +
> >>> +This product includes Boostrap software (http://getbootstrap.com/)
> >>> +Copyright (c) 2011-2015 Twitter, Inc
> >>> +
> >>> +This product includes jQuery software (http://jquery.com/)
> >>> +Copyright jQuery Foundation and other contributors,
> https://jquery.org/
> >>
> >> AFAICT these 3 attributions are NOT necessary for MIT licensed code, see
> >>
> >> http://www.apache.org/dev/licensing-howto.html#permissive-deps
>
> +1, those should definitely be removed.
>
> Marvin Humphrey
>
Again, apologies for taking a bit long to address this, as these comments
got automatically archived.
I have addressed both of comments now, where :
- License now have one entry per dependency, with proper copyright notice
- Notice file has been cleaned up and added Apache Copyright entry
Please let me know if there are other issues that still needs to be
addressed.
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: apache-website-template git commit: Add LICENSE and NOTICE files
Posted by Marvin Humphrey <ma...@rectangular.com>.
On Thu, Dec 3, 2015 at 5:17 AM, sebb <se...@gmail.com> wrote:
> PING
I'd also like to see this addressed. Licensing documentation for Incubator
sample code should adhere to best practices.
> On 28 November 2015 at 22:59, sebb <se...@gmail.com> wrote:
>> On 28 November 2015 at 16:26, <lr...@apache.org> wrote:
>>> +The following components included on this website are distributed under MIT license :
>>> +
>>> +- Jekyll
>>> +- Jekyll Bootstrap
>>> +- Bootstrap
>>> +- jQuery
>>> +
>>> +The MIT License (MIT):
>>> +
>>> +Permission is hereby granted, free of charge, to any person obtaining a copy
>>> +of this software and associated documentation files (the "Software"), to deal
>>> +in the Software without restriction, including without limitation the rights
>>> +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
>>> +copies of the Software, and to permit persons to whom the Software is
>>> +furnished to do so, subject to the following conditions:
>>> +
>>> +The above copyright notice and this permission notice shall be included in all
>>> +copies or substantial portions of the Software.
>>> +
>>> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>>> +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>>> +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
>>> +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>>> +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
>>> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
>>> +SOFTWARE.
>>> +
>>> +
>>
>> The LICENSE looks OK.
+1, it's OK, though I'd make one suggestion.
The addition of the MIT license text minus the copyright notice (the intent is
clearly to generalize so that it applies to 4 different dependencies) is a bit
irregular. The copyright notice is an integral part of the MIT license --
it's actually a license template and is only completed when the copyright
notice has the owner filled in.
http://opensource.org/licenses/MIT
To addresss the irregularity, I'd suggest either prepending the template line
`Copyright (c) <year> <copyright holders>` -- or simply omitting the text of
the MIT license, instead including filepath pointers to where the deps
can be found in the distro.
>>> http://git-wip-us.apache.org/repos/asf/apache-website-template/blob/9e881e24/NOTICE
>>> ----------------------------------------------------------------------
>>> diff --git a/NOTICE b/NOTICE
>>> new file mode 100644
>>> index 0000000..a4fed15
>>> --- /dev/null
>>> +++ b/NOTICE
>>> @@ -0,0 +1,11 @@
>>
>> The ASF Copright header is missing
>>
>> See http://www.apache.org/legal/src-headers.html#notice
>>
+1
Just the copyright notice, i.e. this:
Apache [PRODUCT_NAME]
Copyright [yyyy] The Apache Software Foundation
Actually, what should "[PRODUCT_NAME]" be in this case?
>>> +This product includes software developed at
>>> +The Apache Software Foundation (http://www.apache.org/).
>>> +
>>
>> That paragraph is OK
>>
>>> +This product uses Jekyll software (http://jekyllrb.com/)
>>> +Copyright (c) 2008-2015 Tom Preston-Werner
>>> +
>>> +This product includes Boostrap software (http://getbootstrap.com/)
>>> +Copyright (c) 2011-2015 Twitter, Inc
>>> +
>>> +This product includes jQuery software (http://jquery.com/)
>>> +Copyright jQuery Foundation and other contributors, https://jquery.org/
>>
>> AFAICT these 3 attributions are NOT necessary for MIT licensed code, see
>>
>> http://www.apache.org/dev/licensing-howto.html#permissive-deps
+1, those should definitely be removed.
Marvin Humphrey
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org